All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Michael Chan <mchan@broadcom.com>
Cc: kbuild-all@01.org, davem@davemloft.net, netdev@vger.kernel.org
Subject: [PATCH] bnxt_en: fix simple_return.cocci warnings
Date: Sat, 10 Oct 2015 20:24:22 +0800	[thread overview]
Message-ID: <20151010122422.GA58821@ivytown2> (raw)
In-Reply-To: <1444477151-2225-1-git-send-email-mchan@broadcom.com>

drivers/net/ethernet/broadcom/bnxt/bnxt.c:4071:1-3: WARNING: end returns can be simpified and declaration on line 4064 can be dropped

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.

Generated by: scripts/coccinelle/misc/simple_return.cocci

CC: Michael Chan <mchan@broadcom.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 bnxt.c |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -4061,18 +4061,12 @@ static int bnxt_shutdown_nic(struct bnxt
 
 static int bnxt_init_nic(struct bnxt *bp, bool irq_re_init)
 {
-	int rc;
-
 	bnxt_init_rx_rings(bp);
 	bnxt_init_tx_rings(bp);
 	bnxt_init_ring_grps(bp, irq_re_init);
 	bnxt_init_vnics(bp);
 
-	rc = bnxt_init_chip(bp, irq_re_init);
-	if (rc)
-		return rc;
-
-	return 0;
+	return bnxt_init_chip(bp, irq_re_init);
 }
 
 static void bnxt_disable_int(struct bnxt *bp)

  parent reply	other threads:[~2015-10-10 12:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-10 11:39 [PATCH net-next] bnxt_en: New Broadcom ethernet driver Michael Chan
2015-10-10 12:23 ` kbuild test robot
2015-10-10 12:24 ` kbuild test robot
2015-10-10 12:24 ` [PATCH] bnxt_en: fix returnvar.cocci warnings kbuild test robot
2015-10-10 12:24 ` kbuild test robot [this message]
2015-10-10 12:24 ` kbuild test robot
2015-10-10 12:24 ` [PATCH] bnxt_en: fix array_size.cocci warnings kbuild test robot
2015-10-10 12:24 ` [PATCH] bnxt_en: fix semicolon.cocci warnings kbuild test robot
2015-10-10 12:24 ` [PATCH] bnxt_en: fix simple_return.cocci warnings kbuild test robot
2015-10-10 15:51 ` [PATCH net-next] bnxt_en: New Broadcom ethernet driver Joe Perches
2015-10-10 17:00 ` kbuild test robot
2015-10-10 19:17 ` kbuild test robot
2015-10-11  6:54 ` Dmitry Kravkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151010122422.GA58821@ivytown2 \
    --to=lkp@intel.com \
    --cc=davem@davemloft.net \
    --cc=kbuild-all@01.org \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.