From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [rtc-linux] Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending
Date: Mon, 12 Oct 2015 08:53:23 +0200 [thread overview]
Message-ID: <20151012065323.GA3558@piout.net> (raw)
In-Reply-To: <1444612677-26178-1-git-send-email-wenyou.yang@atmel.com>
Hi Wenyou,
On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote :
> This patch is to clear the RTC alarm status flag prior to suspending
> to avoid the erroneous wake-up activity.
>
Is this a new issue appearing with the sama5d2 or was it present from
the beginning?
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
> drivers/rtc/rtc-at91rm9200.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
> index cb62e21..b60fd47 100644
> --- a/drivers/rtc/rtc-at91rm9200.c
> +++ b/drivers/rtc/rtc-at91rm9200.c
> @@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
> /* this IRQ is shared with DBGU and other hardware which isn't
> * necessarily doing PM like we are...
> */
> + at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
> +
> at91_rtc_imr = at91_rtc_read_imr()
> & (AT91_RTC_ALARM|AT91_RTC_SECEV);
> if (at91_rtc_imr) {
> --
> 1.7.9.5
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending
Date: Mon, 12 Oct 2015 08:53:23 +0200 [thread overview]
Message-ID: <20151012065323.GA3558@piout.net> (raw)
In-Reply-To: <1444612677-26178-1-git-send-email-wenyou.yang@atmel.com>
Hi Wenyou,
On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote :
> This patch is to clear the RTC alarm status flag prior to suspending
> to avoid the erroneous wake-up activity.
>
Is this a new issue appearing with the sama5d2 or was it present from
the beginning?
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
> drivers/rtc/rtc-at91rm9200.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
> index cb62e21..b60fd47 100644
> --- a/drivers/rtc/rtc-at91rm9200.c
> +++ b/drivers/rtc/rtc-at91rm9200.c
> @@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
> /* this IRQ is shared with DBGU and other hardware which isn't
> * necessarily doing PM like we are...
> */
> + at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
> +
> at91_rtc_imr = at91_rtc_read_imr()
> & (AT91_RTC_ALARM|AT91_RTC_SECEV);
> if (at91_rtc_imr) {
> --
> 1.7.9.5
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending
Date: Mon, 12 Oct 2015 08:53:23 +0200 [thread overview]
Message-ID: <20151012065323.GA3558@piout.net> (raw)
In-Reply-To: <1444612677-26178-1-git-send-email-wenyou.yang@atmel.com>
Hi Wenyou,
On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote :
> This patch is to clear the RTC alarm status flag prior to suspending
> to avoid the erroneous wake-up activity.
>
Is this a new issue appearing with the sama5d2 or was it present from
the beginning?
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
> drivers/rtc/rtc-at91rm9200.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
> index cb62e21..b60fd47 100644
> --- a/drivers/rtc/rtc-at91rm9200.c
> +++ b/drivers/rtc/rtc-at91rm9200.c
> @@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
> /* this IRQ is shared with DBGU and other hardware which isn't
> * necessarily doing PM like we are...
> */
> + at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
> +
> at91_rtc_imr = at91_rtc_read_imr()
> & (AT91_RTC_ALARM|AT91_RTC_SECEV);
> if (at91_rtc_imr) {
> --
> 1.7.9.5
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-12 6:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 1:17 [rtc-linux] [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending Wenyou Yang
2015-10-12 1:17 ` Wenyou Yang
2015-10-12 1:17 ` Wenyou Yang
2015-10-12 6:53 ` Alexandre Belloni [this message]
2015-10-12 6:53 ` Alexandre Belloni
2015-10-12 6:53 ` Alexandre Belloni
2015-10-12 7:48 ` [rtc-linux] " Yang, Wenyou
2015-10-12 7:48 ` Yang, Wenyou
2015-10-12 7:48 ` Yang, Wenyou
2015-10-12 7:51 ` [rtc-linux] " Alexandre Belloni
2015-10-12 7:51 ` Alexandre Belloni
2015-10-12 7:51 ` Alexandre Belloni
2015-10-12 7:55 ` [rtc-linux] " Yang, Wenyou
2015-10-12 7:55 ` Yang, Wenyou
2015-10-12 7:55 ` Yang, Wenyou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012065323.GA3558@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
--cc=rtc-linux@googlegroups.com \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.