From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: mvebu: disable unused Armada RTC on ReadyNAS 102, 104 and 2120
Date: Mon, 12 Oct 2015 16:21:12 +0200 [thread overview]
Message-ID: <20151012142112.GA30801@lunn.ch> (raw)
In-Reply-To: <2e62abb84de02c0495bde9d60a90282deae40967.1444428035.git.arno@natisbad.org>
On Sat, Oct 10, 2015 at 12:10:24AM +0200, Arnaud Ebalard wrote:
>
> By default, armada-370-xp.dtsi file has internal RTC enabled.
> NETGEAR ReadyNAS 102, 104 and 2120 all use an Intersil ISL12057
> I2C RTC chip. The internal RTC not being disabled in the .dts
> files of those devices result in the following useless first
> line during boot:
>
> [ 4.500056] rtc-mv d0010300.rtc: internal RTC not ticking
> [ 4.505684] i2c /dev entries driver
> [ 4.513246] rtc-isl12057 0-0068: rtc core: registered rtc-isl12057 as rtc0
>
> This patch marks Armada internal RTC as disabled in individual .dts
> files of those devices.
>
> Reported-by: TuxOholic <tuxoholic@hotmail.de>
> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Thanks Arnaud
Andrew
> ---
> arch/arm/boot/dts/armada-370-netgear-rn102.dts | 6 ++++++
> arch/arm/boot/dts/armada-370-netgear-rn104.dts | 6 ++++++
> arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 6 ++++++
> 3 files changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-370-netgear-rn102.dts b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> index a31207860f34..5851964196bd 100644
> --- a/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> +++ b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> @@ -82,6 +82,12 @@
> };
>
> internal-regs {
> +
> + /* RTC is provided by Intersil ISL12057 I2C RTC chip */
> + rtc at 10300 {
> + status = "disabled";
> + };
> +
> serial at 12000 {
> status = "okay";
> };
> diff --git a/arch/arm/boot/dts/armada-370-netgear-rn104.dts b/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> index 00540f292979..b0b07ba677b9 100644
> --- a/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> +++ b/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> @@ -82,6 +82,12 @@
> };
>
> internal-regs {
> +
> + /* RTC is provided by Intersil ISL12057 I2C RTC chip */
> + rtc at 10300 {
> + status = "disabled";
> + };
> +
> serial at 12000 {
> status = "okay";
> };
> diff --git a/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts b/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts
> index 1516fc2627f9..85b2f87c0b8a 100644
> --- a/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts
> +++ b/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts
> @@ -88,6 +88,12 @@
> };
>
> internal-regs {
> +
> + /* RTC is provided by Intersil ISL12057 I2C RTC chip */
> + rtc at 10300 {
> + status = "disabled";
> + };
> +
> /* Two rear eSATA ports */
> sata at a0000 {
> nr-ports = <2>;
> --
> 2.5.3
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
TuxOholic <tuxoholic-PkbjNfxxIASELgA04lAiVw@public.gmane.org>
Subject: Re: [PATCH 1/2] arm: mvebu: disable unused Armada RTC on ReadyNAS 102, 104 and 2120
Date: Mon, 12 Oct 2015 16:21:12 +0200 [thread overview]
Message-ID: <20151012142112.GA30801@lunn.ch> (raw)
In-Reply-To: <2e62abb84de02c0495bde9d60a90282deae40967.1444428035.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
On Sat, Oct 10, 2015 at 12:10:24AM +0200, Arnaud Ebalard wrote:
>
> By default, armada-370-xp.dtsi file has internal RTC enabled.
> NETGEAR ReadyNAS 102, 104 and 2120 all use an Intersil ISL12057
> I2C RTC chip. The internal RTC not being disabled in the .dts
> files of those devices result in the following useless first
> line during boot:
>
> [ 4.500056] rtc-mv d0010300.rtc: internal RTC not ticking
> [ 4.505684] i2c /dev entries driver
> [ 4.513246] rtc-isl12057 0-0068: rtc core: registered rtc-isl12057 as rtc0
>
> This patch marks Armada internal RTC as disabled in individual .dts
> files of those devices.
>
> Reported-by: TuxOholic <tuxoholic-PkbjNfxxIASELgA04lAiVw@public.gmane.org>
> Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
Acked-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Thanks Arnaud
Andrew
> ---
> arch/arm/boot/dts/armada-370-netgear-rn102.dts | 6 ++++++
> arch/arm/boot/dts/armada-370-netgear-rn104.dts | 6 ++++++
> arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 6 ++++++
> 3 files changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-370-netgear-rn102.dts b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> index a31207860f34..5851964196bd 100644
> --- a/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> +++ b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> @@ -82,6 +82,12 @@
> };
>
> internal-regs {
> +
> + /* RTC is provided by Intersil ISL12057 I2C RTC chip */
> + rtc@10300 {
> + status = "disabled";
> + };
> +
> serial@12000 {
> status = "okay";
> };
> diff --git a/arch/arm/boot/dts/armada-370-netgear-rn104.dts b/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> index 00540f292979..b0b07ba677b9 100644
> --- a/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> +++ b/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> @@ -82,6 +82,12 @@
> };
>
> internal-regs {
> +
> + /* RTC is provided by Intersil ISL12057 I2C RTC chip */
> + rtc@10300 {
> + status = "disabled";
> + };
> +
> serial@12000 {
> status = "okay";
> };
> diff --git a/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts b/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts
> index 1516fc2627f9..85b2f87c0b8a 100644
> --- a/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts
> +++ b/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts
> @@ -88,6 +88,12 @@
> };
>
> internal-regs {
> +
> + /* RTC is provided by Intersil ISL12057 I2C RTC chip */
> + rtc@10300 {
> + status = "disabled";
> + };
> +
> /* Two rear eSATA ports */
> sata@a0000 {
> nr-ports = <2>;
> --
> 2.5.3
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Arnaud Ebalard <arno@natisbad.org>
Cc: Jason Cooper <jason@lakedaemon.net>,
Gregory Clement <gregory.clement@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, TuxOholic <tuxoholic@hotmail.de>
Subject: Re: [PATCH 1/2] arm: mvebu: disable unused Armada RTC on ReadyNAS 102, 104 and 2120
Date: Mon, 12 Oct 2015 16:21:12 +0200 [thread overview]
Message-ID: <20151012142112.GA30801@lunn.ch> (raw)
In-Reply-To: <2e62abb84de02c0495bde9d60a90282deae40967.1444428035.git.arno@natisbad.org>
On Sat, Oct 10, 2015 at 12:10:24AM +0200, Arnaud Ebalard wrote:
>
> By default, armada-370-xp.dtsi file has internal RTC enabled.
> NETGEAR ReadyNAS 102, 104 and 2120 all use an Intersil ISL12057
> I2C RTC chip. The internal RTC not being disabled in the .dts
> files of those devices result in the following useless first
> line during boot:
>
> [ 4.500056] rtc-mv d0010300.rtc: internal RTC not ticking
> [ 4.505684] i2c /dev entries driver
> [ 4.513246] rtc-isl12057 0-0068: rtc core: registered rtc-isl12057 as rtc0
>
> This patch marks Armada internal RTC as disabled in individual .dts
> files of those devices.
>
> Reported-by: TuxOholic <tuxoholic@hotmail.de>
> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Thanks Arnaud
Andrew
> ---
> arch/arm/boot/dts/armada-370-netgear-rn102.dts | 6 ++++++
> arch/arm/boot/dts/armada-370-netgear-rn104.dts | 6 ++++++
> arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 6 ++++++
> 3 files changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-370-netgear-rn102.dts b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> index a31207860f34..5851964196bd 100644
> --- a/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> +++ b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
> @@ -82,6 +82,12 @@
> };
>
> internal-regs {
> +
> + /* RTC is provided by Intersil ISL12057 I2C RTC chip */
> + rtc@10300 {
> + status = "disabled";
> + };
> +
> serial@12000 {
> status = "okay";
> };
> diff --git a/arch/arm/boot/dts/armada-370-netgear-rn104.dts b/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> index 00540f292979..b0b07ba677b9 100644
> --- a/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> +++ b/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> @@ -82,6 +82,12 @@
> };
>
> internal-regs {
> +
> + /* RTC is provided by Intersil ISL12057 I2C RTC chip */
> + rtc@10300 {
> + status = "disabled";
> + };
> +
> serial@12000 {
> status = "okay";
> };
> diff --git a/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts b/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts
> index 1516fc2627f9..85b2f87c0b8a 100644
> --- a/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts
> +++ b/arch/arm/boot/dts/armada-xp-netgear-rn2120.dts
> @@ -88,6 +88,12 @@
> };
>
> internal-regs {
> +
> + /* RTC is provided by Intersil ISL12057 I2C RTC chip */
> + rtc@10300 {
> + status = "disabled";
> + };
> +
> /* Two rear eSATA ports */
> sata@a0000 {
> nr-ports = <2>;
> --
> 2.5.3
>
>
next prev parent reply other threads:[~2015-10-12 14:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 22:10 [PATCH 0/2] arm: mvebu: disable unused rtc + cosmetic patch for ReadyNAS devices Arnaud Ebalard
2015-10-09 22:10 ` Arnaud Ebalard
2015-10-09 22:10 ` [PATCH 1/2] arm: mvebu: disable unused Armada RTC on ReadyNAS 102, 104 and 2120 Arnaud Ebalard
2015-10-09 22:10 ` Arnaud Ebalard
2015-10-12 14:21 ` Andrew Lunn [this message]
2015-10-12 14:21 ` Andrew Lunn
2015-10-12 14:21 ` Andrew Lunn
2015-10-12 16:31 ` Gregory CLEMENT
2015-10-12 16:31 ` Gregory CLEMENT
2015-10-09 22:10 ` [PATCH 2/2] arm: mvebu: reorder nodes under internal-regs by address in RN2120 .dts file Arnaud Ebalard
2015-10-09 22:10 ` Arnaud Ebalard
2015-10-12 14:23 ` Andrew Lunn
2015-10-12 14:23 ` Andrew Lunn
2015-10-12 16:32 ` Gregory CLEMENT
2015-10-12 16:32 ` Gregory CLEMENT
2015-10-12 16:32 ` Gregory CLEMENT
2015-10-12 16:27 ` Gregory CLEMENT
2015-10-12 16:27 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012142112.GA30801@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.