* [PATCH] NVMe: Add explicit block config dependency
@ 2015-10-12 17:37 Keith Busch
2015-10-12 17:42 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Keith Busch @ 2015-10-12 17:37 UTC (permalink / raw)
The nvme driver was moved from drivers/block, losing our implicit
dependency on CONFIG_BLOCK. This makes it an explicit driver dependency.
Reported-by: Jim Davis <jim.epost at gmail.com>
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
drivers/nvme/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
index 0089f78..002a94a 100644
--- a/drivers/nvme/host/Kconfig
+++ b/drivers/nvme/host/Kconfig
@@ -1,6 +1,6 @@
config BLK_DEV_NVME
tristate "NVM Express block device"
- depends on PCI
+ depends on PCI && BLOCK
---help---
The NVM Express driver is for solid state drives directly
connected to the PCI or PCI Express bus. If you know you
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] NVMe: Add explicit block config dependency
2015-10-12 17:37 [PATCH] NVMe: Add explicit block config dependency Keith Busch
@ 2015-10-12 17:42 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2015-10-12 17:42 UTC (permalink / raw)
On Mon, Oct 12, 2015@11:37:38AM -0600, Keith Busch wrote:
> The nvme driver was moved from drivers/block, losing our implicit
> dependency on CONFIG_BLOCK. This makes it an explicit driver dependency.
>
> Reported-by: Jim Davis <jim.epost at gmail.com>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
Oh, that explains the odd errors - I actually just got a similar one
from the buildbot and couldn't make sense of it.
Looks good,
Reviewed-by: Christoph Hellwig <hch at lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-12 17:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-12 17:37 [PATCH] NVMe: Add explicit block config dependency Keith Busch
2015-10-12 17:42 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.