All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: vt6655: mac: Remove extra braces
@ 2015-10-12 17:44 Shivani Bhardwaj
  2015-10-12 17:48 ` [Outreachy kernel] " Daniel Baluta
  0 siblings, 1 reply; 2+ messages in thread
From: Shivani Bhardwaj @ 2015-10-12 17:44 UTC (permalink / raw)
  To: outreachy-kernel

Remove braces from an if block as it comprises of a single statement.
Fix checkpatch warning: braces {} are not necessary for single statement
blocks

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/staging/vt6655/mac.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
index 3dfd333..688c3be 100644
--- a/drivers/staging/vt6655/mac.c
+++ b/drivers/staging/vt6655/mac.c
@@ -689,9 +689,8 @@ void MACvSetCurrAC0DescAddrEx(void __iomem *dwIoBase,
 		if (!(byData & DMACTL_RUN))
 			break;
 	}
-	if (ww == W_MAX_TIMEOUT) {
+	if (ww == W_MAX_TIMEOUT)
 		pr_debug(" DBG_PORT80(0x26)\n");
-	}
 	VNSvOutPortD(dwIoBase + MAC_REG_AC0DMAPTR, dwCurrDescAddr);
 	if (byOrgDMACtl & DMACTL_RUN)
 		VNSvOutPortB(dwIoBase + MAC_REG_AC0DMACTL, DMACTL_RUN);
-- 
2.1.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel] [PATCH] Staging: vt6655: mac: Remove extra braces
  2015-10-12 17:44 [PATCH] Staging: vt6655: mac: Remove extra braces Shivani Bhardwaj
@ 2015-10-12 17:48 ` Daniel Baluta
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Baluta @ 2015-10-12 17:48 UTC (permalink / raw)
  To: Shivani Bhardwaj; +Cc: outreachy-kernel

On Mon, Oct 12, 2015 at 8:44 PM, Shivani Bhardwaj <shivanib134@gmail.com> wrote:
> Remove braces from an if block as it comprises of a single statement.
> Fix checkpatch warning: braces {} are not necessary for single statement
> blocks
>
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>

Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>

> ---
>  drivers/staging/vt6655/mac.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
> index 3dfd333..688c3be 100644
> --- a/drivers/staging/vt6655/mac.c
> +++ b/drivers/staging/vt6655/mac.c
> @@ -689,9 +689,8 @@ void MACvSetCurrAC0DescAddrEx(void __iomem *dwIoBase,
>                 if (!(byData & DMACTL_RUN))
>                         break;
>         }
> -       if (ww == W_MAX_TIMEOUT) {
> +       if (ww == W_MAX_TIMEOUT)
>                 pr_debug(" DBG_PORT80(0x26)\n");
> -       }
>         VNSvOutPortD(dwIoBase + MAC_REG_AC0DMAPTR, dwCurrDescAddr);
>         if (byOrgDMACtl & DMACTL_RUN)
>                 VNSvOutPortB(dwIoBase + MAC_REG_AC0DMACTL, DMACTL_RUN);
> --
> 2.1.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151012174415.GA48424%40ubuntu.
> For more options, visit https://groups.google.com/d/optout.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-12 17:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-12 17:44 [PATCH] Staging: vt6655: mac: Remove extra braces Shivani Bhardwaj
2015-10-12 17:48 ` [Outreachy kernel] " Daniel Baluta

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.