From: Sam Ravnborg <sam@ravnborg.org>
To: yalin wang <yalin.wang2010@gmail.com>
Cc: linux@arm.linux.org.uk, arnd@arndb.de, ard.biesheuvel@linaro.org,
will.deacon@arm.com, nico@linaro.org, keescook@chromium.org,
catalin.marinas@arm.com, victor.kamensky@linaro.org,
msalter@redhat.com, vladimir.murzin@arm.com, ggdavisiv@gmail.com,
paul.gortmaker@windriver.com, mingo@kernel.org,
rusty@rustcorp.com.au, mcgrof@suse.com,
akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
n-horiguchi@ah.jp.nec.com, aarcange@redhat.com, mhocko@suse.com,
jack@suse.cz, iamjoonsoo.kim@lge.com, xiexiuqi@huawei.com,
vbabka@suse.cz, Vineet.Gupta1@synopsys.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [RFC] arm: add __initbss section attribute
Date: Mon, 12 Oct 2015 22:04:23 +0200 [thread overview]
Message-ID: <20151012200422.GA29175@ravnborg.org> (raw)
In-Reply-To: <1444622356-8263-1-git-send-email-yalin.wang2010@gmail.com>
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
>
> -#define BSS_SECTION(sbss_align, bss_align, stop_align) \
> +#define BSS_SECTION(sbss_align, bss_align, initbss_align, stop_align) \
A few comments:
1) - please align the backslash at the end of the
line with the backslash above it.
2) - you need to fix all the remaining users of BSS_SECTION.
3) - do we really need the flexibility to specify an alignment (stop_align)?
If not - drop the extra argument.
Sam
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: yalin wang <yalin.wang2010@gmail.com>
Cc: linux@arm.linux.org.uk, arnd@arndb.de, ard.biesheuvel@linaro.org,
will.deacon@arm.com, nico@linaro.org, keescook@chromium.org,
catalin.marinas@arm.com, victor.kamensky@linaro.org,
msalter@redhat.com, vladimir.murzin@arm.com, ggdavisiv@gmail.com,
paul.gortmaker@windriver.com, mingo@kernel.org,
rusty@rustcorp.com.au, mcgrof@suse.com,
akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
n-horiguchi@ah.jp.nec.com, aarcange@redhat.com, mhocko@suse.com,
jack@suse.cz, iamjoonsoo.kim@lge.com, xiexiuqi@huawei.com,
vbabka@suse.cz, Vineet.Gupta1@synopsys.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [RFC] arm: add __initbss section attribute
Date: Mon, 12 Oct 2015 22:04:23 +0200 [thread overview]
Message-ID: <20151012200422.GA29175@ravnborg.org> (raw)
Message-ID: <20151012200423.gzTyF3yxaY7a49AgQir8wyNQ9Ln7RHBPJt6yJmjzoyo@z> (raw)
In-Reply-To: <1444622356-8263-1-git-send-email-yalin.wang2010@gmail.com>
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
>
> -#define BSS_SECTION(sbss_align, bss_align, stop_align) \
> +#define BSS_SECTION(sbss_align, bss_align, initbss_align, stop_align) \
A few comments:
1) - please align the backslash at the end of the
line with the backslash above it.
2) - you need to fix all the remaining users of BSS_SECTION.
3) - do we really need the flexibility to specify an alignment (stop_align)?
If not - drop the extra argument.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: sam@ravnborg.org (Sam Ravnborg)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] arm: add __initbss section attribute
Date: Mon, 12 Oct 2015 22:04:23 +0200 [thread overview]
Message-ID: <20151012200422.GA29175@ravnborg.org> (raw)
In-Reply-To: <1444622356-8263-1-git-send-email-yalin.wang2010@gmail.com>
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
>
> -#define BSS_SECTION(sbss_align, bss_align, stop_align) \
> +#define BSS_SECTION(sbss_align, bss_align, initbss_align, stop_align) \
A few comments:
1) - please align the backslash at the end of the
line with the backslash above it.
2) - you need to fix all the remaining users of BSS_SECTION.
3) - do we really need the flexibility to specify an alignment (stop_align)?
If not - drop the extra argument.
Sam
next prev parent reply other threads:[~2015-10-12 20:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 3:59 [RFC] arm: add __initbss section attribute yalin wang
2015-10-12 3:59 ` yalin wang
2015-10-12 3:59 ` yalin wang
2015-10-12 8:22 ` Ard Biesheuvel
2015-10-12 8:22 ` Ard Biesheuvel
2015-10-12 8:22 ` Ard Biesheuvel
2015-10-12 8:22 ` Ard Biesheuvel
2015-10-12 8:46 ` yalin wang
2015-10-12 8:46 ` yalin wang
2015-10-12 8:46 ` yalin wang
2015-10-12 8:46 ` yalin wang
2015-10-12 10:21 ` Arnd Bergmann
2015-10-12 10:21 ` Arnd Bergmann
2015-10-12 10:21 ` Arnd Bergmann
2015-10-12 20:04 ` Sam Ravnborg [this message]
2015-10-12 20:04 ` Sam Ravnborg
2015-10-12 20:04 ` Sam Ravnborg
2015-10-13 7:33 ` yalin wang
2015-10-13 9:40 ` Arnd Bergmann
2015-10-13 9:40 ` Arnd Bergmann
2015-10-13 9:40 ` Arnd Bergmann
2015-10-13 9:40 ` Arnd Bergmann
2015-10-13 9:51 ` yalin wang
2015-10-13 9:51 ` yalin wang
2015-10-13 9:51 ` yalin wang
2015-10-13 11:28 ` Arnd Bergmann
2015-10-13 11:28 ` Arnd Bergmann
2015-10-13 11:28 ` Arnd Bergmann
2015-10-13 11:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012200422.GA29175@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Vineet.Gupta1@synopsys.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=ggdavisiv@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jack@suse.cz \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mcgrof@suse.com \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=msalter@redhat.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=nico@linaro.org \
--cc=paul.gortmaker@windriver.com \
--cc=rusty@rustcorp.com.au \
--cc=vbabka@suse.cz \
--cc=victor.kamensky@linaro.org \
--cc=vladimir.murzin@arm.com \
--cc=will.deacon@arm.com \
--cc=xiexiuqi@huawei.com \
--cc=yalin.wang2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.