All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [REPOST PATCH 1/4] ARM: dts: DRA7: Add dsp1_system syscon node
Date: Mon, 12 Oct 2015 14:43:04 -0700	[thread overview]
Message-ID: <20151012214304.GD23801@atomide.com> (raw)
In-Reply-To: <1443828205-18706-2-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>

* Suman Anna <s-anna-l0cyMroinI0@public.gmane.org> [151002 16:27]:
> The DSP_SYSTEM sub-module is a dedicated system control logic
> module present within a DRA7 DSP processor sub-system. This
> module is responsible for power management, clock generation
> and connection to the device PRCM module.
> 
> Add a syscon node for this module for the DSP1 processor
> sub-system. This is added as a syscon node as it is a common
> configuration module that can be used by the different IOMMU
> instances and the corresponding remoteproc device.
> 
> The node is added to the common dra7.dtsi file, as the DSP1
> processor sub-system is mostly common across all the variants
> of the DRA7 SoC family.
> 
> Signed-off-by: Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
> ---
>  arch/arm/boot/dts/dra7.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index e289c706d27d..62055094e8d5 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -292,6 +292,11 @@
>  				#thermal-sensor-cells = <1>;
>  		};
>  
> +		dsp1_system: dsp_system@40d00000 {
> +			compatible = "syscon";
> +			reg = <0x40d00000 0x100>;
> +		};
> +
>  		sdma: dma-controller@4a056000 {
>  			compatible = "ti,omap4430-sdma";
>  			reg = <0x4a056000 0x1000>;

Hmm so why would you want to set up a complete device as a syscon
mapping rather than just doing ioremap on it?

What drivers will be sharing access to these registers?

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [REPOST PATCH 1/4] ARM: dts: DRA7: Add dsp1_system syscon node
Date: Mon, 12 Oct 2015 14:43:04 -0700	[thread overview]
Message-ID: <20151012214304.GD23801@atomide.com> (raw)
In-Reply-To: <1443828205-18706-2-git-send-email-s-anna@ti.com>

* Suman Anna <s-anna@ti.com> [151002 16:27]:
> The DSP_SYSTEM sub-module is a dedicated system control logic
> module present within a DRA7 DSP processor sub-system. This
> module is responsible for power management, clock generation
> and connection to the device PRCM module.
> 
> Add a syscon node for this module for the DSP1 processor
> sub-system. This is added as a syscon node as it is a common
> configuration module that can be used by the different IOMMU
> instances and the corresponding remoteproc device.
> 
> The node is added to the common dra7.dtsi file, as the DSP1
> processor sub-system is mostly common across all the variants
> of the DRA7 SoC family.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
>  arch/arm/boot/dts/dra7.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index e289c706d27d..62055094e8d5 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -292,6 +292,11 @@
>  				#thermal-sensor-cells = <1>;
>  		};
>  
> +		dsp1_system: dsp_system at 40d00000 {
> +			compatible = "syscon";
> +			reg = <0x40d00000 0x100>;
> +		};
> +
>  		sdma: dma-controller at 4a056000 {
>  			compatible = "ti,omap4430-sdma";
>  			reg = <0x4a056000 0x1000>;

Hmm so why would you want to set up a complete device as a syscon
mapping rather than just doing ioremap on it?

What drivers will be sharing access to these registers?

Regards,

Tony

  parent reply	other threads:[~2015-10-12 21:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 23:23 [REPOST PATCH 0/4] Add DRA7 IOMMU DT nodes Suman Anna
2015-10-02 23:23 ` Suman Anna
     [not found] ` <1443828205-18706-1-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
2015-10-02 23:23   ` [REPOST PATCH 1/4] ARM: dts: DRA7: Add dsp1_system syscon node Suman Anna
2015-10-02 23:23     ` Suman Anna
     [not found]     ` <1443828205-18706-2-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
2015-10-12 21:43       ` Tony Lindgren [this message]
2015-10-12 21:43         ` Tony Lindgren
     [not found]         ` <20151012214304.GD23801-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-10-12 22:32           ` Suman Anna
2015-10-12 22:32             ` Suman Anna
     [not found]             ` <561C351B.3060307-l0cyMroinI0@public.gmane.org>
2015-10-12 22:50               ` Tony Lindgren
2015-10-12 22:50                 ` Tony Lindgren
     [not found]                 ` <20151012225001.GK23801-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-10-12 22:55                   ` Tony Lindgren
2015-10-12 22:55                     ` Tony Lindgren
2015-10-02 23:23   ` [REPOST PATCH 2/4] ARM: dts: DRA74x: Add dsp2_system " Suman Anna
2015-10-02 23:23     ` Suman Anna
2015-10-02 23:23   ` [REPOST PATCH 3/4] ARM: dts: DRA7: Add common IOMMU nodes Suman Anna
2015-10-02 23:23     ` Suman Anna
2015-10-02 23:23   ` [REPOST PATCH 4/4] ARM: dts: DRA74x: Add IOMMU nodes for DSP2 Suman Anna
2015-10-02 23:23     ` Suman Anna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151012214304.GD23801@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=s-anna-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.