* [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
@ 2015-10-12 21:12 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
While working on regulators, GPIOs and DT I noticed that many of our DT source
files incorrectly describe fixed regulators. The common error patterns are
- Usage of the undefined (and never parsed) enable-active-low property
- Usage of the enable-active-high property without specifying an enable GPIO
- Typos in the enabl GPIO property name (gpios instead of gpio)
- Mismatch between the enable-active-high property (or the lack thereof) and
the enable GPIO flags
This patch series fixes those issues in all the DT sources after locating the
errors using the following script.
------------------------------------------------------------------------------
#!/bin/sh
echo $1
cat $1 | awk '
BEGIN {
open_drain = 0;
active_high = 0;
gpio = 0;
flags = 0;
}
match($0, /([a-zA-Z0-9 at _-]*) {/, ary) {
name = ary[1];
}
/compatible.*"regulator-fixed"/ {
found = 1;
}
/enable-active-high/ {
active_high = 1;
}
/gpio-open-drain/ {
open_drain = 1;
}
match($0, /gpio += <.* ([^ ]*)>/, ary) {
gpio = 1;
flags = ary[1];
if (flags == 0)
flags = "GPIO_ACTIVE_HIGH";
}
/}/ {
if (found) {
if (gpio) {
print "\t" name ": active high " active_high " " flags " open drain " open_drain;
if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
(!active_high && flags == "GPIO_ACTIVE_HIGH"))
print "WARNING: enable-active-high and flags do not match"
} else {
if (active_high)
print "WARNING: active high without GPIO"
if (open_drain)
print "WARNING: open drain without GPIO"
}
}
gpio = 0;
found = 0;
active_high = 0;
open_drain = 0;
flags = 0;
}
'
------------------------------------------------------------------------------
All patches except for the ones touching omap3-beagle-xm and omap3-overo-base
are untested as I lack test hardware.
As there's no dependency between the patches touching different source files
the appropriate maintainers could take their share of the patches in their
tree. Alternatively I could send a single pull request after collecting all
acks but that might be more complex.
Cc: devicetree at vger.kernel.org
Cc: linux-omap at vger.kernel.org
Cc: linux-samsung-soc at vger.kernel.org
Cc: linux-tegra at vger.kernel.org
Cc: linux-gpio at vger.kernel.org
Cc: linux-kernel at vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Laurent Pinchart (37):
ARM: dts: am437x-gp-evm: Remove unneeded regulator property
ARM: dts: am43xx-epos-evm: Remove unneeded regulator property
ARM: mvebu: Armada 388 GP: Remove unneeded regulator property
ARM: imx6sx-sdb: Fix typo in regulator enable GPIO property
ARM: dts: s5pv210-aquila: Fix typo in regulator enable GPIO property
ARM: dts: s5pv210-goni: Fix typo in regulator enable GPIO property
ARM: dts: omap3-evm: Remove invalid enable-active-low regulator
property
ARM: dts: omap3-sb-t35: Remove invalid enable-active-low regulator
property
ARM: dts: omap3-tao3530: Remove invalid enable-active-low regulator
property
ARM: dts: imx6qdl-tx6: Fix regulator enable GPIO polarity
ARM: dts: dove-cm-a510: Fix regulator enable GPIO polarity
ARM: dts: dove-sbc-a510: Fix regulator enable GPIO polarity
ARM: dts: exynos5250-arndale: Fix regulator enable GPIO polarity
ARM: dts: imx23-evk: Fix regulator enable GPIO polarity
ARM: dts: imx23-stmp378x_devb: Fix regulator enable GPIO polarity
ARM: dts: imx25-pdk: Fix regulator enable GPIO polarity
ARM: dts: imx28-cfa10036: Fix regulator enable GPIO polarity
ARM: dts: imx28-evk: Fix regulator enable GPIO polarity
ARM: dts: imx28-m28cu3: Fix regulator enable GPIO polarity
ARM: dts: imx28-m28evk: Fix regulator enable GPIO polarity
ARM: dts: imx28-sps1: Fix regulator enable GPIO polarity
ARM: dts: imx28-tx28: Fix regulator enable GPIO polarity
ARM: dts: imx53-m53evk: Fix regulator enable GPIO polarity
ARM: dts: imx53-mba53: Fix regulator enable GPIO polarity
ARM: dts: imx53-tx53: Fix regulator enable GPIO polarity
ARM: dts: imx6q-dmo-edmqmx6: Fix regulator enable GPIO polarity
ARM: dts: kirkwood-blackarmor-nas220: Fix regulator enable GPIO
polarity
ARM: dts: omap4-duovero: Fix regulator enable GPIO polarity
ARM: dts: kirkwood-nsa3x0-common: Fix regulator enable GPIO polarity
ARM: dts: omap3-beagle-xm: Fix regulator enable GPIO polarity
ARM: dts: omap3-beagle: Fix regulator enable GPIO polarity
ARM: dts: omap3-overo-base: Fix regulator enable GPIO polarity
ARM: dts: omap3-tao3530: Fix regulator enable GPIO polarity
ARM: dts: tegra20-harmony: Fix regulator enable GPIO polarity
ARM: dts: tegra20-iris-512: Fix regulator enable GPIO polarity
ARM: dts: tegra20-seaboard: Fix regulator enable GPIO polarity
ARM: dts: tegra20-ventana: Fix regulator enable GPIO polarity
arch/arm/boot/dts/am437x-gp-evm.dts | 1 -
arch/arm/boot/dts/am43x-epos-evm.dts | 1 -
arch/arm/boot/dts/armada-388-gp.dts | 2 --
arch/arm/boot/dts/dove-cm-a510.dtsi | 2 +-
arch/arm/boot/dts/dove-sbc-a510.dts | 4 ++--
arch/arm/boot/dts/exynos5250-arndale.dts | 2 +-
arch/arm/boot/dts/imx23-evk.dts | 3 ++-
arch/arm/boot/dts/imx23-stmp378x_devb.dts | 3 ++-
arch/arm/boot/dts/imx25-pdk.dts | 2 +-
arch/arm/boot/dts/imx28-cfa10036.dts | 2 +-
arch/arm/boot/dts/imx28-evk.dts | 4 ++--
arch/arm/boot/dts/imx28-m28cu3.dts | 4 ++--
arch/arm/boot/dts/imx28-m28evk.dts | 6 +++---
arch/arm/boot/dts/imx28-sps1.dts | 2 +-
arch/arm/boot/dts/imx28-tx28.dts | 2 +-
arch/arm/boot/dts/imx53-m53evk.dts | 2 +-
arch/arm/boot/dts/imx53-mba53.dts | 2 +-
arch/arm/boot/dts/imx53-tx53.dtsi | 2 +-
arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 2 +-
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 3 +--
arch/arm/boot/dts/imx6sx-sdb.dtsi | 2 +-
arch/arm/boot/dts/kirkwood-blackarmor-nas220.dts | 4 ++--
arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi | 2 +-
arch/arm/boot/dts/omap3-beagle-xm.dts | 2 +-
arch/arm/boot/dts/omap3-beagle.dts | 2 +-
arch/arm/boot/dts/omap3-evm-common.dtsi | 1 -
arch/arm/boot/dts/omap3-overo-base.dtsi | 4 ++--
arch/arm/boot/dts/omap3-sb-t35.dtsi | 1 -
arch/arm/boot/dts/omap3-tao3530.dtsi | 3 +--
arch/arm/boot/dts/omap4-duovero.dtsi | 2 +-
arch/arm/boot/dts/s5pv210-aquila.dts | 2 +-
arch/arm/boot/dts/s5pv210-goni.dts | 4 ++--
arch/arm/boot/dts/tegra20-harmony.dts | 2 +-
arch/arm/boot/dts/tegra20-iris-512.dts | 2 +-
arch/arm/boot/dts/tegra20-seaboard.dts | 2 +-
arch/arm/boot/dts/tegra20-ventana.dts | 2 +-
36 files changed, 41 insertions(+), 47 deletions(-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 90+ messages in thread* [PATCH 01/37] ARM: dts: am437x-gp-evm: Remove unneeded regulator property
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Tony Lindgren, linux-omap, Benoit Cousson
The enable-active-high regulator property only makes sense when an
enable GPIO is specified. Remove it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/am437x-gp-evm.dts | 1 -
1 file changed, 1 deletion(-)
Cc: linux-omap@vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 84aa30c3235a..a3cd413aebf0 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -29,7 +29,6 @@
regulator-name = "vmmcsd_fixed";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- enable-active-high;
};
vtt_fixed: fixedregulator-vtt {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 01/37] ARM: dts: am437x-gp-evm: Remove unneeded regulator property
@ 2015-10-12 21:12 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable-active-high regulator property only makes sense when an
enable GPIO is specified. Remove it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/am437x-gp-evm.dts | 1 -
1 file changed, 1 deletion(-)
Cc: linux-omap at vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 84aa30c3235a..a3cd413aebf0 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -29,7 +29,6 @@
regulator-name = "vmmcsd_fixed";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- enable-active-high;
};
vtt_fixed: fixedregulator-vtt {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 02/37] ARM: dts: am43xx-epos-evm: Remove unneeded regulator property
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Tony Lindgren, linux-omap, Benoit Cousson
The enable-active-high regulator property only makes sense when an
enable GPIO is specified. Remove it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/am43x-epos-evm.dts | 1 -
1 file changed, 1 deletion(-)
Cc: linux-omap@vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
index 795d68af6df9..705048bf17c5 100644
--- a/arch/arm/boot/dts/am43x-epos-evm.dts
+++ b/arch/arm/boot/dts/am43x-epos-evm.dts
@@ -28,7 +28,6 @@
regulator-name = "vmmcsd_fixed";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- enable-active-high;
};
lcd0: display {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 02/37] ARM: dts: am43xx-epos-evm: Remove unneeded regulator property
@ 2015-10-12 21:12 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable-active-high regulator property only makes sense when an
enable GPIO is specified. Remove it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/am43x-epos-evm.dts | 1 -
1 file changed, 1 deletion(-)
Cc: linux-omap at vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
index 795d68af6df9..705048bf17c5 100644
--- a/arch/arm/boot/dts/am43x-epos-evm.dts
+++ b/arch/arm/boot/dts/am43x-epos-evm.dts
@@ -28,7 +28,6 @@
regulator-name = "vmmcsd_fixed";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- enable-active-high;
};
lcd0: display {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 03/37] ARM: mvebu: Armada 388 GP: Remove unneeded regulator property
2015-10-12 21:12 ` Laurent Pinchart
` (2 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
2015-10-13 8:37 ` Thomas Petazzoni
-1 siblings, 1 reply; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable-active-high regulator property only makes sense when an
enable GPIO is specified. Remove it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/armada-388-gp.dts | 2 --
1 file changed, 2 deletions(-)
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts
index fd4f6fd8a2e8..ebf6e8c2c522 100644
--- a/arch/arm/boot/dts/armada-388-gp.dts
+++ b/arch/arm/boot/dts/armada-388-gp.dts
@@ -301,9 +301,7 @@
reg_sata0: pwr-sata0 {
compatible = "regulator-fixed";
regulator-name = "pwr_en_sata0";
- enable-active-high;
regulator-always-on;
-
};
reg_5v_sata0: v5-sata0 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 03/37] ARM: mvebu: Armada 388 GP: Remove unneeded regulator property
2015-10-12 21:12 ` [PATCH 03/37] ARM: mvebu: Armada 388 GP: " Laurent Pinchart
@ 2015-10-13 8:37 ` Thomas Petazzoni
0 siblings, 0 replies; 90+ messages in thread
From: Thomas Petazzoni @ 2015-10-13 8:37 UTC (permalink / raw)
To: linux-arm-kernel
Laurent,
On Tue, 13 Oct 2015 00:12:32 +0300, Laurent Pinchart wrote:
> The enable-active-high regulator property only makes sense when an
> enable GPIO is specified. Remove it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/armada-388-gp.dts | 2 --
> 1 file changed, 2 deletions(-)
Thanks, but this patch is no longer needed, since commit
b5999dcbdb96570c130772ac2055a4d34ec8b3d7 actually added the reference
to the gpio controlling the regulator.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 90+ messages in thread
* [PATCH 04/37] ARM: imx6sx-sdb: Fix typo in regulator enable GPIO property
2015-10-12 21:12 ` Laurent Pinchart
` (3 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The property name should be "gpio", not "gpios". Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx6sx-sdb.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx6sx-sdb.dtsi b/arch/arm/boot/dts/imx6sx-sdb.dtsi
index ac88c3467078..94ac4005d9cd 100644
--- a/arch/arm/boot/dts/imx6sx-sdb.dtsi
+++ b/arch/arm/boot/dts/imx6sx-sdb.dtsi
@@ -114,7 +114,7 @@
regulator-name = "peri_3v3";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpios = <&gpio4 16 GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio4 16 GPIO_ACTIVE_HIGH>;
enable-active-high;
regulator-always-on;
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 05/37] ARM: dts: s5pv210-aquila: Fix typo in regulator enable GPIO property
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-samsung-soc, Kukjin Kim, Krzysztof Kozlowski
The property name should be "gpio", not "gpios". Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/s5pv210-aquila.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-samsung-soc@vger.kernel.org
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
diff --git a/arch/arm/boot/dts/s5pv210-aquila.dts b/arch/arm/boot/dts/s5pv210-aquila.dts
index f00cea7aca2f..aa64faa72970 100644
--- a/arch/arm/boot/dts/s5pv210-aquila.dts
+++ b/arch/arm/boot/dts/s5pv210-aquila.dts
@@ -46,7 +46,7 @@
regulator-name = "V_TF_2.8V";
regulator-min-microvolt = <2800000>;
regulator-max-microvolt = <2800000>;
- gpios = <&mp05 4 0>;
+ gpio = <&mp05 4 0>;
enable-active-high;
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 05/37] ARM: dts: s5pv210-aquila: Fix typo in regulator enable GPIO property
@ 2015-10-12 21:12 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The property name should be "gpio", not "gpios". Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/s5pv210-aquila.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-samsung-soc at vger.kernel.org
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
diff --git a/arch/arm/boot/dts/s5pv210-aquila.dts b/arch/arm/boot/dts/s5pv210-aquila.dts
index f00cea7aca2f..aa64faa72970 100644
--- a/arch/arm/boot/dts/s5pv210-aquila.dts
+++ b/arch/arm/boot/dts/s5pv210-aquila.dts
@@ -46,7 +46,7 @@
regulator-name = "V_TF_2.8V";
regulator-min-microvolt = <2800000>;
regulator-max-microvolt = <2800000>;
- gpios = <&mp05 4 0>;
+ gpio = <&mp05 4 0>;
enable-active-high;
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* Re: [PATCH 05/37] ARM: dts: s5pv210-aquila: Fix typo in regulator enable GPIO property
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-13 0:20 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 90+ messages in thread
From: Krzysztof Kozlowski @ 2015-10-13 0:20 UTC (permalink / raw)
To: Laurent Pinchart, linux-arm-kernel; +Cc: linux-samsung-soc, Kukjin Kim
On 13.10.2015 06:12, Laurent Pinchart wrote:
> The property name should be "gpio", not "gpios". Fix it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/s5pv210-aquila.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 90+ messages in thread
* [PATCH 05/37] ARM: dts: s5pv210-aquila: Fix typo in regulator enable GPIO property
@ 2015-10-13 0:20 ` Krzysztof Kozlowski
0 siblings, 0 replies; 90+ messages in thread
From: Krzysztof Kozlowski @ 2015-10-13 0:20 UTC (permalink / raw)
To: linux-arm-kernel
On 13.10.2015 06:12, Laurent Pinchart wrote:
> The property name should be "gpio", not "gpios". Fix it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/s5pv210-aquila.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Cc: linux-samsung-soc at vger.kernel.org
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 90+ messages in thread
* [PATCH 06/37] ARM: dts: s5pv210-goni: Fix typo in regulator enable GPIO property
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-samsung-soc, Kukjin Kim, Krzysztof Kozlowski
The property name should be "gpio", not "gpios". Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/s5pv210-goni.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Cc: linux-samsung-soc@vger.kernel.org
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
diff --git a/arch/arm/boot/dts/s5pv210-goni.dts b/arch/arm/boot/dts/s5pv210-goni.dts
index a3d4643b202e..3b76eeeb8410 100644
--- a/arch/arm/boot/dts/s5pv210-goni.dts
+++ b/arch/arm/boot/dts/s5pv210-goni.dts
@@ -47,7 +47,7 @@
regulator-min-microvolt = <2800000>;
regulator-max-microvolt = <2800000>;
reg = <0>;
- gpios = <&mp05 4 0>;
+ gpio = <&mp05 4 0>;
enable-active-high;
};
@@ -73,7 +73,7 @@
regulator-min-microvolt = <2800000>;
regulator-max-microvolt = <2800000>;
reg = <3>;
- gpios = <&gpj1 3 0>;
+ gpio = <&gpj1 3 0>;
enable-active-high;
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 06/37] ARM: dts: s5pv210-goni: Fix typo in regulator enable GPIO property
@ 2015-10-12 21:12 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The property name should be "gpio", not "gpios". Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/s5pv210-goni.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Cc: linux-samsung-soc at vger.kernel.org
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
diff --git a/arch/arm/boot/dts/s5pv210-goni.dts b/arch/arm/boot/dts/s5pv210-goni.dts
index a3d4643b202e..3b76eeeb8410 100644
--- a/arch/arm/boot/dts/s5pv210-goni.dts
+++ b/arch/arm/boot/dts/s5pv210-goni.dts
@@ -47,7 +47,7 @@
regulator-min-microvolt = <2800000>;
regulator-max-microvolt = <2800000>;
reg = <0>;
- gpios = <&mp05 4 0>;
+ gpio = <&mp05 4 0>;
enable-active-high;
};
@@ -73,7 +73,7 @@
regulator-min-microvolt = <2800000>;
regulator-max-microvolt = <2800000>;
reg = <3>;
- gpios = <&gpj1 3 0>;
+ gpio = <&gpj1 3 0>;
enable-active-high;
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* Re: [PATCH 06/37] ARM: dts: s5pv210-goni: Fix typo in regulator enable GPIO property
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-13 0:20 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 90+ messages in thread
From: Krzysztof Kozlowski @ 2015-10-13 0:20 UTC (permalink / raw)
To: Laurent Pinchart, linux-arm-kernel; +Cc: linux-samsung-soc, Kukjin Kim
On 13.10.2015 06:12, Laurent Pinchart wrote:
> The property name should be "gpio", not "gpios". Fix it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/s5pv210-goni.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 90+ messages in thread
* [PATCH 06/37] ARM: dts: s5pv210-goni: Fix typo in regulator enable GPIO property
@ 2015-10-13 0:20 ` Krzysztof Kozlowski
0 siblings, 0 replies; 90+ messages in thread
From: Krzysztof Kozlowski @ 2015-10-13 0:20 UTC (permalink / raw)
To: linux-arm-kernel
On 13.10.2015 06:12, Laurent Pinchart wrote:
> The property name should be "gpio", not "gpios". Fix it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/s5pv210-goni.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Cc: linux-samsung-soc at vger.kernel.org
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 90+ messages in thread
* [PATCH 07/37] ARM: dts: omap3-evm: Remove invalid enable-active-low regulator property
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Tony Lindgren, linux-omap, Benoit Cousson
The property isn't part of the regulator-fixed DT bindings and isn't
used by the driver. Remove it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-evm-common.dtsi | 1 -
1 file changed, 1 deletion(-)
Cc: linux-omap@vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap3-evm-common.dtsi b/arch/arm/boot/dts/omap3-evm-common.dtsi
index b2589f96d5f7..c55f256d014b 100644
--- a/arch/arm/boot/dts/omap3-evm-common.dtsi
+++ b/arch/arm/boot/dts/omap3-evm-common.dtsi
@@ -76,7 +76,6 @@
&lcd_3v3 {
gpio = <&gpio5 25 GPIO_ACTIVE_LOW>; /* gpio153 */
- enable-active-low;
};
&lcd0 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 07/37] ARM: dts: omap3-evm: Remove invalid enable-active-low regulator property
@ 2015-10-12 21:12 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The property isn't part of the regulator-fixed DT bindings and isn't
used by the driver. Remove it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-evm-common.dtsi | 1 -
1 file changed, 1 deletion(-)
Cc: linux-omap at vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap3-evm-common.dtsi b/arch/arm/boot/dts/omap3-evm-common.dtsi
index b2589f96d5f7..c55f256d014b 100644
--- a/arch/arm/boot/dts/omap3-evm-common.dtsi
+++ b/arch/arm/boot/dts/omap3-evm-common.dtsi
@@ -76,7 +76,6 @@
&lcd_3v3 {
gpio = <&gpio5 25 GPIO_ACTIVE_LOW>; /* gpio153 */
- enable-active-low;
};
&lcd0 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 08/37] ARM: dts: omap3-sb-t35: Remove invalid enable-active-low regulator property
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Tony Lindgren, linux-omap, Benoit Cousson
The property isn't part of the regulator-fixed DT bindings and isn't
used by the driver. Remove it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-sb-t35.dtsi | 1 -
1 file changed, 1 deletion(-)
Cc: linux-omap@vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap3-sb-t35.dtsi b/arch/arm/boot/dts/omap3-sb-t35.dtsi
index 827f614261f6..b77e25d20e07 100644
--- a/arch/arm/boot/dts/omap3-sb-t35.dtsi
+++ b/arch/arm/boot/dts/omap3-sb-t35.dtsi
@@ -50,7 +50,6 @@
pinctrl-names = "default";
pinctrl-0 = <&sb_t35_audio_amp>;
gpio = <&gpio2 29 GPIO_ACTIVE_LOW>; /* gpio_61 */
- enable-active-low;
regulator-always-on;
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 08/37] ARM: dts: omap3-sb-t35: Remove invalid enable-active-low regulator property
@ 2015-10-12 21:12 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The property isn't part of the regulator-fixed DT bindings and isn't
used by the driver. Remove it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-sb-t35.dtsi | 1 -
1 file changed, 1 deletion(-)
Cc: linux-omap at vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap3-sb-t35.dtsi b/arch/arm/boot/dts/omap3-sb-t35.dtsi
index 827f614261f6..b77e25d20e07 100644
--- a/arch/arm/boot/dts/omap3-sb-t35.dtsi
+++ b/arch/arm/boot/dts/omap3-sb-t35.dtsi
@@ -50,7 +50,6 @@
pinctrl-names = "default";
pinctrl-0 = <&sb_t35_audio_amp>;
gpio = <&gpio2 29 GPIO_ACTIVE_LOW>; /* gpio_61 */
- enable-active-low;
regulator-always-on;
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 09/37] ARM: dts: omap3-tao3530: Remove invalid enable-active-low regulator property
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Tony Lindgren, linux-omap, Benoit Cousson
The property isn't part of the regulator-fixed DT bindings and isn't
used by the driver. Remove it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-tao3530.dtsi | 1 -
1 file changed, 1 deletion(-)
Cc: linux-omap@vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap3-tao3530.dtsi b/arch/arm/boot/dts/omap3-tao3530.dtsi
index 7bd8d9a4f67f..a520b4fdcf20 100644
--- a/arch/arm/boot/dts/omap3-tao3530.dtsi
+++ b/arch/arm/boot/dts/omap3-tao3530.dtsi
@@ -63,7 +63,6 @@
regulator-min-microvolt = <3150000>;
regulator-max-microvolt = <3150000>;
gpio = <&gpio5 29 GPIO_ACTIVE_LOW>; /* gpio_157 */
- enable-active-low;
startup-delay-us = <10000>;
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 09/37] ARM: dts: omap3-tao3530: Remove invalid enable-active-low regulator property
@ 2015-10-12 21:12 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The property isn't part of the regulator-fixed DT bindings and isn't
used by the driver. Remove it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-tao3530.dtsi | 1 -
1 file changed, 1 deletion(-)
Cc: linux-omap at vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap3-tao3530.dtsi b/arch/arm/boot/dts/omap3-tao3530.dtsi
index 7bd8d9a4f67f..a520b4fdcf20 100644
--- a/arch/arm/boot/dts/omap3-tao3530.dtsi
+++ b/arch/arm/boot/dts/omap3-tao3530.dtsi
@@ -63,7 +63,6 @@
regulator-min-microvolt = <3150000>;
regulator-max-microvolt = <3150000>;
gpio = <&gpio5 29 GPIO_ACTIVE_LOW>; /* gpio_157 */
- enable-active-low;
startup-delay-us = <10000>;
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 10/37] ARM: dts: imx6qdl-tx6: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (9 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
While at it remove the enable-active-low property as it isn't part of
the regulator-fixed DT bindings and isn't used by the driver.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
index da08de324e9e..8d472ae3e8ae 100644
--- a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
@@ -108,8 +108,7 @@
regulator-max-microvolt = <3300000>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_flexcan_xcvr>;
- gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
- enable-active-low;
+ gpio = <&gpio4 21 GPIO_ACTIVE_LOW>;
};
reg_lcd0_pwr: regulator at 4 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 11/37] ARM: dts: dove-cm-a510: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (10 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/dove-cm-a510.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
diff --git a/arch/arm/boot/dts/dove-cm-a510.dtsi b/arch/arm/boot/dts/dove-cm-a510.dtsi
index 59b4056b478f..d5d84a61437f 100644
--- a/arch/arm/boot/dts/dove-cm-a510.dtsi
+++ b/arch/arm/boot/dts/dove-cm-a510.dtsi
@@ -118,7 +118,7 @@
regulator-name = "WiFi Power";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio2 7 GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio2 7 GPIO_ACTIVE_LOW>;
};
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 12/37] ARM: dts: dove-sbc-a510: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (11 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
2015-10-12 22:50 ` Jason Cooper
-1 siblings, 1 reply; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/dove-sbc-a510.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
diff --git a/arch/arm/boot/dts/dove-sbc-a510.dts b/arch/arm/boot/dts/dove-sbc-a510.dts
index 288e707dea99..3bc5c96483be 100644
--- a/arch/arm/boot/dts/dove-sbc-a510.dts
+++ b/arch/arm/boot/dts/dove-sbc-a510.dts
@@ -82,7 +82,7 @@
regulator-name = "USB Power";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
- gpio = <&gpio_ext 0 GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio_ext 0 GPIO_ACTIVE_LOW>;
};
mmc_power: regulator at 3 {
@@ -90,7 +90,7 @@
regulator-name = "MMC Power";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio_ext 13 GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio_ext 13 GPIO_ACTIVE_LOW>;
};
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 12/37] ARM: dts: dove-sbc-a510: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` [PATCH 12/37] ARM: dts: dove-sbc-a510: " Laurent Pinchart
@ 2015-10-12 22:50 ` Jason Cooper
2015-10-12 23:10 ` Laurent Pinchart
0 siblings, 1 reply; 90+ messages in thread
From: Jason Cooper @ 2015-10-12 22:50 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 13, 2015 at 12:12:41AM +0300, Laurent Pinchart wrote:
> The enable GPIO is active low, but is flagged as active high in the gpio
> property. As the gpio property flags are currently unused by the driver
> this doesn't cause any issue for now, but will break later if the driver
> starts making use of the flags. Fix it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/dove-sbc-a510.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Gregory Clement <gregory.clement@free-electrons.com>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>
> diff --git a/arch/arm/boot/dts/dove-sbc-a510.dts b/arch/arm/boot/dts/dove-sbc-a510.dts
> index 288e707dea99..3bc5c96483be 100644
> --- a/arch/arm/boot/dts/dove-sbc-a510.dts
> +++ b/arch/arm/boot/dts/dove-sbc-a510.dts
> @@ -82,7 +82,7 @@
> regulator-name = "USB Power";
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
> - gpio = <&gpio_ext 0 GPIO_ACTIVE_HIGH>;
> + gpio = <&gpio_ext 0 GPIO_ACTIVE_LOW>;
I'd feel a lot better about this if the commit log made a strong
reference back to some documentation or other hardware description.
Just because Linux doesn't use it or uses it wrong doesn't necessarily
mean the DT is wrong.
thx,
Jason.
> };
>
> mmc_power: regulator at 3 {
> @@ -90,7 +90,7 @@
> regulator-name = "MMC Power";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> - gpio = <&gpio_ext 13 GPIO_ACTIVE_HIGH>;
> + gpio = <&gpio_ext 13 GPIO_ACTIVE_LOW>;
> };
> };
> };
> --
> 2.4.9
>
^ permalink raw reply [flat|nested] 90+ messages in thread* [PATCH 12/37] ARM: dts: dove-sbc-a510: Fix regulator enable GPIO polarity
2015-10-12 22:50 ` Jason Cooper
@ 2015-10-12 23:10 ` Laurent Pinchart
2015-10-12 23:26 ` Jason Cooper
0 siblings, 1 reply; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 23:10 UTC (permalink / raw)
To: linux-arm-kernel
Hi Jason,
On Monday 12 October 2015 22:50:09 Jason Cooper wrote:
> On Tue, Oct 13, 2015 at 12:12:41AM +0300, Laurent Pinchart wrote:
> > The enable GPIO is active low, but is flagged as active high in the gpio
> > property. As the gpio property flags are currently unused by the driver
> > this doesn't cause any issue for now, but will break later if the driver
> > starts making use of the flags. Fix it.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> >
> > arch/arm/boot/dts/dove-sbc-a510.dts | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Cc: Jason Cooper <jason@lakedaemon.net>
> > Cc: Andrew Lunn <andrew@lunn.ch>
> > Cc: Gregory Clement <gregory.clement@free-electrons.com>
> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> >
> > diff --git a/arch/arm/boot/dts/dove-sbc-a510.dts
> > b/arch/arm/boot/dts/dove-sbc-a510.dts index 288e707dea99..3bc5c96483be
> > 100644
> > --- a/arch/arm/boot/dts/dove-sbc-a510.dts
> > +++ b/arch/arm/boot/dts/dove-sbc-a510.dts
> > @@ -82,7 +82,7 @@
> > regulator-name = "USB Power";
> > regulator-min-microvolt = <5000000>;
> > regulator-max-microvolt = <5000000>;
> > - gpio = <&gpio_ext 0 GPIO_ACTIVE_HIGH>;
> > + gpio = <&gpio_ext 0 GPIO_ACTIVE_LOW>;
>
> I'd feel a lot better about this if the commit log made a strong
> reference back to some documentation or other hardware description.
> Just because Linux doesn't use it or uses it wrong doesn't necessarily
> mean the DT is wrong.
It looks like I might be wrong, see Stephen's reply to patch 37/37. Let's
discuss the issue there.
> > };
> >
> > mmc_power: regulator at 3 {
> > @@ -90,7 +90,7 @@
> > regulator-name = "MMC Power";
> > regulator-min-microvolt = <3300000>;
> > regulator-max-microvolt = <3300000>;
> > - gpio = <&gpio_ext 13 GPIO_ACTIVE_HIGH>;
> > + gpio = <&gpio_ext 13 GPIO_ACTIVE_LOW>;
> > };
> > };
> > };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 90+ messages in thread* [PATCH 12/37] ARM: dts: dove-sbc-a510: Fix regulator enable GPIO polarity
2015-10-12 23:10 ` Laurent Pinchart
@ 2015-10-12 23:26 ` Jason Cooper
0 siblings, 0 replies; 90+ messages in thread
From: Jason Cooper @ 2015-10-12 23:26 UTC (permalink / raw)
To: linux-arm-kernel
Hey Laurent,
On Tue, Oct 13, 2015 at 02:10:10AM +0300, Laurent Pinchart wrote:
> On Monday 12 October 2015 22:50:09 Jason Cooper wrote:
> > On Tue, Oct 13, 2015 at 12:12:41AM +0300, Laurent Pinchart wrote:
> > > The enable GPIO is active low, but is flagged as active high in the gpio
> > > property. As the gpio property flags are currently unused by the driver
> > > this doesn't cause any issue for now, but will break later if the driver
> > > starts making use of the flags. Fix it.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > >
> > > arch/arm/boot/dts/dove-sbc-a510.dts | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > Cc: Jason Cooper <jason@lakedaemon.net>
> > > Cc: Andrew Lunn <andrew@lunn.ch>
> > > Cc: Gregory Clement <gregory.clement@free-electrons.com>
> > > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> > >
> > > diff --git a/arch/arm/boot/dts/dove-sbc-a510.dts
> > > b/arch/arm/boot/dts/dove-sbc-a510.dts index 288e707dea99..3bc5c96483be
> > > 100644
> > > --- a/arch/arm/boot/dts/dove-sbc-a510.dts
> > > +++ b/arch/arm/boot/dts/dove-sbc-a510.dts
> > > @@ -82,7 +82,7 @@
> > > regulator-name = "USB Power";
> > > regulator-min-microvolt = <5000000>;
> > > regulator-max-microvolt = <5000000>;
> > > - gpio = <&gpio_ext 0 GPIO_ACTIVE_HIGH>;
> > > + gpio = <&gpio_ext 0 GPIO_ACTIVE_LOW>;
> >
> > I'd feel a lot better about this if the commit log made a strong
> > reference back to some documentation or other hardware description.
> > Just because Linux doesn't use it or uses it wrong doesn't necessarily
> > mean the DT is wrong.
>
> It looks like I might be wrong, see Stephen's reply to patch 37/37. Let's
> discuss the issue there.
No problem, as long as it's being addressed, I'll keep an eye out for a
v2. I've some email remailer sketchyness resulting in a lack of
subscription to the MLs atm. And I'm not on the 37/37 thread.
thx,
Jason.
^ permalink raw reply [flat|nested] 90+ messages in thread
* [PATCH 13/37] ARM: dts: exynos5250-arndale: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (12 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
2015-10-13 14:11 ` Shawn Guo
-1 siblings, 1 reply; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active high, but is flagged as active low in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/exynos5250-arndale.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index 7e728a1b5559..e8703f0568c9 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -90,7 +90,7 @@
regulator-name = "VDD_33ON_2.8V";
regulator-min-microvolt = <2800000>;
regulator-max-microvolt = <2800000>;
- gpio = <&gpx1 1 GPIO_ACTIVE_LOW>;
+ gpio = <&gpx1 1 GPIO_ACTIVE_HIGH>;
enable-active-high;
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 13/37] ARM: dts: exynos5250-arndale: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` [PATCH 13/37] ARM: dts: exynos5250-arndale: " Laurent Pinchart
@ 2015-10-13 14:11 ` Shawn Guo
0 siblings, 0 replies; 90+ messages in thread
From: Shawn Guo @ 2015-10-13 14:11 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 13, 2015 at 12:12:42AM +0300, Laurent Pinchart wrote:
> The enable GPIO is active high, but is flagged as active low in the gpio
> property. As the gpio property flags are currently unused by the driver
> this doesn't cause any issue for now, but will break later if the driver
> starts making use of the flags. Fix it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/exynos5250-arndale.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
This one should be sent to Samsung folks instead.
Shawn
^ permalink raw reply [flat|nested] 90+ messages in thread
* [PATCH 14/37] ARM: dts: imx23-evk: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (13 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx23-evk.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx23-evk.dts b/arch/arm/boot/dts/imx23-evk.dts
index 57e29977ba06..b6709ff69ebe 100644
--- a/arch/arm/boot/dts/imx23-evk.dts
+++ b/arch/arm/boot/dts/imx23-evk.dts
@@ -10,6 +10,7 @@
*/
/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
#include "imx23.dtsi"
/ {
@@ -136,7 +137,7 @@
regulator-name = "vddio-sd0";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio1 29 0>;
+ gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
};
reg_lcd_3v3: regulator at 1 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 15/37] ARM: dts: imx23-stmp378x_devb: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (14 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx23-stmp378x_devb.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx23-stmp378x_devb.dts b/arch/arm/boot/dts/imx23-stmp378x_devb.dts
index 455169e99d49..928f5556ae7b 100644
--- a/arch/arm/boot/dts/imx23-stmp378x_devb.dts
+++ b/arch/arm/boot/dts/imx23-stmp378x_devb.dts
@@ -10,6 +10,7 @@
*/
/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
#include "imx23.dtsi"
/ {
@@ -75,7 +76,7 @@
regulator-name = "vddio-sd0";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio1 29 0>;
+ gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
};
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 16/37] ARM: dts: imx25-pdk: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (15 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx25-pdk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx25-pdk.dts b/arch/arm/boot/dts/imx25-pdk.dts
index 9351296356dc..71d358f6c707 100644
--- a/arch/arm/boot/dts/imx25-pdk.dts
+++ b/arch/arm/boot/dts/imx25-pdk.dts
@@ -59,7 +59,7 @@
regulator-name = "can-3v3";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio4 6 0>;
+ gpio = <&gpio4 6 GPIO_ACTIVE_LOW>;
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 17/37] ARM: dts: imx28-cfa10036: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (16 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx28-cfa10036.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx28-cfa10036.dts b/arch/arm/boot/dts/imx28-cfa10036.dts
index 570aa339a05e..b053057d50fa 100644
--- a/arch/arm/boot/dts/imx28-cfa10036.dts
+++ b/arch/arm/boot/dts/imx28-cfa10036.dts
@@ -139,6 +139,6 @@
regulator-name = "vddio-sd0";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio3 28 0>;
+ gpio = <&gpio3 28 GPIO_ACTIVE_LOW>;
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 18/37] ARM: dts: imx28-evk: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (17 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx28-evk.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx28-evk.dts b/arch/arm/boot/dts/imx28-evk.dts
index 279249b8c3f3..17598d3bb408 100644
--- a/arch/arm/boot/dts/imx28-evk.dts
+++ b/arch/arm/boot/dts/imx28-evk.dts
@@ -295,7 +295,7 @@
regulator-name = "vddio-sd0";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio3 28 0>;
+ gpio = <&gpio3 28 GPIO_ACTIVE_LOW>;
};
reg_fec_3v3: regulator at 2 {
@@ -304,7 +304,7 @@
regulator-name = "fec-3v3";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio2 15 0>;
+ gpio = <&gpio2 15 GPIO_ACTIVE_LOW>;
};
reg_usb0_vbus: regulator at 3 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 19/37] ARM: dts: imx28-m28cu3: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (18 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx28-m28cu3.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx28-m28cu3.dts b/arch/arm/boot/dts/imx28-m28cu3.dts
index 2df63bee6f4e..026a17e05dc9 100644
--- a/arch/arm/boot/dts/imx28-m28cu3.dts
+++ b/arch/arm/boot/dts/imx28-m28cu3.dts
@@ -246,7 +246,7 @@
regulator-name = "vddio-sd0";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio3 29 0>;
+ gpio = <&gpio3 29 GPIO_ACTIVE_LOW>;
};
reg_vddio_sd1: regulator at 2 {
@@ -255,7 +255,7 @@
regulator-name = "vddio-sd1";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio2 19 0>;
+ gpio = <&gpio2 19 GPIO_ACTIVE_LOW>;
};
reg_usb1_vbus: regulator at 3 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 20/37] ARM: dts: imx28-m28evk: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (19 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx28-m28evk.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx28-m28evk.dts b/arch/arm/boot/dts/imx28-m28evk.dts
index e35cc6ba3ca6..c34cc49cfe42 100644
--- a/arch/arm/boot/dts/imx28-m28evk.dts
+++ b/arch/arm/boot/dts/imx28-m28evk.dts
@@ -243,7 +243,7 @@
regulator-name = "vddio-sd0";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio3 28 0>;
+ gpio = <&gpio3 28 GPIO_ACTIVE_LOW>;
};
reg_usb0_vbus: regulator at 2 {
@@ -252,7 +252,7 @@
regulator-name = "usb0_vbus";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
- gpio = <&gpio3 12 0>;
+ gpio = <&gpio3 12 GPIO_ACTIVE_LOW>;
};
reg_usb1_vbus: regulator at 3 {
@@ -261,7 +261,7 @@
regulator-name = "usb1_vbus";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
- gpio = <&gpio3 13 0>;
+ gpio = <&gpio3 13 GPIO_ACTIVE_LOW>;
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 21/37] ARM: dts: imx28-sps1: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (20 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx28-sps1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx28-sps1.dts b/arch/arm/boot/dts/imx28-sps1.dts
index 0ce3cb8e7914..d68886646941 100644
--- a/arch/arm/boot/dts/imx28-sps1.dts
+++ b/arch/arm/boot/dts/imx28-sps1.dts
@@ -136,7 +136,7 @@
regulator-name = "usb0_vbus";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
- gpio = <&gpio3 9 0>;
+ gpio = <&gpio3 9 GPIO_ACTIVE_LOW>;
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 22/37] ARM: dts: imx28-tx28: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (21 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx28-tx28.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index a5b27c85a91c..480c5ecaea2d 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -93,7 +93,7 @@
regulator-name = "CAN XCVR";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio1 0 GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio1 0 GPIO_ACTIVE_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&tx28_flexcan_xcvr_pins>;
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 23/37] ARM: dts: imx53-m53evk: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (22 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx53-m53evk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx53-m53evk.dts b/arch/arm/boot/dts/imx53-m53evk.dts
index 53f40885c530..e2145338580f 100644
--- a/arch/arm/boot/dts/imx53-m53evk.dts
+++ b/arch/arm/boot/dts/imx53-m53evk.dts
@@ -82,7 +82,7 @@
regulator-name = "vbus";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
- gpio = <&gpio1 2 0>;
+ gpio = <&gpio1 2 GPIO_ACTIVE_LOW>;
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 24/37] ARM: dts: imx53-mba53: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (23 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx53-mba53.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx53-mba53.dts b/arch/arm/boot/dts/imx53-mba53.dts
index 2e44d2aba14e..8eb4c58b2f24 100644
--- a/arch/arm/boot/dts/imx53-mba53.dts
+++ b/arch/arm/boot/dts/imx53-mba53.dts
@@ -53,7 +53,7 @@
compatible = "regulator-fixed";
reg = <0>;
regulator-name = "lcd-supply";
- gpio = <&gpio2 5 0>;
+ gpio = <&gpio2 5 GPIO_ACTIVE_LOW>;
startup-delay-us = <5000>;
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 25/37] ARM: dts: imx53-tx53: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (24 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx53-tx53.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
index d3e50b22064f..62a324961ec8 100644
--- a/arch/arm/boot/dts/imx53-tx53.dtsi
+++ b/arch/arm/boot/dts/imx53-tx53.dtsi
@@ -95,7 +95,7 @@
regulator-max-microvolt = <3300000>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_can_xcvr>;
- gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio4 21 GPIO_ACTIVE_LOW>;
};
reg_usbh1_vbus: regulator at 3 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 26/37] ARM: dts: imx6q-dmo-edmqmx6: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (25 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
diff --git a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
index 4fa254347798..3272d8048ace 100644
--- a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
+++ b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
@@ -53,7 +53,7 @@
regulator-name = "usb_otg_switch";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
- gpio = <&gpio7 12 0>;
+ gpio = <&gpio7 12 GPIO_ACTIVE_LOW>;
regulator-boot-on;
regulator-always-on;
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 27/37] ARM: dts: kirkwood-blackarmor-nas220: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (26 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIOs are active high, but are flagged as active low in the
gpio properties. As the gpio property flags are currently unused by the
driver this doesn't cause any issue for now, but will break later if the
driver starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/kirkwood-blackarmor-nas220.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
diff --git a/arch/arm/boot/dts/kirkwood-blackarmor-nas220.dts b/arch/arm/boot/dts/kirkwood-blackarmor-nas220.dts
index fa02a9aff05e..8d155295d528 100644
--- a/arch/arm/boot/dts/kirkwood-blackarmor-nas220.dts
+++ b/arch/arm/boot/dts/kirkwood-blackarmor-nas220.dts
@@ -75,7 +75,7 @@
enable-active-high;
regulator-always-on;
regulator-boot-on;
- gpio = <&gpio0 24 GPIO_ACTIVE_LOW>;
+ gpio = <&gpio0 24 GPIO_ACTIVE_HIGH>;
};
sata1_power: regulator at 2 {
@@ -87,7 +87,7 @@
enable-active-high;
regulator-always-on;
regulator-boot-on;
- gpio = <&gpio0 28 GPIO_ACTIVE_LOW>;
+ gpio = <&gpio0 28 GPIO_ACTIVE_HIGH>;
};
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 28/37] ARM: dts: omap4-duovero: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Tony Lindgren, linux-omap, Benoit Cousson
The enable GPIO is active high, but is flagged as active low in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap4-duovero.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-omap@vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap4-duovero.dtsi b/arch/arm/boot/dts/omap4-duovero.dtsi
index f2a94fa62552..23c1a74f91ea 100644
--- a/arch/arm/boot/dts/omap4-duovero.dtsi
+++ b/arch/arm/boot/dts/omap4-duovero.dtsi
@@ -56,7 +56,7 @@
regulator-name = "w2cbw0015";
regulator-min-microvolt = <3000000>;
regulator-max-microvolt = <3000000>;
- gpio = <&gpio2 11 GPIO_ACTIVE_LOW>; /* gpio_43 */
+ gpio = <&gpio2 11 GPIO_ACTIVE_HIGH>; /* gpio_43 */
startup-delay-us = <70000>;
enable-active-high;
regulator-boot-on;
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 28/37] ARM: dts: omap4-duovero: Fix regulator enable GPIO polarity
@ 2015-10-12 21:12 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active high, but is flagged as active low in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap4-duovero.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-omap at vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap4-duovero.dtsi b/arch/arm/boot/dts/omap4-duovero.dtsi
index f2a94fa62552..23c1a74f91ea 100644
--- a/arch/arm/boot/dts/omap4-duovero.dtsi
+++ b/arch/arm/boot/dts/omap4-duovero.dtsi
@@ -56,7 +56,7 @@
regulator-name = "w2cbw0015";
regulator-min-microvolt = <3000000>;
regulator-max-microvolt = <3000000>;
- gpio = <&gpio2 11 GPIO_ACTIVE_LOW>; /* gpio_43 */
+ gpio = <&gpio2 11 GPIO_ACTIVE_HIGH>; /* gpio_43 */
startup-delay-us = <70000>;
enable-active-high;
regulator-boot-on;
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 29/37] ARM: dts: kirkwood-nsa3x0-common: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
` (28 preceding siblings ...)
(?)
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
diff --git a/arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi b/arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi
index 2075a2e828f1..c4b17f396e1e 100644
--- a/arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi
+++ b/arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi
@@ -110,7 +110,7 @@
regulator-max-microvolt = <5000000>;
regulator-always-on;
regulator-boot-on;
- gpio = <&gpio0 21 GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio0 21 GPIO_ACTIVE_LOW>;
};
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 30/37] ARM: dts: omap3-beagle-xm: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:12 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Tony Lindgren, linux-omap, Benoit Cousson
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-beagle-xm.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-omap@vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
index 7c4dca122a91..f44f17673061 100644
--- a/arch/arm/boot/dts/omap3-beagle-xm.dts
+++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
@@ -80,7 +80,7 @@
regulator-name = "hsusb2_vbus";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&twl_gpio 18 0>; /* GPIO LEDA */
+ gpio = <&twl_gpio 18 GPIO_ACTIVE_LOW>; /* GPIO LEDA */
startup-delay-us = <70000>;
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 30/37] ARM: dts: omap3-beagle-xm: Fix regulator enable GPIO polarity
@ 2015-10-12 21:12 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:12 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-beagle-xm.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-omap at vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
index 7c4dca122a91..f44f17673061 100644
--- a/arch/arm/boot/dts/omap3-beagle-xm.dts
+++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
@@ -80,7 +80,7 @@
regulator-name = "hsusb2_vbus";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&twl_gpio 18 0>; /* GPIO LEDA */
+ gpio = <&twl_gpio 18 GPIO_ACTIVE_LOW>; /* GPIO LEDA */
startup-delay-us = <70000>;
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 31/37] ARM: dts: omap3-beagle: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:13 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:13 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Tony Lindgren, linux-omap, Benoit Cousson
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-beagle.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-omap@vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts
index a5474113cd50..0849035643fc 100644
--- a/arch/arm/boot/dts/omap3-beagle.dts
+++ b/arch/arm/boot/dts/omap3-beagle.dts
@@ -55,7 +55,7 @@
regulator-name = "hsusb2_vbus";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&twl_gpio 18 0>; /* GPIO LEDA */
+ gpio = <&twl_gpio 18 GPIO_ACTIVE_LOW>; /* GPIO LEDA */
startup-delay-us = <70000>;
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 31/37] ARM: dts: omap3-beagle: Fix regulator enable GPIO polarity
@ 2015-10-12 21:13 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:13 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-beagle.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-omap at vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts
index a5474113cd50..0849035643fc 100644
--- a/arch/arm/boot/dts/omap3-beagle.dts
+++ b/arch/arm/boot/dts/omap3-beagle.dts
@@ -55,7 +55,7 @@
regulator-name = "hsusb2_vbus";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&twl_gpio 18 0>; /* GPIO LEDA */
+ gpio = <&twl_gpio 18 GPIO_ACTIVE_LOW>; /* GPIO LEDA */
startup-delay-us = <70000>;
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 32/37] ARM: dts: omap3-overo-base: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:13 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:13 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Tony Lindgren, linux-omap, Benoit Cousson
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-overo-base.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Cc: linux-omap@vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap3-overo-base.dtsi b/arch/arm/boot/dts/omap3-overo-base.dtsi
index 18e1649681c1..1fa59d0e1e8a 100644
--- a/arch/arm/boot/dts/omap3-overo-base.dtsi
+++ b/arch/arm/boot/dts/omap3-overo-base.dtsi
@@ -65,7 +65,7 @@
regulator-name = "regulator-w3cbw003c-wifi-nreset";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio1 16 GPIO_ACTIVE_HIGH>; /* gpio_16: WiFi nReset */
+ gpio = <&gpio1 16 GPIO_ACTIVE_LOW>; /* gpio_16: WiFi nReset */
startup-delay-us = <10000>;
};
@@ -75,7 +75,7 @@
regulator-name = "regulator-w3cbw003c-bt-nreset";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio6 4 GPIO_ACTIVE_HIGH>; /* gpio_164: BT nReset */
+ gpio = <&gpio6 4 GPIO_ACTIVE_LOW>; /* gpio_164: BT nReset */
startup-delay-us = <10000>;
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 32/37] ARM: dts: omap3-overo-base: Fix regulator enable GPIO polarity
@ 2015-10-12 21:13 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:13 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-overo-base.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Cc: linux-omap at vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap3-overo-base.dtsi b/arch/arm/boot/dts/omap3-overo-base.dtsi
index 18e1649681c1..1fa59d0e1e8a 100644
--- a/arch/arm/boot/dts/omap3-overo-base.dtsi
+++ b/arch/arm/boot/dts/omap3-overo-base.dtsi
@@ -65,7 +65,7 @@
regulator-name = "regulator-w3cbw003c-wifi-nreset";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio1 16 GPIO_ACTIVE_HIGH>; /* gpio_16: WiFi nReset */
+ gpio = <&gpio1 16 GPIO_ACTIVE_LOW>; /* gpio_16: WiFi nReset */
startup-delay-us = <10000>;
};
@@ -75,7 +75,7 @@
regulator-name = "regulator-w3cbw003c-bt-nreset";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio6 4 GPIO_ACTIVE_HIGH>; /* gpio_164: BT nReset */
+ gpio = <&gpio6 4 GPIO_ACTIVE_LOW>; /* gpio_164: BT nReset */
startup-delay-us = <10000>;
};
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 33/37] ARM: dts: omap3-tao3530: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:13 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:13 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Tony Lindgren, linux-omap, Benoit Cousson
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-tao3530.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-omap@vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap3-tao3530.dtsi b/arch/arm/boot/dts/omap3-tao3530.dtsi
index a520b4fdcf20..68f75be5d99a 100644
--- a/arch/arm/boot/dts/omap3-tao3530.dtsi
+++ b/arch/arm/boot/dts/omap3-tao3530.dtsi
@@ -37,7 +37,7 @@
regulator-name = "hsusb2_vbus";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&twl_gpio 18 0>; /* GPIO LEDA */
+ gpio = <&twl_gpio 18 GPIO_ACTIVE_LOW>; /* GPIO LEDA */
startup-delay-us = <70000>;
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 33/37] ARM: dts: omap3-tao3530: Fix regulator enable GPIO polarity
@ 2015-10-12 21:13 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:13 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-tao3530.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-omap at vger.kernel.org
Cc: Benoit Cousson <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/boot/dts/omap3-tao3530.dtsi b/arch/arm/boot/dts/omap3-tao3530.dtsi
index a520b4fdcf20..68f75be5d99a 100644
--- a/arch/arm/boot/dts/omap3-tao3530.dtsi
+++ b/arch/arm/boot/dts/omap3-tao3530.dtsi
@@ -37,7 +37,7 @@
regulator-name = "hsusb2_vbus";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&twl_gpio 18 0>; /* GPIO LEDA */
+ gpio = <&twl_gpio 18 GPIO_ACTIVE_LOW>; /* GPIO LEDA */
startup-delay-us = <70000>;
};
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
[parent not found: <1444684386-17094-1-git-send-email-laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>]
* [PATCH 34/37] ARM: dts: tegra20-harmony: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:13 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:13 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA, Stephen Warren,
Thierry Reding, Alexandre Courbot
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
---
arch/arm/boot/dts/tegra20-harmony.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
diff --git a/arch/arm/boot/dts/tegra20-harmony.dts b/arch/arm/boot/dts/tegra20-harmony.dts
index b926a07b9443..d18801fe6730 100644
--- a/arch/arm/boot/dts/tegra20-harmony.dts
+++ b/arch/arm/boot/dts/tegra20-harmony.dts
@@ -688,7 +688,7 @@
regulator-name = "vdd_1v5";
regulator-min-microvolt = <1500000>;
regulator-max-microvolt = <1500000>;
- gpio = <&pmic 0 GPIO_ACTIVE_HIGH>;
+ gpio = <&pmic 0 GPIO_ACTIVE_LOW>;
};
regulator@2 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 34/37] ARM: dts: tegra20-harmony: Fix regulator enable GPIO polarity
@ 2015-10-12 21:13 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:13 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/tegra20-harmony.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-tegra at vger.kernel.org
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
diff --git a/arch/arm/boot/dts/tegra20-harmony.dts b/arch/arm/boot/dts/tegra20-harmony.dts
index b926a07b9443..d18801fe6730 100644
--- a/arch/arm/boot/dts/tegra20-harmony.dts
+++ b/arch/arm/boot/dts/tegra20-harmony.dts
@@ -688,7 +688,7 @@
regulator-name = "vdd_1v5";
regulator-min-microvolt = <1500000>;
regulator-max-microvolt = <1500000>;
- gpio = <&pmic 0 GPIO_ACTIVE_HIGH>;
+ gpio = <&pmic 0 GPIO_ACTIVE_LOW>;
};
regulator at 2 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 35/37] ARM: dts: tegra20-iris-512: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:13 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:13 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA, Stephen Warren,
Thierry Reding, Alexandre Courbot
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
---
arch/arm/boot/dts/tegra20-iris-512.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
diff --git a/arch/arm/boot/dts/tegra20-iris-512.dts b/arch/arm/boot/dts/tegra20-iris-512.dts
index 1dd7d7bfdfcc..9b04a367575c 100644
--- a/arch/arm/boot/dts/tegra20-iris-512.dts
+++ b/arch/arm/boot/dts/tegra20-iris-512.dts
@@ -85,7 +85,7 @@
regulator-max-microvolt = <5000000>;
regulator-boot-on;
regulator-always-on;
- gpio = <&gpio TEGRA_GPIO(W, 2) GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio TEGRA_GPIO(W, 2) GPIO_ACTIVE_LOW>;
};
vcc_sd_reg: regulator@1 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 35/37] ARM: dts: tegra20-iris-512: Fix regulator enable GPIO polarity
@ 2015-10-12 21:13 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:13 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/tegra20-iris-512.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-tegra at vger.kernel.org
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
diff --git a/arch/arm/boot/dts/tegra20-iris-512.dts b/arch/arm/boot/dts/tegra20-iris-512.dts
index 1dd7d7bfdfcc..9b04a367575c 100644
--- a/arch/arm/boot/dts/tegra20-iris-512.dts
+++ b/arch/arm/boot/dts/tegra20-iris-512.dts
@@ -85,7 +85,7 @@
regulator-max-microvolt = <5000000>;
regulator-boot-on;
regulator-always-on;
- gpio = <&gpio TEGRA_GPIO(W, 2) GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio TEGRA_GPIO(W, 2) GPIO_ACTIVE_LOW>;
};
vcc_sd_reg: regulator at 1 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 36/37] ARM: dts: tegra20-seaboard: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:13 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:13 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA, Stephen Warren,
Thierry Reding, Alexandre Courbot
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
---
arch/arm/boot/dts/tegra20-seaboard.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index aea8994b35f2..1d790cd59c21 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -850,7 +850,7 @@
regulator-name = "vdd_1v5";
regulator-min-microvolt = <1500000>;
regulator-max-microvolt = <1500000>;
- gpio = <&pmic 0 GPIO_ACTIVE_HIGH>;
+ gpio = <&pmic 0 GPIO_ACTIVE_LOW>;
};
regulator@2 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 36/37] ARM: dts: tegra20-seaboard: Fix regulator enable GPIO polarity
@ 2015-10-12 21:13 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:13 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/tegra20-seaboard.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-tegra at vger.kernel.org
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index aea8994b35f2..1d790cd59c21 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -850,7 +850,7 @@
regulator-name = "vdd_1v5";
regulator-min-microvolt = <1500000>;
regulator-max-microvolt = <1500000>;
- gpio = <&pmic 0 GPIO_ACTIVE_HIGH>;
+ gpio = <&pmic 0 GPIO_ACTIVE_LOW>;
};
regulator at 2 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread
* [PATCH 37/37] ARM: dts: tegra20-ventana: Fix regulator enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
@ 2015-10-12 21:13 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:13 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA, Stephen Warren,
Thierry Reding, Alexandre Courbot
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
---
arch/arm/boot/dts/tegra20-ventana.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
diff --git a/arch/arm/boot/dts/tegra20-ventana.dts b/arch/arm/boot/dts/tegra20-ventana.dts
index 04c58e9ca490..ba1fc1487c69 100644
--- a/arch/arm/boot/dts/tegra20-ventana.dts
+++ b/arch/arm/boot/dts/tegra20-ventana.dts
@@ -635,7 +635,7 @@
regulator-name = "vdd_1v5";
regulator-min-microvolt = <1500000>;
regulator-max-microvolt = <1500000>;
- gpio = <&pmic 0 GPIO_ACTIVE_HIGH>;
+ gpio = <&pmic 0 GPIO_ACTIVE_LOW>;
};
regulator@2 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread* [PATCH 37/37] ARM: dts: tegra20-ventana: Fix regulator enable GPIO polarity
@ 2015-10-12 21:13 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 21:13 UTC (permalink / raw)
To: linux-arm-kernel
The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/tegra20-ventana.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cc: linux-tegra at vger.kernel.org
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
diff --git a/arch/arm/boot/dts/tegra20-ventana.dts b/arch/arm/boot/dts/tegra20-ventana.dts
index 04c58e9ca490..ba1fc1487c69 100644
--- a/arch/arm/boot/dts/tegra20-ventana.dts
+++ b/arch/arm/boot/dts/tegra20-ventana.dts
@@ -635,7 +635,7 @@
regulator-name = "vdd_1v5";
regulator-min-microvolt = <1500000>;
regulator-max-microvolt = <1500000>;
- gpio = <&pmic 0 GPIO_ACTIVE_HIGH>;
+ gpio = <&pmic 0 GPIO_ACTIVE_LOW>;
};
regulator at 2 {
--
2.4.9
^ permalink raw reply related [flat|nested] 90+ messages in thread[parent not found: <1444684386-17094-38-git-send-email-laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>]
* Re: [PATCH 37/37] ARM: dts: tegra20-ventana: Fix regulator enable GPIO polarity
2015-10-12 21:13 ` Laurent Pinchart
@ 2015-10-12 21:34 ` Stephen Warren
-1 siblings, 0 replies; 90+ messages in thread
From: Stephen Warren @ 2015-10-12 21:34 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Thierry Reding,
Alexandre Courbot
On 10/12/2015 03:13 PM, Laurent Pinchart wrote:
> The enable GPIO is active low,
It'd be good to mention a justification for that statement in the
patches, since the cover letter isn't going to be checked in.
> but is flagged as active high in the gpio
> property. As the gpio property flags are currently unused by the driver
> this doesn't cause any issue for now, but will break later if the driver
> starts making use of the flags. Fix it.
IIRC the history here was that for some bizarre reason not all GPIO
bindings contained an active-high/low flag and there was resistance to
extending them in a backwards compatible way. So the regulator binding
needed the separate property to represent this. For bindings that did
have the flag, we had to set the GPIO flag to active-high, so that if
anything started honoring the GPIO flags (e.g. I thikn the gpiod API
does today, but the legacy GPIO API doesn't), we wouldn't apply both
"active low indicators", and end up driving an active-high signal, and
breaking things.
So while this change is logically correct when read in isolation (and
for Harmony, Seaboard, and Ventana I verified that these regulators do
use an active-low GPIO), I worry that making it makes mistakes likely
later. How would we mitigate that?
^ permalink raw reply [flat|nested] 90+ messages in thread
* [PATCH 37/37] ARM: dts: tegra20-ventana: Fix regulator enable GPIO polarity
@ 2015-10-12 21:34 ` Stephen Warren
0 siblings, 0 replies; 90+ messages in thread
From: Stephen Warren @ 2015-10-12 21:34 UTC (permalink / raw)
To: linux-arm-kernel
On 10/12/2015 03:13 PM, Laurent Pinchart wrote:
> The enable GPIO is active low,
It'd be good to mention a justification for that statement in the
patches, since the cover letter isn't going to be checked in.
> but is flagged as active high in the gpio
> property. As the gpio property flags are currently unused by the driver
> this doesn't cause any issue for now, but will break later if the driver
> starts making use of the flags. Fix it.
IIRC the history here was that for some bizarre reason not all GPIO
bindings contained an active-high/low flag and there was resistance to
extending them in a backwards compatible way. So the regulator binding
needed the separate property to represent this. For bindings that did
have the flag, we had to set the GPIO flag to active-high, so that if
anything started honoring the GPIO flags (e.g. I thikn the gpiod API
does today, but the legacy GPIO API doesn't), we wouldn't apply both
"active low indicators", and end up driving an active-high signal, and
breaking things.
So while this change is logically correct when read in isolation (and
for Harmony, Seaboard, and Ventana I verified that these regulators do
use an active-low GPIO), I worry that making it makes mistakes likely
later. How would we mitigate that?
^ permalink raw reply [flat|nested] 90+ messages in thread
[parent not found: <561C2773.5090408-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]
* Re: [PATCH 37/37] ARM: dts: tegra20-ventana: Fix regulator enable GPIO polarity
2015-10-12 21:34 ` Stephen Warren
@ 2015-10-12 22:24 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 22:24 UTC (permalink / raw)
To: Stephen Warren
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Thierry Reding,
Alexandre Courbot
Hi Stephen,
On Monday 12 October 2015 15:34:43 Stephen Warren wrote:
> On 10/12/2015 03:13 PM, Laurent Pinchart wrote:
> > The enable GPIO is active low,
>
> It'd be good to mention a justification for that statement in the
> patches, since the cover letter isn't going to be checked in.
>
> > but is flagged as active high in the gpio
> > property. As the gpio property flags are currently unused by the driver
> > this doesn't cause any issue for now, but will break later if the driver
> > starts making use of the flags. Fix it.
>
> IIRC the history here was that for some bizarre reason not all GPIO
> bindings contained an active-high/low flag and there was resistance to
> extending them in a backwards compatible way. So the regulator binding
> needed the separate property to represent this. For bindings that did
> have the flag, we had to set the GPIO flag to active-high, so that if
> anything started honoring the GPIO flags (e.g. I thikn the gpiod API
> does today, but the legacy GPIO API doesn't), we wouldn't apply both
> "active low indicators", and end up driving an active-high signal, and
> breaking things.
>
> So while this change is logically correct when read in isolation (and
> for Harmony, Seaboard, and Ventana I verified that these regulators do
> use an active-low GPIO), I worry that making it makes mistakes likely
> later. How would we mitigate that?
That's a very good point. Is the resistance to move to the standard GPIO
active low/high flags still present, or is it now only history ? In other
words, could we aim for using GPIO flags as the primary method to specify
polarities, and fall back to the custom properties for backward compatibility
(and possibly for GPIO controllers that don't support the flags) ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 90+ messages in thread
* [PATCH 37/37] ARM: dts: tegra20-ventana: Fix regulator enable GPIO polarity
@ 2015-10-12 22:24 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 22:24 UTC (permalink / raw)
To: linux-arm-kernel
Hi Stephen,
On Monday 12 October 2015 15:34:43 Stephen Warren wrote:
> On 10/12/2015 03:13 PM, Laurent Pinchart wrote:
> > The enable GPIO is active low,
>
> It'd be good to mention a justification for that statement in the
> patches, since the cover letter isn't going to be checked in.
>
> > but is flagged as active high in the gpio
> > property. As the gpio property flags are currently unused by the driver
> > this doesn't cause any issue for now, but will break later if the driver
> > starts making use of the flags. Fix it.
>
> IIRC the history here was that for some bizarre reason not all GPIO
> bindings contained an active-high/low flag and there was resistance to
> extending them in a backwards compatible way. So the regulator binding
> needed the separate property to represent this. For bindings that did
> have the flag, we had to set the GPIO flag to active-high, so that if
> anything started honoring the GPIO flags (e.g. I thikn the gpiod API
> does today, but the legacy GPIO API doesn't), we wouldn't apply both
> "active low indicators", and end up driving an active-high signal, and
> breaking things.
>
> So while this change is logically correct when read in isolation (and
> for Harmony, Seaboard, and Ventana I verified that these regulators do
> use an active-low GPIO), I worry that making it makes mistakes likely
> later. How would we mitigate that?
That's a very good point. Is the resistance to move to the standard GPIO
active low/high flags still present, or is it now only history ? In other
words, could we aim for using GPIO flags as the primary method to specify
polarities, and fall back to the custom properties for backward compatibility
(and possibly for GPIO controllers that don't support the flags) ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 90+ messages in thread
* Re: [PATCH 37/37] ARM: dts: tegra20-ventana: Fix regulator enable GPIO polarity
2015-10-12 22:24 ` Laurent Pinchart
@ 2015-10-13 16:35 ` Stephen Warren
-1 siblings, 0 replies; 90+ messages in thread
From: Stephen Warren @ 2015-10-13 16:35 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Thierry Reding,
Alexandre Courbot
On 10/12/2015 04:24 PM, Laurent Pinchart wrote:
> Hi Stephen,
>
> On Monday 12 October 2015 15:34:43 Stephen Warren wrote:
>> On 10/12/2015 03:13 PM, Laurent Pinchart wrote:
>>> The enable GPIO is active low,
>>
>> It'd be good to mention a justification for that statement in the
>> patches, since the cover letter isn't going to be checked in.
>>
>>> but is flagged as active high in the gpio
>>> property. As the gpio property flags are currently unused by the driver
>>> this doesn't cause any issue for now, but will break later if the driver
>>> starts making use of the flags. Fix it.
>>
>> IIRC the history here was that for some bizarre reason not all GPIO
>> bindings contained an active-high/low flag and there was resistance to
>> extending them in a backwards compatible way. So the regulator binding
>> needed the separate property to represent this. For bindings that did
>> have the flag, we had to set the GPIO flag to active-high, so that if
>> anything started honoring the GPIO flags (e.g. I thikn the gpiod API
>> does today, but the legacy GPIO API doesn't), we wouldn't apply both
>> "active low indicators", and end up driving an active-high signal, and
>> breaking things.
>>
>> So while this change is logically correct when read in isolation (and
>> for Harmony, Seaboard, and Ventana I verified that these regulators do
>> use an active-low GPIO), I worry that making it makes mistakes likely
>> later. How would we mitigate that?
>
> That's a very good point. Is the resistance to move to the standard GPIO
> active low/high flags still present, or is it now only history ?
This was a few years back, so I don't remember the details; it might
have been as simple as "some bindings don't already have GPIO flags, and
I'd rather get GPIO regulators implemented first before thinking about
fixing that" or it could have been "some bindings don't already have
GPIO flags, and there's ${some reason} why it's not possible to solve
that in a backwards-compatible fashion" (recalling that DT bindings must
evolve in a backwards-compatible fashion since they're an ABI).
Unfortunately, you'd have to read through the mailing list posts related
to the patches that defined the GPIO regulator bindings or added the
nodes to DT.
> In other
> words, could we aim for using GPIO flags as the primary method to specify
> polarities, and fall back to the custom properties for backward compatibility
> (and possibly for GPIO controllers that don't support the flags) ?
I don't think we can switch to using GPIO flags, without changing the
compatible values for the relevant DT nodes.
For one, we'd need some way of actively marking the nodes to say whether
they are written to expect that the GPIO flags or the other properties
be used. It's not possible in all cases to determine this automatically.
For example, if enable-active-high it's fairly clear we should honor
this flag, yet if it's missing does that mean the GPIO is active-low or
simply that the node was written to expect that the GPIO flags be used
instead?
Also, old DTs must work with new kernels (and preferably also, new DTs
must work with old kernels). If the GPIO flags are wrong in current DTs,
then we can't use them. Of course, there's an argument that the
backwards-compatibility constraint doesn't apply to buggy DTs, just to
correctly written DTs. However, if we deliberately chose to make all
regulator GPIO flags ACTIVE_HIGH, then the current DTs aren't buggy.
^ permalink raw reply [flat|nested] 90+ messages in thread* [PATCH 37/37] ARM: dts: tegra20-ventana: Fix regulator enable GPIO polarity
@ 2015-10-13 16:35 ` Stephen Warren
0 siblings, 0 replies; 90+ messages in thread
From: Stephen Warren @ 2015-10-13 16:35 UTC (permalink / raw)
To: linux-arm-kernel
On 10/12/2015 04:24 PM, Laurent Pinchart wrote:
> Hi Stephen,
>
> On Monday 12 October 2015 15:34:43 Stephen Warren wrote:
>> On 10/12/2015 03:13 PM, Laurent Pinchart wrote:
>>> The enable GPIO is active low,
>>
>> It'd be good to mention a justification for that statement in the
>> patches, since the cover letter isn't going to be checked in.
>>
>>> but is flagged as active high in the gpio
>>> property. As the gpio property flags are currently unused by the driver
>>> this doesn't cause any issue for now, but will break later if the driver
>>> starts making use of the flags. Fix it.
>>
>> IIRC the history here was that for some bizarre reason not all GPIO
>> bindings contained an active-high/low flag and there was resistance to
>> extending them in a backwards compatible way. So the regulator binding
>> needed the separate property to represent this. For bindings that did
>> have the flag, we had to set the GPIO flag to active-high, so that if
>> anything started honoring the GPIO flags (e.g. I thikn the gpiod API
>> does today, but the legacy GPIO API doesn't), we wouldn't apply both
>> "active low indicators", and end up driving an active-high signal, and
>> breaking things.
>>
>> So while this change is logically correct when read in isolation (and
>> for Harmony, Seaboard, and Ventana I verified that these regulators do
>> use an active-low GPIO), I worry that making it makes mistakes likely
>> later. How would we mitigate that?
>
> That's a very good point. Is the resistance to move to the standard GPIO
> active low/high flags still present, or is it now only history ?
This was a few years back, so I don't remember the details; it might
have been as simple as "some bindings don't already have GPIO flags, and
I'd rather get GPIO regulators implemented first before thinking about
fixing that" or it could have been "some bindings don't already have
GPIO flags, and there's ${some reason} why it's not possible to solve
that in a backwards-compatible fashion" (recalling that DT bindings must
evolve in a backwards-compatible fashion since they're an ABI).
Unfortunately, you'd have to read through the mailing list posts related
to the patches that defined the GPIO regulator bindings or added the
nodes to DT.
> In other
> words, could we aim for using GPIO flags as the primary method to specify
> polarities, and fall back to the custom properties for backward compatibility
> (and possibly for GPIO controllers that don't support the flags) ?
I don't think we can switch to using GPIO flags, without changing the
compatible values for the relevant DT nodes.
For one, we'd need some way of actively marking the nodes to say whether
they are written to expect that the GPIO flags or the other properties
be used. It's not possible in all cases to determine this automatically.
For example, if enable-active-high it's fairly clear we should honor
this flag, yet if it's missing does that mean the GPIO is active-low or
simply that the node was written to expect that the GPIO flags be used
instead?
Also, old DTs must work with new kernels (and preferably also, new DTs
must work with old kernels). If the GPIO flags are wrong in current DTs,
then we can't use them. Of course, there's an argument that the
backwards-compatibility constraint doesn't apply to buggy DTs, just to
correctly written DTs. However, if we deliberately chose to make all
regulator GPIO flags ACTIVE_HIGH, then the current DTs aren't buggy.
^ permalink raw reply [flat|nested] 90+ messages in thread
* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
(?)
@ 2015-10-12 21:46 ` Tony Lindgren
-1 siblings, 0 replies; 90+ messages in thread
From: Tony Lindgren @ 2015-10-12 21:46 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-gpio-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Benoit Cousson, Jason Cooper,
Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Kukjin Kim,
Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Stephen Warren,
Thierry Reding, Alexandre Courbot, Liam Girdwood, Mark Brown,
Linus Walleij, Javier Martinez Canillas
* Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> [151012 14:17]:
> Hello,
>
> While working on regulators, GPIOs and DT I noticed that many of our DT source
> files incorrectly describe fixed regulators. The common error patterns are
>
> - Usage of the undefined (and never parsed) enable-active-low property
> - Usage of the enable-active-high property without specifying an enable GPIO
> - Typos in the enabl GPIO property name (gpios instead of gpio)
> - Mismatch between the enable-active-high property (or the lack thereof) and
> the enable GPIO flags
>
> This patch series fixes those issues in all the DT sources after locating the
> errors using the following script.
>
> ------------------------------------------------------------------------------
> #!/bin/sh
>
> echo $1
> cat $1 | awk '
> BEGIN {
> open_drain = 0;
> active_high = 0;
> gpio = 0;
> flags = 0;
> }
>
> match($0, /([a-zA-Z0-9@_-]*) {/, ary) {
> name = ary[1];
> }
>
> /compatible.*"regulator-fixed"/ {
> found = 1;
> }
>
> /enable-active-high/ {
> active_high = 1;
> }
>
> /gpio-open-drain/ {
> open_drain = 1;
> }
>
> match($0, /gpio += <.* ([^ ]*)>/, ary) {
> gpio = 1;
> flags = ary[1];
> if (flags == 0)
> flags = "GPIO_ACTIVE_HIGH";
> }
>
> /}/ {
> if (found) {
> if (gpio) {
> print "\t" name ": active high " active_high " " flags " open drain " open_drain;
> if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
> (!active_high && flags == "GPIO_ACTIVE_HIGH"))
> print "WARNING: enable-active-high and flags do not match"
> } else {
> if (active_high)
> print "WARNING: active high without GPIO"
> if (open_drain)
> print "WARNING: open drain without GPIO"
> }
> }
>
> gpio = 0;
> found = 0;
> active_high = 0;
> open_drain = 0;
> flags = 0;
> }
> '
> ------------------------------------------------------------------------------
>
> All patches except for the ones touching omap3-beagle-xm and omap3-overo-base
> are untested as I lack test hardware.
>
> As there's no dependency between the patches touching different source files
> the appropriate maintainers could take their share of the patches in their
> tree. Alternatively I could send a single pull request after collecting all
> acks but that might be more complex.
Nice clean-up. For omaps, there's an earlier patch posted by
Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> as "[PATCH] ARM: dts: Use
defined GPIO constants in flags cell for OMAP2+ boards". Can you guys do some
cross checking and let me know which combination I should appluy for omaps?
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 90+ messages in thread* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
@ 2015-10-12 21:46 ` Tony Lindgren
0 siblings, 0 replies; 90+ messages in thread
From: Tony Lindgren @ 2015-10-12 21:46 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel, devicetree, linux-omap, linux-samsung-soc,
linux-tegra, linux-gpio, linux-kernel, Benoit Cousson,
Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
Kukjin Kim, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Stephen Warren, Thierry Reding, Alexandre Courbot, Liam Girdwood,
Mark Brown, Linus Walleij, Javier Martinez Canillas
* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [151012 14:17]:
> Hello,
>
> While working on regulators, GPIOs and DT I noticed that many of our DT source
> files incorrectly describe fixed regulators. The common error patterns are
>
> - Usage of the undefined (and never parsed) enable-active-low property
> - Usage of the enable-active-high property without specifying an enable GPIO
> - Typos in the enabl GPIO property name (gpios instead of gpio)
> - Mismatch between the enable-active-high property (or the lack thereof) and
> the enable GPIO flags
>
> This patch series fixes those issues in all the DT sources after locating the
> errors using the following script.
>
> ------------------------------------------------------------------------------
> #!/bin/sh
>
> echo $1
> cat $1 | awk '
> BEGIN {
> open_drain = 0;
> active_high = 0;
> gpio = 0;
> flags = 0;
> }
>
> match($0, /([a-zA-Z0-9@_-]*) {/, ary) {
> name = ary[1];
> }
>
> /compatible.*"regulator-fixed"/ {
> found = 1;
> }
>
> /enable-active-high/ {
> active_high = 1;
> }
>
> /gpio-open-drain/ {
> open_drain = 1;
> }
>
> match($0, /gpio += <.* ([^ ]*)>/, ary) {
> gpio = 1;
> flags = ary[1];
> if (flags == 0)
> flags = "GPIO_ACTIVE_HIGH";
> }
>
> /}/ {
> if (found) {
> if (gpio) {
> print "\t" name ": active high " active_high " " flags " open drain " open_drain;
> if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
> (!active_high && flags == "GPIO_ACTIVE_HIGH"))
> print "WARNING: enable-active-high and flags do not match"
> } else {
> if (active_high)
> print "WARNING: active high without GPIO"
> if (open_drain)
> print "WARNING: open drain without GPIO"
> }
> }
>
> gpio = 0;
> found = 0;
> active_high = 0;
> open_drain = 0;
> flags = 0;
> }
> '
> ------------------------------------------------------------------------------
>
> All patches except for the ones touching omap3-beagle-xm and omap3-overo-base
> are untested as I lack test hardware.
>
> As there's no dependency between the patches touching different source files
> the appropriate maintainers could take their share of the patches in their
> tree. Alternatively I could send a single pull request after collecting all
> acks but that might be more complex.
Nice clean-up. For omaps, there's an earlier patch posted by
Javier Martinez Canillas <javier@osg.samsung.com> as "[PATCH] ARM: dts: Use
defined GPIO constants in flags cell for OMAP2+ boards". Can you guys do some
cross checking and let me know which combination I should appluy for omaps?
Regards,
Tony
^ permalink raw reply [flat|nested] 90+ messages in thread* [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
@ 2015-10-12 21:46 ` Tony Lindgren
0 siblings, 0 replies; 90+ messages in thread
From: Tony Lindgren @ 2015-10-12 21:46 UTC (permalink / raw)
To: linux-arm-kernel
* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [151012 14:17]:
> Hello,
>
> While working on regulators, GPIOs and DT I noticed that many of our DT source
> files incorrectly describe fixed regulators. The common error patterns are
>
> - Usage of the undefined (and never parsed) enable-active-low property
> - Usage of the enable-active-high property without specifying an enable GPIO
> - Typos in the enabl GPIO property name (gpios instead of gpio)
> - Mismatch between the enable-active-high property (or the lack thereof) and
> the enable GPIO flags
>
> This patch series fixes those issues in all the DT sources after locating the
> errors using the following script.
>
> ------------------------------------------------------------------------------
> #!/bin/sh
>
> echo $1
> cat $1 | awk '
> BEGIN {
> open_drain = 0;
> active_high = 0;
> gpio = 0;
> flags = 0;
> }
>
> match($0, /([a-zA-Z0-9 at _-]*) {/, ary) {
> name = ary[1];
> }
>
> /compatible.*"regulator-fixed"/ {
> found = 1;
> }
>
> /enable-active-high/ {
> active_high = 1;
> }
>
> /gpio-open-drain/ {
> open_drain = 1;
> }
>
> match($0, /gpio += <.* ([^ ]*)>/, ary) {
> gpio = 1;
> flags = ary[1];
> if (flags == 0)
> flags = "GPIO_ACTIVE_HIGH";
> }
>
> /}/ {
> if (found) {
> if (gpio) {
> print "\t" name ": active high " active_high " " flags " open drain " open_drain;
> if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
> (!active_high && flags == "GPIO_ACTIVE_HIGH"))
> print "WARNING: enable-active-high and flags do not match"
> } else {
> if (active_high)
> print "WARNING: active high without GPIO"
> if (open_drain)
> print "WARNING: open drain without GPIO"
> }
> }
>
> gpio = 0;
> found = 0;
> active_high = 0;
> open_drain = 0;
> flags = 0;
> }
> '
> ------------------------------------------------------------------------------
>
> All patches except for the ones touching omap3-beagle-xm and omap3-overo-base
> are untested as I lack test hardware.
>
> As there's no dependency between the patches touching different source files
> the appropriate maintainers could take their share of the patches in their
> tree. Alternatively I could send a single pull request after collecting all
> acks but that might be more complex.
Nice clean-up. For omaps, there's an earlier patch posted by
Javier Martinez Canillas <javier@osg.samsung.com> as "[PATCH] ARM: dts: Use
defined GPIO constants in flags cell for OMAP2+ boards". Can you guys do some
cross checking and let me know which combination I should appluy for omaps?
Regards,
Tony
^ permalink raw reply [flat|nested] 90+ messages in thread* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
2015-10-12 21:46 ` Tony Lindgren
@ 2015-10-12 22:19 ` Javier Martinez Canillas
-1 siblings, 0 replies; 90+ messages in thread
From: Javier Martinez Canillas @ 2015-10-12 22:19 UTC (permalink / raw)
To: Tony Lindgren, Laurent Pinchart
Cc: linux-arm-kernel, devicetree, linux-omap, linux-samsung-soc,
linux-tegra, linux-gpio, linux-kernel, Benoit Cousson,
Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
Kukjin Kim, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Stephen Warren, Thierry Reding, Alexandre Courbot, Liam Girdwood,
Mark Brown, Linus Walleij
Hello Tony,
On 10/12/2015 11:46 PM, Tony Lindgren wrote:
> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [151012 14:17]:
>> Hello,
>>
>> While working on regulators, GPIOs and DT I noticed that many of our DT source
>> files incorrectly describe fixed regulators. The common error patterns are
>>
>> - Usage of the undefined (and never parsed) enable-active-low property
>> - Usage of the enable-active-high property without specifying an enable GPIO
>> - Typos in the enabl GPIO property name (gpios instead of gpio)
>> - Mismatch between the enable-active-high property (or the lack thereof) and
>> the enable GPIO flags
>>
>> This patch series fixes those issues in all the DT sources after locating the
>> errors using the following script.
>>
>> ------------------------------------------------------------------------------
>> #!/bin/sh
>>
>> echo $1
>> cat $1 | awk '
>> BEGIN {
>> open_drain = 0;
>> active_high = 0;
>> gpio = 0;
>> flags = 0;
>> }
>>
>> match($0, /([a-zA-Z0-9@_-]*) {/, ary) {
>> name = ary[1];
>> }
>>
>> /compatible.*"regulator-fixed"/ {
>> found = 1;
>> }
>>
>> /enable-active-high/ {
>> active_high = 1;
>> }
>>
>> /gpio-open-drain/ {
>> open_drain = 1;
>> }
>>
>> match($0, /gpio += <.* ([^ ]*)>/, ary) {
>> gpio = 1;
>> flags = ary[1];
>> if (flags == 0)
>> flags = "GPIO_ACTIVE_HIGH";
>> }
>>
>> /}/ {
>> if (found) {
>> if (gpio) {
>> print "\t" name ": active high " active_high " " flags " open drain " open_drain;
>> if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
>> (!active_high && flags == "GPIO_ACTIVE_HIGH"))
>> print "WARNING: enable-active-high and flags do not match"
>> } else {
>> if (active_high)
>> print "WARNING: active high without GPIO"
>> if (open_drain)
>> print "WARNING: open drain without GPIO"
>> }
>> }
>>
>> gpio = 0;
>> found = 0;
>> active_high = 0;
>> open_drain = 0;
>> flags = 0;
>> }
>> '
>> ------------------------------------------------------------------------------
>>
>> All patches except for the ones touching omap3-beagle-xm and omap3-overo-base
>> are untested as I lack test hardware.
>>
>> As there's no dependency between the patches touching different source files
>> the appropriate maintainers could take their share of the patches in their
>> tree. Alternatively I could send a single pull request after collecting all
>> acks but that might be more complex.
>
> Nice clean-up. For omaps, there's an earlier patch posted by
> Javier Martinez Canillas <javier@osg.samsung.com> as "[PATCH] ARM: dts: Use
> defined GPIO constants in flags cell for OMAP2+ boards". Can you guys do some
> cross checking and let me know which combination I should appluy for omaps?
>
Since Laurent's changes for OMAP are part of a bigger series and my patch
was only for OMAP, probably makes sense for you to pick his patches and I
can re-spin mine on top of that.
BTW, I posted as a single patch since the changes were trivial but maybe
that made handling these conflicts harder and I should split the changes
instead, since I'll resend anyways.
What do you prefer? a patch per SoC family (i.e: OMAP{2,3,4,5}) or patch
per board DTS?
> Regards,
>
> Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 90+ messages in thread* [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
@ 2015-10-12 22:19 ` Javier Martinez Canillas
0 siblings, 0 replies; 90+ messages in thread
From: Javier Martinez Canillas @ 2015-10-12 22:19 UTC (permalink / raw)
To: linux-arm-kernel
Hello Tony,
On 10/12/2015 11:46 PM, Tony Lindgren wrote:
> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [151012 14:17]:
>> Hello,
>>
>> While working on regulators, GPIOs and DT I noticed that many of our DT source
>> files incorrectly describe fixed regulators. The common error patterns are
>>
>> - Usage of the undefined (and never parsed) enable-active-low property
>> - Usage of the enable-active-high property without specifying an enable GPIO
>> - Typos in the enabl GPIO property name (gpios instead of gpio)
>> - Mismatch between the enable-active-high property (or the lack thereof) and
>> the enable GPIO flags
>>
>> This patch series fixes those issues in all the DT sources after locating the
>> errors using the following script.
>>
>> ------------------------------------------------------------------------------
>> #!/bin/sh
>>
>> echo $1
>> cat $1 | awk '
>> BEGIN {
>> open_drain = 0;
>> active_high = 0;
>> gpio = 0;
>> flags = 0;
>> }
>>
>> match($0, /([a-zA-Z0-9 at _-]*) {/, ary) {
>> name = ary[1];
>> }
>>
>> /compatible.*"regulator-fixed"/ {
>> found = 1;
>> }
>>
>> /enable-active-high/ {
>> active_high = 1;
>> }
>>
>> /gpio-open-drain/ {
>> open_drain = 1;
>> }
>>
>> match($0, /gpio += <.* ([^ ]*)>/, ary) {
>> gpio = 1;
>> flags = ary[1];
>> if (flags == 0)
>> flags = "GPIO_ACTIVE_HIGH";
>> }
>>
>> /}/ {
>> if (found) {
>> if (gpio) {
>> print "\t" name ": active high " active_high " " flags " open drain " open_drain;
>> if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
>> (!active_high && flags == "GPIO_ACTIVE_HIGH"))
>> print "WARNING: enable-active-high and flags do not match"
>> } else {
>> if (active_high)
>> print "WARNING: active high without GPIO"
>> if (open_drain)
>> print "WARNING: open drain without GPIO"
>> }
>> }
>>
>> gpio = 0;
>> found = 0;
>> active_high = 0;
>> open_drain = 0;
>> flags = 0;
>> }
>> '
>> ------------------------------------------------------------------------------
>>
>> All patches except for the ones touching omap3-beagle-xm and omap3-overo-base
>> are untested as I lack test hardware.
>>
>> As there's no dependency between the patches touching different source files
>> the appropriate maintainers could take their share of the patches in their
>> tree. Alternatively I could send a single pull request after collecting all
>> acks but that might be more complex.
>
> Nice clean-up. For omaps, there's an earlier patch posted by
> Javier Martinez Canillas <javier@osg.samsung.com> as "[PATCH] ARM: dts: Use
> defined GPIO constants in flags cell for OMAP2+ boards". Can you guys do some
> cross checking and let me know which combination I should appluy for omaps?
>
Since Laurent's changes for OMAP are part of a bigger series and my patch
was only for OMAP, probably makes sense for you to pick his patches and I
can re-spin mine on top of that.
BTW, I posted as a single patch since the changes were trivial but maybe
that made handling these conflicts harder and I should split the changes
instead, since I'll resend anyways.
What do you prefer? a patch per SoC family (i.e: OMAP{2,3,4,5}) or patch
per board DTS?
> Regards,
>
> Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 90+ messages in thread* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
2015-10-12 22:19 ` Javier Martinez Canillas
@ 2015-10-12 22:22 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 22:22 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Tony Lindgren, linux-arm-kernel, devicetree, linux-omap,
linux-samsung-soc, linux-tegra, linux-gpio, linux-kernel,
Benoit Cousson, Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Kukjin Kim, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Stephen Warren, Thierry Reding, Alexandre Courbot,
Liam Girdwood, Mark Brown, Linus Walleij
Hi Javier,
On Tuesday 13 October 2015 00:19:20 Javier Martinez Canillas wrote:
> On 10/12/2015 11:46 PM, Tony Lindgren wrote:
> > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [151012 14:17]:
> >> Hello,
> >>
> >> While working on regulators, GPIOs and DT I noticed that many of our DT
> >> source files incorrectly describe fixed regulators. The common error
> >> patterns are
> >>
> >> - Usage of the undefined (and never parsed) enable-active-low property
> >> - Usage of the enable-active-high property without specifying an enable
> >> GPIO
> >> - Typos in the enabl GPIO property name (gpios instead of gpio)
> >> - Mismatch between the enable-active-high property (or the lack thereof)
> >> and the enable GPIO flags
> >>
> >> This patch series fixes those issues in all the DT sources after locating
> >> the errors using the following script.
> >>
> >> -------------------------------------------------------------------------
> >> !/bin/sh
> >>
> >> echo $1
> >> cat $1 | awk '
> >> BEGIN {
> >> open_drain = 0;
> >> active_high = 0;
> >> gpio = 0;
> >> flags = 0;
> >> }
> >>
> >> match($0, /([a-zA-Z0-9@_-]*) {/, ary) {
> >> name = ary[1];
> >> }
> >>
> >> /compatible.*"regulator-fixed"/ {
> >> found = 1;
> >> }
> >>
> >> /enable-active-high/ {
> >> active_high = 1;
> >> }
> >>
> >> /gpio-open-drain/ {
> >> open_drain = 1;
> >> }
> >>
> >> match($0, /gpio += <.* ([^ ]*)>/, ary) {
> >> gpio = 1;
> >> flags = ary[1];
> >> if (flags == 0)
> >> flags = "GPIO_ACTIVE_HIGH";
> >> }
> >>
> >> /}/ {
> >> if (found) {
> >> if (gpio) {
> >> print "\t" name ": active high " active_high " " flags " open
drain "
> >> open_drain;
> >> if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
> >> (!active_high && flags == "GPIO_ACTIVE_HIGH"))
> >> print "WARNING: enable-active-high and flags do not
match"
> >> } else {
> >> if (active_high)
> >> print "WARNING: active high without GPIO"
> >> if (open_drain)
> >> print "WARNING: open drain without GPIO"
> >> }
> >> }
> >>
> >> gpio = 0;
> >> found = 0;
> >> active_high = 0;
> >> open_drain = 0;
> >> flags = 0;
> >> }
> >> '
> >> -------------------------------------------------------------------------
> >>
> >> All patches except for the ones touching omap3-beagle-xm and
> >> omap3-overo-base are untested as I lack test hardware.
> >>
> >> As there's no dependency between the patches touching different source
> >> files the appropriate maintainers could take their share of the patches
> >> in their tree. Alternatively I could send a single pull request after
> >> collecting all acks but that might be more complex.
> >
> > Nice clean-up. For omaps, there's an earlier patch posted by
> > Javier Martinez Canillas <javier@osg.samsung.com> as "[PATCH] ARM: dts:
> > Use defined GPIO constants in flags cell for OMAP2+ boards". Can you guys
> > do some cross checking and let me know which combination I should appluy
> > for omaps?
>
> Since Laurent's changes for OMAP are part of a bigger series and my patch
> was only for OMAP, probably makes sense for you to pick his patches and I
> can re-spin mine on top of that.
>
> BTW, I posted as a single patch since the changes were trivial but maybe
> that made handling these conflicts harder and I should split the changes
> instead, since I'll resend anyways.
>
> What do you prefer? a patch per SoC family (i.e: OMAP{2,3,4,5}) or patch
> per board DTS?
My series will likely miss the next merge window as more discussion is needed.
I'll thus respin the patches on top of yours, please proceed without caring
about this.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 90+ messages in thread* [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
@ 2015-10-12 22:22 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-12 22:22 UTC (permalink / raw)
To: linux-arm-kernel
Hi Javier,
On Tuesday 13 October 2015 00:19:20 Javier Martinez Canillas wrote:
> On 10/12/2015 11:46 PM, Tony Lindgren wrote:
> > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [151012 14:17]:
> >> Hello,
> >>
> >> While working on regulators, GPIOs and DT I noticed that many of our DT
> >> source files incorrectly describe fixed regulators. The common error
> >> patterns are
> >>
> >> - Usage of the undefined (and never parsed) enable-active-low property
> >> - Usage of the enable-active-high property without specifying an enable
> >> GPIO
> >> - Typos in the enabl GPIO property name (gpios instead of gpio)
> >> - Mismatch between the enable-active-high property (or the lack thereof)
> >> and the enable GPIO flags
> >>
> >> This patch series fixes those issues in all the DT sources after locating
> >> the errors using the following script.
> >>
> >> -------------------------------------------------------------------------
> >> !/bin/sh
> >>
> >> echo $1
> >> cat $1 | awk '
> >> BEGIN {
> >> open_drain = 0;
> >> active_high = 0;
> >> gpio = 0;
> >> flags = 0;
> >> }
> >>
> >> match($0, /([a-zA-Z0-9 at _-]*) {/, ary) {
> >> name = ary[1];
> >> }
> >>
> >> /compatible.*"regulator-fixed"/ {
> >> found = 1;
> >> }
> >>
> >> /enable-active-high/ {
> >> active_high = 1;
> >> }
> >>
> >> /gpio-open-drain/ {
> >> open_drain = 1;
> >> }
> >>
> >> match($0, /gpio += <.* ([^ ]*)>/, ary) {
> >> gpio = 1;
> >> flags = ary[1];
> >> if (flags == 0)
> >> flags = "GPIO_ACTIVE_HIGH";
> >> }
> >>
> >> /}/ {
> >> if (found) {
> >> if (gpio) {
> >> print "\t" name ": active high " active_high " " flags " open
drain "
> >> open_drain;
> >> if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
> >> (!active_high && flags == "GPIO_ACTIVE_HIGH"))
> >> print "WARNING: enable-active-high and flags do not
match"
> >> } else {
> >> if (active_high)
> >> print "WARNING: active high without GPIO"
> >> if (open_drain)
> >> print "WARNING: open drain without GPIO"
> >> }
> >> }
> >>
> >> gpio = 0;
> >> found = 0;
> >> active_high = 0;
> >> open_drain = 0;
> >> flags = 0;
> >> }
> >> '
> >> -------------------------------------------------------------------------
> >>
> >> All patches except for the ones touching omap3-beagle-xm and
> >> omap3-overo-base are untested as I lack test hardware.
> >>
> >> As there's no dependency between the patches touching different source
> >> files the appropriate maintainers could take their share of the patches
> >> in their tree. Alternatively I could send a single pull request after
> >> collecting all acks but that might be more complex.
> >
> > Nice clean-up. For omaps, there's an earlier patch posted by
> > Javier Martinez Canillas <javier@osg.samsung.com> as "[PATCH] ARM: dts:
> > Use defined GPIO constants in flags cell for OMAP2+ boards". Can you guys
> > do some cross checking and let me know which combination I should appluy
> > for omaps?
>
> Since Laurent's changes for OMAP are part of a bigger series and my patch
> was only for OMAP, probably makes sense for you to pick his patches and I
> can re-spin mine on top of that.
>
> BTW, I posted as a single patch since the changes were trivial but maybe
> that made handling these conflicts harder and I should split the changes
> instead, since I'll resend anyways.
>
> What do you prefer? a patch per SoC family (i.e: OMAP{2,3,4,5}) or patch
> per board DTS?
My series will likely miss the next merge window as more discussion is needed.
I'll thus respin the patches on top of yours, please proceed without caring
about this.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 90+ messages in thread* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
2015-10-12 22:22 ` Laurent Pinchart
(?)
@ 2015-10-12 22:24 ` Tony Lindgren
-1 siblings, 0 replies; 90+ messages in thread
From: Tony Lindgren @ 2015-10-12 22:24 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Javier Martinez Canillas,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-gpio-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Benoit Cousson, Jason Cooper,
Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Kukjin Kim,
Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Stephen Warren,
Thierry Reding, Alexandre Courbot, Liam Girdwood, Mark Brown,
Linus Walleij
* Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> [151012 15:26]:
> Hi Javier,
>
> On Tuesday 13 October 2015 00:19:20 Javier Martinez Canillas wrote:
> > On 10/12/2015 11:46 PM, Tony Lindgren wrote:
> > > * Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> [151012 14:17]:
> > >> Hello,
> > >>
> > >> While working on regulators, GPIOs and DT I noticed that many of our DT
> > >> source files incorrectly describe fixed regulators. The common error
> > >> patterns are
> > >>
> > >> - Usage of the undefined (and never parsed) enable-active-low property
> > >> - Usage of the enable-active-high property without specifying an enable
> > >> GPIO
> > >> - Typos in the enabl GPIO property name (gpios instead of gpio)
> > >> - Mismatch between the enable-active-high property (or the lack thereof)
> > >> and the enable GPIO flags
> > >>
> > >> This patch series fixes those issues in all the DT sources after locating
> > >> the errors using the following script.
> > >>
> > >> -------------------------------------------------------------------------
> > >> !/bin/sh
> > >>
> > >> echo $1
> > >> cat $1 | awk '
> > >> BEGIN {
> > >> open_drain = 0;
> > >> active_high = 0;
> > >> gpio = 0;
> > >> flags = 0;
> > >> }
> > >>
> > >> match($0, /([a-zA-Z0-9@_-]*) {/, ary) {
> > >> name = ary[1];
> > >> }
> > >>
> > >> /compatible.*"regulator-fixed"/ {
> > >> found = 1;
> > >> }
> > >>
> > >> /enable-active-high/ {
> > >> active_high = 1;
> > >> }
> > >>
> > >> /gpio-open-drain/ {
> > >> open_drain = 1;
> > >> }
> > >>
> > >> match($0, /gpio += <.* ([^ ]*)>/, ary) {
> > >> gpio = 1;
> > >> flags = ary[1];
> > >> if (flags == 0)
> > >> flags = "GPIO_ACTIVE_HIGH";
> > >> }
> > >>
> > >> /}/ {
> > >> if (found) {
> > >> if (gpio) {
> > >> print "\t" name ": active high " active_high " " flags " open
> drain "
> > >> open_drain;
> > >> if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
> > >> (!active_high && flags == "GPIO_ACTIVE_HIGH"))
> > >> print "WARNING: enable-active-high and flags do not
> match"
> > >> } else {
> > >> if (active_high)
> > >> print "WARNING: active high without GPIO"
> > >> if (open_drain)
> > >> print "WARNING: open drain without GPIO"
> > >> }
> > >> }
> > >>
> > >> gpio = 0;
> > >> found = 0;
> > >> active_high = 0;
> > >> open_drain = 0;
> > >> flags = 0;
> > >> }
> > >> '
> > >> -------------------------------------------------------------------------
> > >>
> > >> All patches except for the ones touching omap3-beagle-xm and
> > >> omap3-overo-base are untested as I lack test hardware.
> > >>
> > >> As there's no dependency between the patches touching different source
> > >> files the appropriate maintainers could take their share of the patches
> > >> in their tree. Alternatively I could send a single pull request after
> > >> collecting all acks but that might be more complex.
> > >
> > > Nice clean-up. For omaps, there's an earlier patch posted by
> > > Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> as "[PATCH] ARM: dts:
> > > Use defined GPIO constants in flags cell for OMAP2+ boards". Can you guys
> > > do some cross checking and let me know which combination I should appluy
> > > for omaps?
> >
> > Since Laurent's changes for OMAP are part of a bigger series and my patch
> > was only for OMAP, probably makes sense for you to pick his patches and I
> > can re-spin mine on top of that.
> >
> > BTW, I posted as a single patch since the changes were trivial but maybe
> > that made handling these conflicts harder and I should split the changes
> > instead, since I'll resend anyways.
> >
> > What do you prefer? a patch per SoC family (i.e: OMAP{2,3,4,5}) or patch
> > per board DTS?
>
> My series will likely miss the next merge window as more discussion is needed.
> I'll thus respin the patches on top of yours, please proceed without caring
> about this.
OK applying Javier's patch into omap-for-v4.4/dt then.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 90+ messages in thread* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
@ 2015-10-12 22:24 ` Tony Lindgren
0 siblings, 0 replies; 90+ messages in thread
From: Tony Lindgren @ 2015-10-12 22:24 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Javier Martinez Canillas, linux-arm-kernel, devicetree,
linux-omap, linux-samsung-soc, linux-tegra, linux-gpio,
linux-kernel, Benoit Cousson, Jason Cooper, Andrew Lunn,
Gregory Clement, Sebastian Hesselbarth, Kukjin Kim,
Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Stephen Warren,
Thierry Reding, Alexandre Courbot, Liam Girdwood, Mark Brown,
Linus Walleij
* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [151012 15:26]:
> Hi Javier,
>
> On Tuesday 13 October 2015 00:19:20 Javier Martinez Canillas wrote:
> > On 10/12/2015 11:46 PM, Tony Lindgren wrote:
> > > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [151012 14:17]:
> > >> Hello,
> > >>
> > >> While working on regulators, GPIOs and DT I noticed that many of our DT
> > >> source files incorrectly describe fixed regulators. The common error
> > >> patterns are
> > >>
> > >> - Usage of the undefined (and never parsed) enable-active-low property
> > >> - Usage of the enable-active-high property without specifying an enable
> > >> GPIO
> > >> - Typos in the enabl GPIO property name (gpios instead of gpio)
> > >> - Mismatch between the enable-active-high property (or the lack thereof)
> > >> and the enable GPIO flags
> > >>
> > >> This patch series fixes those issues in all the DT sources after locating
> > >> the errors using the following script.
> > >>
> > >> -------------------------------------------------------------------------
> > >> !/bin/sh
> > >>
> > >> echo $1
> > >> cat $1 | awk '
> > >> BEGIN {
> > >> open_drain = 0;
> > >> active_high = 0;
> > >> gpio = 0;
> > >> flags = 0;
> > >> }
> > >>
> > >> match($0, /([a-zA-Z0-9@_-]*) {/, ary) {
> > >> name = ary[1];
> > >> }
> > >>
> > >> /compatible.*"regulator-fixed"/ {
> > >> found = 1;
> > >> }
> > >>
> > >> /enable-active-high/ {
> > >> active_high = 1;
> > >> }
> > >>
> > >> /gpio-open-drain/ {
> > >> open_drain = 1;
> > >> }
> > >>
> > >> match($0, /gpio += <.* ([^ ]*)>/, ary) {
> > >> gpio = 1;
> > >> flags = ary[1];
> > >> if (flags == 0)
> > >> flags = "GPIO_ACTIVE_HIGH";
> > >> }
> > >>
> > >> /}/ {
> > >> if (found) {
> > >> if (gpio) {
> > >> print "\t" name ": active high " active_high " " flags " open
> drain "
> > >> open_drain;
> > >> if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
> > >> (!active_high && flags == "GPIO_ACTIVE_HIGH"))
> > >> print "WARNING: enable-active-high and flags do not
> match"
> > >> } else {
> > >> if (active_high)
> > >> print "WARNING: active high without GPIO"
> > >> if (open_drain)
> > >> print "WARNING: open drain without GPIO"
> > >> }
> > >> }
> > >>
> > >> gpio = 0;
> > >> found = 0;
> > >> active_high = 0;
> > >> open_drain = 0;
> > >> flags = 0;
> > >> }
> > >> '
> > >> -------------------------------------------------------------------------
> > >>
> > >> All patches except for the ones touching omap3-beagle-xm and
> > >> omap3-overo-base are untested as I lack test hardware.
> > >>
> > >> As there's no dependency between the patches touching different source
> > >> files the appropriate maintainers could take their share of the patches
> > >> in their tree. Alternatively I could send a single pull request after
> > >> collecting all acks but that might be more complex.
> > >
> > > Nice clean-up. For omaps, there's an earlier patch posted by
> > > Javier Martinez Canillas <javier@osg.samsung.com> as "[PATCH] ARM: dts:
> > > Use defined GPIO constants in flags cell for OMAP2+ boards". Can you guys
> > > do some cross checking and let me know which combination I should appluy
> > > for omaps?
> >
> > Since Laurent's changes for OMAP are part of a bigger series and my patch
> > was only for OMAP, probably makes sense for you to pick his patches and I
> > can re-spin mine on top of that.
> >
> > BTW, I posted as a single patch since the changes were trivial but maybe
> > that made handling these conflicts harder and I should split the changes
> > instead, since I'll resend anyways.
> >
> > What do you prefer? a patch per SoC family (i.e: OMAP{2,3,4,5}) or patch
> > per board DTS?
>
> My series will likely miss the next merge window as more discussion is needed.
> I'll thus respin the patches on top of yours, please proceed without caring
> about this.
OK applying Javier's patch into omap-for-v4.4/dt then.
Regards,
Tony
^ permalink raw reply [flat|nested] 90+ messages in thread* [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
@ 2015-10-12 22:24 ` Tony Lindgren
0 siblings, 0 replies; 90+ messages in thread
From: Tony Lindgren @ 2015-10-12 22:24 UTC (permalink / raw)
To: linux-arm-kernel
* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [151012 15:26]:
> Hi Javier,
>
> On Tuesday 13 October 2015 00:19:20 Javier Martinez Canillas wrote:
> > On 10/12/2015 11:46 PM, Tony Lindgren wrote:
> > > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [151012 14:17]:
> > >> Hello,
> > >>
> > >> While working on regulators, GPIOs and DT I noticed that many of our DT
> > >> source files incorrectly describe fixed regulators. The common error
> > >> patterns are
> > >>
> > >> - Usage of the undefined (and never parsed) enable-active-low property
> > >> - Usage of the enable-active-high property without specifying an enable
> > >> GPIO
> > >> - Typos in the enabl GPIO property name (gpios instead of gpio)
> > >> - Mismatch between the enable-active-high property (or the lack thereof)
> > >> and the enable GPIO flags
> > >>
> > >> This patch series fixes those issues in all the DT sources after locating
> > >> the errors using the following script.
> > >>
> > >> -------------------------------------------------------------------------
> > >> !/bin/sh
> > >>
> > >> echo $1
> > >> cat $1 | awk '
> > >> BEGIN {
> > >> open_drain = 0;
> > >> active_high = 0;
> > >> gpio = 0;
> > >> flags = 0;
> > >> }
> > >>
> > >> match($0, /([a-zA-Z0-9 at _-]*) {/, ary) {
> > >> name = ary[1];
> > >> }
> > >>
> > >> /compatible.*"regulator-fixed"/ {
> > >> found = 1;
> > >> }
> > >>
> > >> /enable-active-high/ {
> > >> active_high = 1;
> > >> }
> > >>
> > >> /gpio-open-drain/ {
> > >> open_drain = 1;
> > >> }
> > >>
> > >> match($0, /gpio += <.* ([^ ]*)>/, ary) {
> > >> gpio = 1;
> > >> flags = ary[1];
> > >> if (flags == 0)
> > >> flags = "GPIO_ACTIVE_HIGH";
> > >> }
> > >>
> > >> /}/ {
> > >> if (found) {
> > >> if (gpio) {
> > >> print "\t" name ": active high " active_high " " flags " open
> drain "
> > >> open_drain;
> > >> if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
> > >> (!active_high && flags == "GPIO_ACTIVE_HIGH"))
> > >> print "WARNING: enable-active-high and flags do not
> match"
> > >> } else {
> > >> if (active_high)
> > >> print "WARNING: active high without GPIO"
> > >> if (open_drain)
> > >> print "WARNING: open drain without GPIO"
> > >> }
> > >> }
> > >>
> > >> gpio = 0;
> > >> found = 0;
> > >> active_high = 0;
> > >> open_drain = 0;
> > >> flags = 0;
> > >> }
> > >> '
> > >> -------------------------------------------------------------------------
> > >>
> > >> All patches except for the ones touching omap3-beagle-xm and
> > >> omap3-overo-base are untested as I lack test hardware.
> > >>
> > >> As there's no dependency between the patches touching different source
> > >> files the appropriate maintainers could take their share of the patches
> > >> in their tree. Alternatively I could send a single pull request after
> > >> collecting all acks but that might be more complex.
> > >
> > > Nice clean-up. For omaps, there's an earlier patch posted by
> > > Javier Martinez Canillas <javier@osg.samsung.com> as "[PATCH] ARM: dts:
> > > Use defined GPIO constants in flags cell for OMAP2+ boards". Can you guys
> > > do some cross checking and let me know which combination I should appluy
> > > for omaps?
> >
> > Since Laurent's changes for OMAP are part of a bigger series and my patch
> > was only for OMAP, probably makes sense for you to pick his patches and I
> > can re-spin mine on top of that.
> >
> > BTW, I posted as a single patch since the changes were trivial but maybe
> > that made handling these conflicts harder and I should split the changes
> > instead, since I'll resend anyways.
> >
> > What do you prefer? a patch per SoC family (i.e: OMAP{2,3,4,5}) or patch
> > per board DTS?
>
> My series will likely miss the next merge window as more discussion is needed.
> I'll thus respin the patches on top of yours, please proceed without caring
> about this.
OK applying Javier's patch into omap-for-v4.4/dt then.
Regards,
Tony
^ permalink raw reply [flat|nested] 90+ messages in thread
* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
(?)
@ 2015-10-13 6:19 ` Sascha Hauer
-1 siblings, 0 replies; 90+ messages in thread
From: Sascha Hauer @ 2015-10-13 6:19 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Andrew Lunn,
Krzysztof Kozlowski, Tony Lindgren, Linus Walleij, Liam Girdwood,
Gregory Clement, Thierry Reding, Alexandre Courbot,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Kukjin Kim,
Sebastian Hesselbarth, devicetree-u79uwXL29TY76Z2rM5mHXA,
Jason Cooper, Stephen Warren, linux-gpio-u79uwXL29TY76Z2rM5mHXA,
Mark Brown, linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA, Sascha Hauer,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Benoit Cousson, Shawn Guo
On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote:
> Hello,
>
> While working on regulators, GPIOs and DT I noticed that many of our DT source
> files incorrectly describe fixed regulators. The common error patterns are
>
> - Usage of the undefined (and never parsed) enable-active-low property
> - Usage of the enable-active-high property without specifying an enable GPIO
> - Typos in the enabl GPIO property name (gpios instead of gpio)
> - Mismatch between the enable-active-high property (or the lack thereof) and
> the enable GPIO flags
>
> This patch series fixes those issues in all the DT sources after locating the
> errors using the following script.
Nice. For the i.MX boards:
Reviewed-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 90+ messages in thread
* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
@ 2015-10-13 6:19 ` Sascha Hauer
0 siblings, 0 replies; 90+ messages in thread
From: Sascha Hauer @ 2015-10-13 6:19 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel, Andrew Lunn, Krzysztof Kozlowski, Tony Lindgren,
Linus Walleij, Liam Girdwood, Gregory Clement, Thierry Reding,
Alexandre Courbot, linux-samsung-soc, Kukjin Kim,
Sebastian Hesselbarth, devicetree, Jason Cooper, Stephen Warren,
linux-gpio, Mark Brown, linux-tegra, linux-omap, Sascha Hauer,
linux-kernel, Benoit Cousson, Shawn Guo
On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote:
> Hello,
>
> While working on regulators, GPIOs and DT I noticed that many of our DT source
> files incorrectly describe fixed regulators. The common error patterns are
>
> - Usage of the undefined (and never parsed) enable-active-low property
> - Usage of the enable-active-high property without specifying an enable GPIO
> - Typos in the enabl GPIO property name (gpios instead of gpio)
> - Mismatch between the enable-active-high property (or the lack thereof) and
> the enable GPIO flags
>
> This patch series fixes those issues in all the DT sources after locating the
> errors using the following script.
Nice. For the i.MX boards:
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 90+ messages in thread
* [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
@ 2015-10-13 6:19 ` Sascha Hauer
0 siblings, 0 replies; 90+ messages in thread
From: Sascha Hauer @ 2015-10-13 6:19 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote:
> Hello,
>
> While working on regulators, GPIOs and DT I noticed that many of our DT source
> files incorrectly describe fixed regulators. The common error patterns are
>
> - Usage of the undefined (and never parsed) enable-active-low property
> - Usage of the enable-active-high property without specifying an enable GPIO
> - Typos in the enabl GPIO property name (gpios instead of gpio)
> - Mismatch between the enable-active-high property (or the lack thereof) and
> the enable GPIO flags
>
> This patch series fixes those issues in all the DT sources after locating the
> errors using the following script.
Nice. For the i.MX boards:
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 90+ messages in thread
* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
2015-10-12 21:12 ` Laurent Pinchart
(?)
@ 2015-10-13 14:09 ` Shawn Guo
-1 siblings, 0 replies; 90+ messages in thread
From: Shawn Guo @ 2015-10-13 14:09 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-gpio-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Benoit Cousson,
Tony Lindgren, Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Kukjin Kim, Krzysztof Kozlowski,
Sascha Hauer, Stephen Warren, Thierry Reding, Alexandre Courbot,
Liam Girdwood, Mark Brown, Linus Walleij
On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote:
> Laurent Pinchart (37):
...
> ARM: imx6sx-sdb: Fix typo in regulator enable GPIO property
...
> ARM: dts: imx6qdl-tx6: Fix regulator enable GPIO polarity
...
> ARM: dts: imx23-evk: Fix regulator enable GPIO polarity
> ARM: dts: imx23-stmp378x_devb: Fix regulator enable GPIO polarity
> ARM: dts: imx25-pdk: Fix regulator enable GPIO polarity
> ARM: dts: imx28-cfa10036: Fix regulator enable GPIO polarity
> ARM: dts: imx28-evk: Fix regulator enable GPIO polarity
> ARM: dts: imx28-m28cu3: Fix regulator enable GPIO polarity
> ARM: dts: imx28-m28evk: Fix regulator enable GPIO polarity
> ARM: dts: imx28-sps1: Fix regulator enable GPIO polarity
> ARM: dts: imx28-tx28: Fix regulator enable GPIO polarity
> ARM: dts: imx53-m53evk: Fix regulator enable GPIO polarity
> ARM: dts: imx53-mba53: Fix regulator enable GPIO polarity
> ARM: dts: imx53-tx53: Fix regulator enable GPIO polarity
> ARM: dts: imx6q-dmo-edmqmx6: Fix regulator enable GPIO polarity
Applied these 15 patches, thanks.
^ permalink raw reply [flat|nested] 90+ messages in thread
* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
@ 2015-10-13 14:09 ` Shawn Guo
0 siblings, 0 replies; 90+ messages in thread
From: Shawn Guo @ 2015-10-13 14:09 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel, devicetree, linux-omap, linux-samsung-soc,
linux-tegra, linux-gpio, linux-kernel, Benoit Cousson,
Tony Lindgren, Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Kukjin Kim, Krzysztof Kozlowski,
Sascha Hauer, Stephen Warren, Thierry Reding, Alexandre Courbot,
Liam Girdwood, Mark Brown, Linus Walleij
On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote:
> Laurent Pinchart (37):
...
> ARM: imx6sx-sdb: Fix typo in regulator enable GPIO property
...
> ARM: dts: imx6qdl-tx6: Fix regulator enable GPIO polarity
...
> ARM: dts: imx23-evk: Fix regulator enable GPIO polarity
> ARM: dts: imx23-stmp378x_devb: Fix regulator enable GPIO polarity
> ARM: dts: imx25-pdk: Fix regulator enable GPIO polarity
> ARM: dts: imx28-cfa10036: Fix regulator enable GPIO polarity
> ARM: dts: imx28-evk: Fix regulator enable GPIO polarity
> ARM: dts: imx28-m28cu3: Fix regulator enable GPIO polarity
> ARM: dts: imx28-m28evk: Fix regulator enable GPIO polarity
> ARM: dts: imx28-sps1: Fix regulator enable GPIO polarity
> ARM: dts: imx28-tx28: Fix regulator enable GPIO polarity
> ARM: dts: imx53-m53evk: Fix regulator enable GPIO polarity
> ARM: dts: imx53-mba53: Fix regulator enable GPIO polarity
> ARM: dts: imx53-tx53: Fix regulator enable GPIO polarity
> ARM: dts: imx6q-dmo-edmqmx6: Fix regulator enable GPIO polarity
Applied these 15 patches, thanks.
^ permalink raw reply [flat|nested] 90+ messages in thread
* [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
@ 2015-10-13 14:09 ` Shawn Guo
0 siblings, 0 replies; 90+ messages in thread
From: Shawn Guo @ 2015-10-13 14:09 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote:
> Laurent Pinchart (37):
...
> ARM: imx6sx-sdb: Fix typo in regulator enable GPIO property
...
> ARM: dts: imx6qdl-tx6: Fix regulator enable GPIO polarity
...
> ARM: dts: imx23-evk: Fix regulator enable GPIO polarity
> ARM: dts: imx23-stmp378x_devb: Fix regulator enable GPIO polarity
> ARM: dts: imx25-pdk: Fix regulator enable GPIO polarity
> ARM: dts: imx28-cfa10036: Fix regulator enable GPIO polarity
> ARM: dts: imx28-evk: Fix regulator enable GPIO polarity
> ARM: dts: imx28-m28cu3: Fix regulator enable GPIO polarity
> ARM: dts: imx28-m28evk: Fix regulator enable GPIO polarity
> ARM: dts: imx28-sps1: Fix regulator enable GPIO polarity
> ARM: dts: imx28-tx28: Fix regulator enable GPIO polarity
> ARM: dts: imx53-m53evk: Fix regulator enable GPIO polarity
> ARM: dts: imx53-mba53: Fix regulator enable GPIO polarity
> ARM: dts: imx53-tx53: Fix regulator enable GPIO polarity
> ARM: dts: imx6q-dmo-edmqmx6: Fix regulator enable GPIO polarity
Applied these 15 patches, thanks.
^ permalink raw reply [flat|nested] 90+ messages in thread
* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
2015-10-13 14:09 ` Shawn Guo
@ 2015-10-13 14:17 ` Laurent Pinchart
-1 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-13 14:17 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-arm-kernel, devicetree, linux-omap, linux-samsung-soc,
linux-tegra, linux-gpio, linux-kernel, Benoit Cousson,
Tony Lindgren, Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Kukjin Kim, Krzysztof Kozlowski,
Sascha Hauer, Stephen Warren, Thierry Reding, Alexandre Courbot,
Liam Girdwood, Mark Brown, Linus Walleij
Hi Shawn,
On Tuesday 13 October 2015 22:09:46 Shawn Guo wrote:
> On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote:
> > Laurent Pinchart (37):
> ...
>
> > ARM: imx6sx-sdb: Fix typo in regulator enable GPIO property
>
> ...
>
> > ARM: dts: imx6qdl-tx6: Fix regulator enable GPIO polarity
>
> ...
>
> > ARM: dts: imx23-evk: Fix regulator enable GPIO polarity
> > ARM: dts: imx23-stmp378x_devb: Fix regulator enable GPIO polarity
> > ARM: dts: imx25-pdk: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-cfa10036: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-evk: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-m28cu3: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-m28evk: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-sps1: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-tx28: Fix regulator enable GPIO polarity
> > ARM: dts: imx53-m53evk: Fix regulator enable GPIO polarity
> > ARM: dts: imx53-mba53: Fix regulator enable GPIO polarity
> > ARM: dts: imx53-tx53: Fix regulator enable GPIO polarity
> > ARM: dts: imx6q-dmo-edmqmx6: Fix regulator enable GPIO polarity
>
> Applied these 15 patches, thanks.
There's ongoing discussions regarding whether this is the right thing to do.
Please see http://www.spinics.net/lists/arm-kernel/msg451724.html. It's thus a
bit early to apply the patches at this point I'm afraid.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 90+ messages in thread
* [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
@ 2015-10-13 14:17 ` Laurent Pinchart
0 siblings, 0 replies; 90+ messages in thread
From: Laurent Pinchart @ 2015-10-13 14:17 UTC (permalink / raw)
To: linux-arm-kernel
Hi Shawn,
On Tuesday 13 October 2015 22:09:46 Shawn Guo wrote:
> On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote:
> > Laurent Pinchart (37):
> ...
>
> > ARM: imx6sx-sdb: Fix typo in regulator enable GPIO property
>
> ...
>
> > ARM: dts: imx6qdl-tx6: Fix regulator enable GPIO polarity
>
> ...
>
> > ARM: dts: imx23-evk: Fix regulator enable GPIO polarity
> > ARM: dts: imx23-stmp378x_devb: Fix regulator enable GPIO polarity
> > ARM: dts: imx25-pdk: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-cfa10036: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-evk: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-m28cu3: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-m28evk: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-sps1: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-tx28: Fix regulator enable GPIO polarity
> > ARM: dts: imx53-m53evk: Fix regulator enable GPIO polarity
> > ARM: dts: imx53-mba53: Fix regulator enable GPIO polarity
> > ARM: dts: imx53-tx53: Fix regulator enable GPIO polarity
> > ARM: dts: imx6q-dmo-edmqmx6: Fix regulator enable GPIO polarity
>
> Applied these 15 patches, thanks.
There's ongoing discussions regarding whether this is the right thing to do.
Please see http://www.spinics.net/lists/arm-kernel/msg451724.html. It's thus a
bit early to apply the patches at this point I'm afraid.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 90+ messages in thread
* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
2015-10-13 14:17 ` Laurent Pinchart
@ 2015-10-13 15:09 ` Shawn Guo
-1 siblings, 0 replies; 90+ messages in thread
From: Shawn Guo @ 2015-10-13 15:09 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel, devicetree, linux-omap, linux-samsung-soc,
linux-tegra, linux-gpio, linux-kernel, Benoit Cousson,
Tony Lindgren, Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Kukjin Kim, Krzysztof Kozlowski,
Sascha Hauer, Stephen Warren, Thierry Reding, Alexandre Courbot,
Liam Girdwood, Mark Brown, Linus Walleij
On Tue, Oct 13, 2015 at 05:17:24PM +0300, Laurent Pinchart wrote:
> Hi Shawn,
>
> On Tuesday 13 October 2015 22:09:46 Shawn Guo wrote:
> > On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote:
> > > Laurent Pinchart (37):
> > ...
> >
> > > ARM: imx6sx-sdb: Fix typo in regulator enable GPIO property
> >
> > ...
> >
> > > ARM: dts: imx6qdl-tx6: Fix regulator enable GPIO polarity
> >
> > ...
> >
> > > ARM: dts: imx23-evk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx23-stmp378x_devb: Fix regulator enable GPIO polarity
> > > ARM: dts: imx25-pdk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-cfa10036: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-evk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-m28cu3: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-m28evk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-sps1: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-tx28: Fix regulator enable GPIO polarity
> > > ARM: dts: imx53-m53evk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx53-mba53: Fix regulator enable GPIO polarity
> > > ARM: dts: imx53-tx53: Fix regulator enable GPIO polarity
> > > ARM: dts: imx6q-dmo-edmqmx6: Fix regulator enable GPIO polarity
> >
> > Applied these 15 patches, thanks.
>
> There's ongoing discussions regarding whether this is the right thing to do.
> Please see http://www.spinics.net/lists/arm-kernel/msg451724.html. It's thus a
> bit early to apply the patches at this point I'm afraid.
Okay, dropped them except the first one which fixes a typo for
imx6sx-sdb.
Shawn
^ permalink raw reply [flat|nested] 90+ messages in thread
* [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
@ 2015-10-13 15:09 ` Shawn Guo
0 siblings, 0 replies; 90+ messages in thread
From: Shawn Guo @ 2015-10-13 15:09 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 13, 2015 at 05:17:24PM +0300, Laurent Pinchart wrote:
> Hi Shawn,
>
> On Tuesday 13 October 2015 22:09:46 Shawn Guo wrote:
> > On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote:
> > > Laurent Pinchart (37):
> > ...
> >
> > > ARM: imx6sx-sdb: Fix typo in regulator enable GPIO property
> >
> > ...
> >
> > > ARM: dts: imx6qdl-tx6: Fix regulator enable GPIO polarity
> >
> > ...
> >
> > > ARM: dts: imx23-evk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx23-stmp378x_devb: Fix regulator enable GPIO polarity
> > > ARM: dts: imx25-pdk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-cfa10036: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-evk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-m28cu3: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-m28evk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-sps1: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-tx28: Fix regulator enable GPIO polarity
> > > ARM: dts: imx53-m53evk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx53-mba53: Fix regulator enable GPIO polarity
> > > ARM: dts: imx53-tx53: Fix regulator enable GPIO polarity
> > > ARM: dts: imx6q-dmo-edmqmx6: Fix regulator enable GPIO polarity
> >
> > Applied these 15 patches, thanks.
>
> There's ongoing discussions regarding whether this is the right thing to do.
> Please see http://www.spinics.net/lists/arm-kernel/msg451724.html. It's thus a
> bit early to apply the patches at this point I'm afraid.
Okay, dropped them except the first one which fixes a typo for
imx6sx-sdb.
Shawn
^ permalink raw reply [flat|nested] 90+ messages in thread