From: Dave Chinner <david@fromorbit.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Matthew Wilcox <willy@linux.intel.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
linux-nvdimm@lists.01.org,
Matthew Wilcox <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH v5] mm, dax: fix DAX deadlocks
Date: Tue, 13 Oct 2015 09:53:27 +1100 [thread overview]
Message-ID: <20151012225327.GF27164@dastard> (raw)
In-Reply-To: <1444258729-21974-2-git-send-email-ross.zwisler@linux.intel.com>
On Wed, Oct 07, 2015 at 04:58:49PM -0600, Ross Zwisler wrote:
> The following two locking commits in the DAX code:
>
> commit 843172978bb9 ("dax: fix race between simultaneous faults")
> commit 46c043ede471 ("mm: take i_mmap_lock in unmap_mapping_range() for DAX")
>
> introduced a number of deadlocks and other issues which need to be fixed
> for the v4.3 kernel. The list of issues in DAX after these commits (some
> newly introduced by the commits, some preexisting) can be found here:
>
> https://lkml.org/lkml/2015/9/25/602
>
> This undoes most of the changes introduced by those two commits,
> essentially returning us to the DAX locking scheme that was used in v4.2.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
I've run this through some testing, the deadlocks aren't present and
there don't appear to be any new regressions, so IMO this is fine to
go to Linus.
Tested-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Matthew Wilcox <willy@linux.intel.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
linux-nvdimm@ml01.01.org,
Matthew Wilcox <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH v5] mm, dax: fix DAX deadlocks
Date: Tue, 13 Oct 2015 09:53:27 +1100 [thread overview]
Message-ID: <20151012225327.GF27164@dastard> (raw)
In-Reply-To: <1444258729-21974-2-git-send-email-ross.zwisler@linux.intel.com>
On Wed, Oct 07, 2015 at 04:58:49PM -0600, Ross Zwisler wrote:
> The following two locking commits in the DAX code:
>
> commit 843172978bb9 ("dax: fix race between simultaneous faults")
> commit 46c043ede471 ("mm: take i_mmap_lock in unmap_mapping_range() for DAX")
>
> introduced a number of deadlocks and other issues which need to be fixed
> for the v4.3 kernel. The list of issues in DAX after these commits (some
> newly introduced by the commits, some preexisting) can be found here:
>
> https://lkml.org/lkml/2015/9/25/602
>
> This undoes most of the changes introduced by those two commits,
> essentially returning us to the DAX locking scheme that was used in v4.2.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
I've run this through some testing, the deadlocks aren't present and
there don't appear to be any new regressions, so IMO this is fine to
go to Linus.
Tested-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2015-10-12 22:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 22:58 [PATCH v5] Fix DAX deadlocks for v4.3 Ross Zwisler
2015-10-07 22:58 ` Ross Zwisler
2015-10-07 22:58 ` Ross Zwisler
2015-10-07 22:58 ` [PATCH v5] mm, dax: fix DAX deadlocks Ross Zwisler
2015-10-07 22:58 ` Ross Zwisler
2015-10-12 22:53 ` Dave Chinner [this message]
2015-10-12 22:53 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012225327.GF27164@dastard \
--to=david@fromorbit.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=matthew.r.wilcox@intel.com \
--cc=ross.zwisler@linux.intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.