From: Ido Schimmel <idosch@mellanox.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: bridge@lists.linux-foundation.org,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
netdev@vger.kernel.org, roopa@cumulusnetworks.com,
shm@cumulusnetworks.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next v2 1/4] bridge: vlan: use proper rcu for the vlgrp member
Date: Tue, 13 Oct 2015 10:19:02 +0300 [thread overview]
Message-ID: <20151013071902.GB28618@colbert.mtl.com> (raw)
In-Reply-To: <1444679225-7354-2-git-send-email-razor@blackwall.org>
Mon, Oct 12, 2015 at 10:47:02PM IDT, razor@blackwall.org wrote:
>From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>
>The bridge and port's vlgrp member is already used in RCU way, currently
>we rely on the fact that it cannot disappear while the port exists but
>that is error-prone and we might miss places with improper locking
>(either RCU or RTNL must be held to walk the vlan_list). So make it
>official and use RCU for vlgrp to catch offenders. Introduce proper vlgrp
>accessors and use them consistently throughout the code.
>
>Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@mellanox.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: <netdev@vger.kernel.org>, <shm@cumulusnetworks.com>,
<roopa@cumulusnetworks.com>, <stephen@networkplumber.org>,
<bridge@lists.linux-foundation.org>, <davem@davemloft.net>,
"Nikolay Aleksandrov" <nikolay@cumulusnetworks.com>
Subject: Re: [PATCH net-next v2 1/4] bridge: vlan: use proper rcu for the vlgrp member
Date: Tue, 13 Oct 2015 10:19:02 +0300 [thread overview]
Message-ID: <20151013071902.GB28618@colbert.mtl.com> (raw)
In-Reply-To: <1444679225-7354-2-git-send-email-razor@blackwall.org>
Mon, Oct 12, 2015 at 10:47:02PM IDT, razor@blackwall.org wrote:
>From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>
>The bridge and port's vlgrp member is already used in RCU way, currently
>we rely on the fact that it cannot disappear while the port exists but
>that is error-prone and we might miss places with improper locking
>(either RCU or RTNL must be held to walk the vlan_list). So make it
>official and use RCU for vlgrp to catch offenders. Introduce proper vlgrp
>accessors and use them consistently throughout the code.
>
>Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
next prev parent reply other threads:[~2015-10-13 7:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 19:47 [Bridge] [PATCH net-next v2 0/4] bridge: vlan: cleanups & fixes (part 3) Nikolay Aleksandrov
2015-10-12 19:47 ` Nikolay Aleksandrov
2015-10-12 19:47 ` [Bridge] [PATCH net-next v2 1/4] bridge: vlan: use proper rcu for the vlgrp member Nikolay Aleksandrov
2015-10-12 19:47 ` Nikolay Aleksandrov
2015-10-13 7:19 ` Ido Schimmel [this message]
2015-10-13 7:19 ` Ido Schimmel
2015-10-12 19:47 ` [Bridge] [PATCH net-next v2 2/4] bridge: vlan: use rcu for vlan_list traversal in br_fill_ifinfo Nikolay Aleksandrov
2015-10-12 19:47 ` Nikolay Aleksandrov
2015-10-13 7:19 ` [Bridge] " Ido Schimmel
2015-10-13 7:19 ` Ido Schimmel
2015-10-12 19:47 ` [Bridge] [PATCH net-next v2 3/4] bridge: vlan: drop unnecessary flush code Nikolay Aleksandrov
2015-10-12 19:47 ` Nikolay Aleksandrov
2015-10-13 7:20 ` [Bridge] " Ido Schimmel
2015-10-13 7:20 ` Ido Schimmel
2015-10-12 19:47 ` [Bridge] [PATCH net-next v2 4/4] bridge: vlan: move back vlan_flush Nikolay Aleksandrov
2015-10-12 19:47 ` Nikolay Aleksandrov
2015-10-13 7:21 ` [Bridge] " Ido Schimmel
2015-10-13 7:21 ` Ido Schimmel
2015-10-13 11:58 ` [Bridge] [PATCH net-next v2 0/4] bridge: vlan: cleanups & fixes (part 3) David Miller
2015-10-13 11:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013071902.GB28618@colbert.mtl.com \
--to=idosch@mellanox.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=razor@blackwall.org \
--cc=roopa@cumulusnetworks.com \
--cc=shm@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.