From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Hui Zhu <zhuhui@xiaomi.com>
Cc: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
teawater@gmail.com,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] zsmalloc: remove unless line in obj_free
Date: Tue, 13 Oct 2015 17:00:44 +0900 [thread overview]
Message-ID: <20151013080044.GA587@swordfish> (raw)
In-Reply-To: <1444717862-27234-1-git-send-email-zhuhui@xiaomi.com>
On (10/13/15 14:31), Hui Zhu wrote:
> Signed-off-by: Hui Zhu <zhuhui@xiaomi.com>
s/unless/useless/
other than that
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
> ---
> mm/zsmalloc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index f135b1b..c7338f0 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -1428,8 +1428,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
> struct page *first_page, *f_page;
> unsigned long f_objidx, f_offset;
> void *vaddr;
> - int class_idx;
> - enum fullness_group fullness;
>
> BUG_ON(!obj);
>
> @@ -1437,7 +1435,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
> obj_to_location(obj, &f_page, &f_objidx);
> first_page = get_first_page(f_page);
>
> - get_zspage_mapping(first_page, &class_idx, &fullness);
> f_offset = obj_idx_to_offset(f_page, f_objidx, class->size);
>
> vaddr = kmap_atomic(f_page);
> --
> 1.9.1
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Hui Zhu <zhuhui@xiaomi.com>
Cc: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
teawater@gmail.com,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] zsmalloc: remove unless line in obj_free
Date: Tue, 13 Oct 2015 17:00:44 +0900 [thread overview]
Message-ID: <20151013080044.GA587@swordfish> (raw)
In-Reply-To: <1444717862-27234-1-git-send-email-zhuhui@xiaomi.com>
On (10/13/15 14:31), Hui Zhu wrote:
> Signed-off-by: Hui Zhu <zhuhui@xiaomi.com>
s/unless/useless/
other than that
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
> ---
> mm/zsmalloc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index f135b1b..c7338f0 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -1428,8 +1428,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
> struct page *first_page, *f_page;
> unsigned long f_objidx, f_offset;
> void *vaddr;
> - int class_idx;
> - enum fullness_group fullness;
>
> BUG_ON(!obj);
>
> @@ -1437,7 +1435,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class,
> obj_to_location(obj, &f_page, &f_objidx);
> first_page = get_first_page(f_page);
>
> - get_zspage_mapping(first_page, &class_idx, &fullness);
> f_offset = obj_idx_to_offset(f_page, f_objidx, class->size);
>
> vaddr = kmap_atomic(f_page);
> --
> 1.9.1
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
next prev parent reply other threads:[~2015-10-13 7:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 6:31 [PATCH] zsmalloc: remove unless line in obj_free Hui Zhu
2015-10-13 6:31 ` Hui Zhu
2015-10-13 8:00 ` Sergey Senozhatsky [this message]
2015-10-13 8:00 ` Sergey Senozhatsky
2015-10-13 9:06 ` Hui Zhu
2015-10-13 9:06 ` Hui Zhu
2015-10-13 9:07 ` [PATCH v2] zsmalloc: remove useless " Hui Zhu
2015-10-13 9:07 ` Hui Zhu
2015-10-14 0:31 ` Sergey Senozhatsky
2015-10-14 0:31 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013080044.GA587@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=teawater@gmail.com \
--cc=zhuhui@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.