All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Kukjin Kim <kgene@kernel.org>
Cc: 'Krzysztof Kozlowski' <k.kozlowski.k@gmail.com>,
	'Sangbeom Kim' <sbkim73@samsung.com>,
	'Krzysztof Kozlowski' <k.kozlowski@samsung.com>,
	'Samuel Ortiz' <sameo@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	'Anand Moon' <linux.amoon@gmail.com>,
	'Javier Martinez Canillas' <javier@osg.samsung.com>
Subject: Re: [PATCH v2 1/3] mfd: documentation: dt: Document grounded ACOKB pin on S2MPS11
Date: Tue, 13 Oct 2015 11:07:05 +0100	[thread overview]
Message-ID: <20151013100705.GY32409@x1> (raw)
In-Reply-To: <02a201d0d676$2fbe73c0$8f3b5b40$@kernel.org>

On Fri, 14 Aug 2015, Kukjin Kim wrote:

> Krzysztof Kozlowski wrote:
> > 
> > Document a new Device Tree property 'samsung,s2mps11-acokb-ground'
> > indicating that ACOKB pin of S2MPS11 PMIC is connected to the ground so
> > the PMIC must manually set PWRHOLD bit in CTRL1 register to turn off the
> > power.
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> > 
> > ---
> > 
> > Changes since v1:
> > 1. Split bindings documentation to separate patch (suggested by Lee).
> > 2. Add Javier's reviewed-by and Lee's acked-by.
> > ---
> >  Documentation/devicetree/bindings/mfd/s2mps11.txt | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt
> > b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> > index 57a045016fca..90eaef393325 100644
> > --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
> > +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> > @@ -15,6 +15,10 @@ Optional properties:
> >  - interrupt-parent: Specifies the phandle of the interrupt controller to which
> >    the interrupts from s2mps11 are delivered to.
> >  - interrupts: Interrupt specifiers for interrupt sources.
> > +- samsung,s2mps11-acokb-ground: Indicates that ACOKB pin of S2MPS11 PMIC is
> > +  connected to the ground so the PMIC must manually set PWRHOLD bit in CTRL1
> > +  register to turn off the power. Usually the ACOKB is pulled up to VBATT so
> > +  when PWRHOLD pin goes low, the rising ACOKB will trigger power off.
> > 
> >  Optional nodes:
> >  - clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768
> 
> Applied 1/3 and 3/3.

Any chance you applied these on their own branch (which can be
tagged)?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] mfd: documentation: dt: Document grounded ACOKB pin on S2MPS11
Date: Tue, 13 Oct 2015 11:07:05 +0100	[thread overview]
Message-ID: <20151013100705.GY32409@x1> (raw)
In-Reply-To: <02a201d0d676$2fbe73c0$8f3b5b40$@kernel.org>

On Fri, 14 Aug 2015, Kukjin Kim wrote:

> Krzysztof Kozlowski wrote:
> > 
> > Document a new Device Tree property 'samsung,s2mps11-acokb-ground'
> > indicating that ACOKB pin of S2MPS11 PMIC is connected to the ground so
> > the PMIC must manually set PWRHOLD bit in CTRL1 register to turn off the
> > power.
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> > 
> > ---
> > 
> > Changes since v1:
> > 1. Split bindings documentation to separate patch (suggested by Lee).
> > 2. Add Javier's reviewed-by and Lee's acked-by.
> > ---
> >  Documentation/devicetree/bindings/mfd/s2mps11.txt | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt
> > b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> > index 57a045016fca..90eaef393325 100644
> > --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
> > +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> > @@ -15,6 +15,10 @@ Optional properties:
> >  - interrupt-parent: Specifies the phandle of the interrupt controller to which
> >    the interrupts from s2mps11 are delivered to.
> >  - interrupts: Interrupt specifiers for interrupt sources.
> > +- samsung,s2mps11-acokb-ground: Indicates that ACOKB pin of S2MPS11 PMIC is
> > +  connected to the ground so the PMIC must manually set PWRHOLD bit in CTRL1
> > +  register to turn off the power. Usually the ACOKB is pulled up to VBATT so
> > +  when PWRHOLD pin goes low, the rising ACOKB will trigger power off.
> > 
> >  Optional nodes:
> >  - clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768
> 
> Applied 1/3 and 3/3.

Any chance you applied these on their own branch (which can be
tagged)?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2015-10-13 10:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 10:09 [PATCH v2 0/3] mfd: EXYNOS: Properly shutdown Odroid XU3 Krzysztof Kozlowski
2015-08-11 10:09 ` Krzysztof Kozlowski
2015-08-11 10:09 ` [PATCH v2 1/3] mfd: documentation: dt: Document grounded ACOKB pin on S2MPS11 Krzysztof Kozlowski
2015-08-11 10:09   ` Krzysztof Kozlowski
2015-08-14  9:47   ` Kukjin Kim
2015-08-14  9:47     ` Kukjin Kim
2015-10-13 10:07     ` Lee Jones [this message]
2015-10-13 10:07       ` Lee Jones
2015-08-11 10:09 ` [PATCH v2 2/3] mfd: s2mps11: Add manual shutdown method for Odroid XU3 Krzysztof Kozlowski
2015-08-11 10:09   ` Krzysztof Kozlowski
     [not found]   ` <1439287746-14034-3-git-send-email-k.kozlowski.k-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-13  2:43     ` Krzysztof Kozlowski
2015-09-13  2:43       ` Krzysztof Kozlowski
2015-09-13  2:43       ` Krzysztof Kozlowski
2015-09-14  8:12       ` Lee Jones
2015-09-14  8:12         ` Lee Jones
2015-08-11 10:09 ` [PATCH v2 3/3] ARM: dts: Fix power off method on exynos5422-odroidxu3 Krzysztof Kozlowski
2015-08-11 10:09   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151013100705.GY32409@x1 \
    --to=lee.jones@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=javier@osg.samsung.com \
    --cc=k.kozlowski.k@gmail.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux.amoon@gmail.com \
    --cc=sameo@linux.intel.com \
    --cc=sbkim73@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.