All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Lukasz Odzioba <lukasz.odzioba@intel.com>
Cc: fenghua.yu@intel.com, jdelvare@suse.de,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/1] Bumps limit of maximum core ID from 32 to 128.
Date: Tue, 13 Oct 2015 20:31:34 +0000	[thread overview]
Message-ID: <20151013203134.GA28106@roeck-us.net> (raw)
In-Reply-To: <1444650812-17398-1-git-send-email-lukasz.odzioba@intel.com>

On Mon, Oct 12, 2015 at 01:53:32PM +0200, Lukasz Odzioba wrote:
> A new limit selected arbitrarily as power of two greater than
> required minimum for Xeon Phi processor.
> 
> Currently driver is not able to handle cores with core ID greater than 32.
> Such attempt ends up with the following error in dmesg:
> coretemp coretemp.0: Adding Core XXX failed
> 

Why 128 instead of a more reasonable 64 ? What is the required minimum
for Xeon Phi ?

Also, please consider using the subject line commonly used in hwmon,
or at least point to the driver you are changing.

Thanks,
Guenter

> Signed-off-by: Lukasz Odzioba <lukasz.odzioba@intel.com>
> ---
>  drivers/hwmon/coretemp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index 3e03379..6a27eb2 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -52,7 +52,7 @@ module_param_named(tjmax, force_tjmax, int, 0444);
>  MODULE_PARM_DESC(tjmax, "TjMax value in degrees Celsius");
>  
>  #define BASE_SYSFS_ATTR_NO	2	/* Sysfs Base attr no for coretemp */
> -#define NUM_REAL_CORES		32	/* Number of Real cores per cpu */
> +#define NUM_REAL_CORES		128	/* Number of Real cores per cpu */
>  #define CORETEMP_NAME_LENGTH	19	/* String Length of attrs */
>  #define MAX_CORE_ATTRS		4	/* Maximum no of basic attrs */
>  #define TOTAL_ATTRS		(MAX_CORE_ATTRS + 1)
> -- 
> 1.7.1
> 

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Lukasz Odzioba <lukasz.odzioba@intel.com>
Cc: fenghua.yu@intel.com, jdelvare@suse.de,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Bumps limit of maximum core ID from 32 to 128.
Date: Tue, 13 Oct 2015 13:31:34 -0700	[thread overview]
Message-ID: <20151013203134.GA28106@roeck-us.net> (raw)
In-Reply-To: <1444650812-17398-1-git-send-email-lukasz.odzioba@intel.com>

On Mon, Oct 12, 2015 at 01:53:32PM +0200, Lukasz Odzioba wrote:
> A new limit selected arbitrarily as power of two greater than
> required minimum for Xeon Phi processor.
> 
> Currently driver is not able to handle cores with core ID greater than 32.
> Such attempt ends up with the following error in dmesg:
> coretemp coretemp.0: Adding Core XXX failed
> 

Why 128 instead of a more reasonable 64 ? What is the required minimum
for Xeon Phi ?

Also, please consider using the subject line commonly used in hwmon,
or at least point to the driver you are changing.

Thanks,
Guenter

> Signed-off-by: Lukasz Odzioba <lukasz.odzioba@intel.com>
> ---
>  drivers/hwmon/coretemp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index 3e03379..6a27eb2 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -52,7 +52,7 @@ module_param_named(tjmax, force_tjmax, int, 0444);
>  MODULE_PARM_DESC(tjmax, "TjMax value in degrees Celsius");
>  
>  #define BASE_SYSFS_ATTR_NO	2	/* Sysfs Base attr no for coretemp */
> -#define NUM_REAL_CORES		32	/* Number of Real cores per cpu */
> +#define NUM_REAL_CORES		128	/* Number of Real cores per cpu */
>  #define CORETEMP_NAME_LENGTH	19	/* String Length of attrs */
>  #define MAX_CORE_ATTRS		4	/* Maximum no of basic attrs */
>  #define TOTAL_ATTRS		(MAX_CORE_ATTRS + 1)
> -- 
> 1.7.1
> 

  reply	other threads:[~2015-10-13 20:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12 11:53 [lm-sensors] [PATCH 1/1] Bumps limit of maximum core ID from 32 to 128 Lukasz Odzioba
2015-10-12 11:53 ` Lukasz Odzioba
2015-10-13 20:31 ` Guenter Roeck [this message]
2015-10-13 20:31   ` Guenter Roeck
2015-10-13 21:05   ` [lm-sensors] " Phil Pokorny
2015-10-13 21:05     ` Phil Pokorny
2015-10-13 21:21     ` Guenter Roeck
2015-10-13 21:21       ` Guenter Roeck
2015-10-13 22:02   ` Odzioba, Lukasz
2015-10-13 22:02     ` Odzioba, Lukasz
2015-10-13 22:26     ` [lm-sensors] " Guenter Roeck
2015-10-13 22:26       ` Guenter Roeck
2015-10-13 22:45       ` [lm-sensors] " Odzioba, Lukasz
2015-10-13 22:45         ` Odzioba, Lukasz
2015-10-14  1:17 ` [lm-sensors] " Guenter Roeck
2015-10-14  1:17   ` Guenter Roeck
2015-10-14 11:39   ` [lm-sensors] " Odzioba, Lukasz
2015-10-14 11:39     ` Odzioba, Lukasz
2015-10-14 14:04     ` [lm-sensors] " Guenter Roeck
2015-10-14 14:04       ` Guenter Roeck
2015-10-15 22:08       ` [lm-sensors] " Odzioba, Lukasz
2015-10-15 22:08         ` Odzioba, Lukasz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151013203134.GA28106@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=fenghua.yu@intel.com \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=lukasz.odzioba@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.