All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: wilc1000: host_interface: Remove unused enum
@ 2015-10-13 20:47 Shivani Bhardwaj
  2015-10-13 21:39 ` [Outreachy kernel] " Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Shivani Bhardwaj @ 2015-10-13 20:47 UTC (permalink / raw)
  To: outreachy-kernel

Remove unused enum scan_conn_timer and its occurences as it is not used
anywhere in the code.

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/staging/wilc1000/host_interface.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 73f99ea..37684fd 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -436,11 +436,6 @@ struct join_bss_param {
 	u8 au8StartTime[4];
 };
 
-enum scan_conn_timer {
-	SCAN_TIMER = 0,
-	CONNECT_TIMER	= 1,
-	SCAN_CONNECT_TIMER_FORCE_32BIT = 0xFFFFFFFF
-};
 
 /*****************************************************************************/
 /*																			 */
@@ -4766,7 +4761,6 @@ s32 host_int_set_join_req(struct host_if_drv *hif_drv, u8 *pu8bssid,
 {
 	s32 s32Error = 0;
 	struct host_if_msg msg;
-	enum scan_conn_timer enuScanConnTimer;
 
 	if (!hif_drv || pfConnectResult == NULL) {
 		s32Error = -EFAULT;
@@ -4824,7 +4818,6 @@ s32 host_int_set_join_req(struct host_if_drv *hif_drv, u8 *pu8bssid,
 		return -EFAULT;
 	}
 
-	enuScanConnTimer = CONNECT_TIMER;
 	hif_drv->hConnectTimer.data = (unsigned long)hif_drv;
 	mod_timer(&hif_drv->hConnectTimer,
 		  jiffies + msecs_to_jiffies(HOST_IF_CONNECT_TIMEOUT));
@@ -5406,7 +5399,6 @@ s32 host_int_scan(struct host_if_drv *hif_drv, u8 u8ScanSource,
 {
 	s32 s32Error = 0;
 	struct host_if_msg msg;
-	enum scan_conn_timer enuScanConnTimer;
 
 	if (!hif_drv || ScanResult == NULL) {
 		PRINT_ER("hif_drv or ScanResult = NULL\n");
@@ -5448,7 +5440,6 @@ s32 host_int_scan(struct host_if_drv *hif_drv, u8 u8ScanSource,
 		return -EINVAL;
 	}
 
-	enuScanConnTimer = SCAN_TIMER;
 	PRINT_D(HOSTINF_DBG, ">> Starting the SCAN timer\n");
 	hif_drv->hScanTimer.data = (unsigned long)hif_drv;
 	mod_timer(&hif_drv->hScanTimer,
-- 
2.1.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel] [PATCH] Staging: wilc1000: host_interface: Remove unused enum
  2015-10-13 20:47 [PATCH] Staging: wilc1000: host_interface: Remove unused enum Shivani Bhardwaj
@ 2015-10-13 21:39 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-10-13 21:39 UTC (permalink / raw)
  To: Shivani Bhardwaj; +Cc: outreachy-kernel

On Wed, Oct 14, 2015 at 02:17:27AM +0530, Shivani Bhardwaj wrote:
> Remove unused enum scan_conn_timer and its occurences as it is not used
> anywhere in the code.
> 
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  drivers/staging/wilc1000/host_interface.c | 9 ---------
>  1 file changed, 9 deletions(-)

There is too much "fuzz" to apply this properly, which means this hasn't
been made against my latest branch, please rebase your patch and resend.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-13 21:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-13 20:47 [PATCH] Staging: wilc1000: host_interface: Remove unused enum Shivani Bhardwaj
2015-10-13 21:39 ` [Outreachy kernel] " Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.