* [PATCH] Staging: sm750fb: sm750: Remove unused code @ 2015-10-13 21:11 Shivani Bhardwaj 2015-10-13 21:21 ` [Outreachy kernel] " Julia Lawall 0 siblings, 1 reply; 4+ messages in thread From: Shivani Bhardwaj @ 2015-10-13 21:11 UTC (permalink / raw) To: outreachy-kernel Remove declaration and a statement comprising of a variable which is not used throughout the code. Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> --- drivers/staging/sm750fb/sm750.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 8c1ecb3..805a403 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -524,14 +524,12 @@ static int lynxfb_ops_check_var(struct fb_var_screeninfo *var, struct lynxfb_crtc *crtc; struct lynxfb_output *output; struct lynx_share *share; - int ret; resource_size_t request; par = info->par; crtc = &par->crtc; output = &par->output; share = par->share; - ret = 0; pr_debug("check var:%dx%d-%d\n", var->xres, -- 2.1.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: sm750fb: sm750: Remove unused code 2015-10-13 21:11 [PATCH] Staging: sm750fb: sm750: Remove unused code Shivani Bhardwaj @ 2015-10-13 21:21 ` Julia Lawall 2015-10-13 21:27 ` Shivani Bhardwaj 0 siblings, 1 reply; 4+ messages in thread From: Julia Lawall @ 2015-10-13 21:21 UTC (permalink / raw) To: Shivani Bhardwaj; +Cc: outreachy-kernel On Wed, 14 Oct 2015, Shivani Bhardwaj wrote: > Remove declaration and a statement comprising of a variable which is not > used throughout the code. This could be a little more helpful to the reader. The variable ret is only declared and initialized to 0, but never referenced, so remove it. Ret is a common variable name, so mentioning it conveys some information. julia > Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> > --- > drivers/staging/sm750fb/sm750.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c > index 8c1ecb3..805a403 100644 > --- a/drivers/staging/sm750fb/sm750.c > +++ b/drivers/staging/sm750fb/sm750.c > @@ -524,14 +524,12 @@ static int lynxfb_ops_check_var(struct fb_var_screeninfo *var, > struct lynxfb_crtc *crtc; > struct lynxfb_output *output; > struct lynx_share *share; > - int ret; > resource_size_t request; > > par = info->par; > crtc = &par->crtc; > output = &par->output; > share = par->share; > - ret = 0; > > pr_debug("check var:%dx%d-%d\n", > var->xres, > -- > 2.1.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151013211140.GA12128%40ubuntu. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: sm750fb: sm750: Remove unused code 2015-10-13 21:21 ` [Outreachy kernel] " Julia Lawall @ 2015-10-13 21:27 ` Shivani Bhardwaj 2015-10-13 21:29 ` Julia Lawall 0 siblings, 1 reply; 4+ messages in thread From: Shivani Bhardwaj @ 2015-10-13 21:27 UTC (permalink / raw) To: Julia Lawall; +Cc: outreachy-kernel On Wed, Oct 14, 2015 at 2:51 AM, Julia Lawall <julia.lawall@lip6.fr> wrote: > On Wed, 14 Oct 2015, Shivani Bhardwaj wrote: > >> Remove declaration and a statement comprising of a variable which is not >> used throughout the code. > > This could be a little more helpful to the reader. > > The variable ret is only declared and initialized to 0, but never > referenced, so remove it. > > Ret is a common variable name, so mentioning it conveys some information. > > julia > v2 with updated commit message? Thank you. >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> >> --- >> drivers/staging/sm750fb/sm750.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c >> index 8c1ecb3..805a403 100644 >> --- a/drivers/staging/sm750fb/sm750.c >> +++ b/drivers/staging/sm750fb/sm750.c >> @@ -524,14 +524,12 @@ static int lynxfb_ops_check_var(struct fb_var_screeninfo *var, >> struct lynxfb_crtc *crtc; >> struct lynxfb_output *output; >> struct lynx_share *share; >> - int ret; >> resource_size_t request; >> >> par = info->par; >> crtc = &par->crtc; >> output = &par->output; >> share = par->share; >> - ret = 0; >> >> pr_debug("check var:%dx%d-%d\n", >> var->xres, >> -- >> 2.1.0 >> >> -- >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. >> To post to this group, send email to outreachy-kernel@googlegroups.com. >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151013211140.GA12128%40ubuntu. >> For more options, visit https://groups.google.com/d/optout. >> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: sm750fb: sm750: Remove unused code 2015-10-13 21:27 ` Shivani Bhardwaj @ 2015-10-13 21:29 ` Julia Lawall 0 siblings, 0 replies; 4+ messages in thread From: Julia Lawall @ 2015-10-13 21:29 UTC (permalink / raw) To: Shivani Bhardwaj; +Cc: Julia Lawall, outreachy-kernel On Wed, 14 Oct 2015, Shivani Bhardwaj wrote: > On Wed, Oct 14, 2015 at 2:51 AM, Julia Lawall <julia.lawall@lip6.fr> wrote: > > On Wed, 14 Oct 2015, Shivani Bhardwaj wrote: > > > >> Remove declaration and a statement comprising of a variable which is not > >> used throughout the code. > > > > This could be a little more helpful to the reader. > > > > The variable ret is only declared and initialized to 0, but never > > referenced, so remove it. > > > > Ret is a common variable name, so mentioning it conveys some information. > > > > julia > > > > v2 with updated commit message? For practicing, it could be a good idea. julia > Thank you. > > >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> > >> --- > >> drivers/staging/sm750fb/sm750.c | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c > >> index 8c1ecb3..805a403 100644 > >> --- a/drivers/staging/sm750fb/sm750.c > >> +++ b/drivers/staging/sm750fb/sm750.c > >> @@ -524,14 +524,12 @@ static int lynxfb_ops_check_var(struct fb_var_screeninfo *var, > >> struct lynxfb_crtc *crtc; > >> struct lynxfb_output *output; > >> struct lynx_share *share; > >> - int ret; > >> resource_size_t request; > >> > >> par = info->par; > >> crtc = &par->crtc; > >> output = &par->output; > >> share = par->share; > >> - ret = 0; > >> > >> pr_debug("check var:%dx%d-%d\n", > >> var->xres, > >> -- > >> 2.1.0 > >> > >> -- > >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > >> To post to this group, send email to outreachy-kernel@googlegroups.com. > >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151013211140.GA12128%40ubuntu. > >> For more options, visit https://groups.google.com/d/optout. > >> > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAKHNQQFuxc%3DRCSeAgSMZeTPj-Q5QkzkW0T1LupqdR63%3DjcYF3w%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-13 21:29 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-10-13 21:11 [PATCH] Staging: sm750fb: sm750: Remove unused code Shivani Bhardwaj 2015-10-13 21:21 ` [Outreachy kernel] " Julia Lawall 2015-10-13 21:27 ` Shivani Bhardwaj 2015-10-13 21:29 ` Julia Lawall
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.