All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Zhiqiang Hou <B48286@freescale.com>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
	will.deacon@arm.com, linux-i2c@vger.kernel.org,
	linux-watchdog@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-clk@vger.kernel.org, Mingkai.Hu@freescale.com,
	Shaohui.Xie@freescale.com, scottwood@freescale.com,
	bhupesh.sharma@freescale.com, leoli@freescale.com,
	wsa@the-dreams.de, wim@iguana.be, corbet@lwn.net,
	mturquette@baylibre.com, sboyd@codeaurora.org,
	Wenbin.Song@freescale.com
Subject: Re: [PATCH V3 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
Date: Wed, 14 Oct 2015 13:43:53 +0100	[thread overview]
Message-ID: <20151014124353.GC2150@leverpostej> (raw)
In-Reply-To: <1444822498-16477-5-git-send-email-B48286@freescale.com>

Hi,

> +	pmu {
> +		compatible = "arm,armv8-pmuv3";
> +		interrupts = <0 106 0x4>,
> +			     <0 107 0x4>,
> +			     <0 95 0x4>,
> +			     <0 97 0x4>;
> +	};

You should have interrupt-affinity here. See
Documentation/devicetree/bindings/arm/pmu.txt

Otherwise this looks ok.

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: Zhiqiang Hou <B48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	catalin.marinas-5wv7dgnIgG8@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Mingkai.Hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	Shaohui.Xie-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	bhupesh.sharma-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	leoli-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
	wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org,
	corbet-T1hC0tSOHrs@public.gmane.org,
	mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
	sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	Wenbin.Song-KZfg59tc24xl57MIdRCFDg@public.gmane.org
Subject: Re: [PATCH V3 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
Date: Wed, 14 Oct 2015 13:43:53 +0100	[thread overview]
Message-ID: <20151014124353.GC2150@leverpostej> (raw)
In-Reply-To: <1444822498-16477-5-git-send-email-B48286-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

Hi,

> +	pmu {
> +		compatible = "arm,armv8-pmuv3";
> +		interrupts = <0 106 0x4>,
> +			     <0 107 0x4>,
> +			     <0 95 0x4>,
> +			     <0 97 0x4>;
> +	};

You should have interrupt-affinity here. See
Documentation/devicetree/bindings/arm/pmu.txt

Otherwise this looks ok.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC
Date: Wed, 14 Oct 2015 13:43:53 +0100	[thread overview]
Message-ID: <20151014124353.GC2150@leverpostej> (raw)
In-Reply-To: <1444822498-16477-5-git-send-email-B48286@freescale.com>

Hi,

> +	pmu {
> +		compatible = "arm,armv8-pmuv3";
> +		interrupts = <0 106 0x4>,
> +			     <0 107 0x4>,
> +			     <0 95 0x4>,
> +			     <0 97 0x4>;
> +	};

You should have interrupt-affinity here. See
Documentation/devicetree/bindings/arm/pmu.txt

Otherwise this looks ok.

Thanks,
Mark.

  reply	other threads:[~2015-10-14 12:43 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 11:34 [PATCH V3 0/6] Add LS1043A SoC support Zhiqiang Hou
2015-10-14 11:34 ` Zhiqiang Hou
2015-10-14 11:34 ` Zhiqiang Hou
2015-10-14 11:34 ` [PATCH V3 1/6] i2c: Add i2c support to Freescale Layerscape platforms Zhiqiang Hou
2015-10-14 11:34   ` Zhiqiang Hou
2015-10-14 11:34   ` Zhiqiang Hou
2015-10-14 11:34 ` [PATCH V3 2/6] watchdog: Add support for " Zhiqiang Hou
2015-10-14 11:34   ` Zhiqiang Hou
2015-10-14 11:34   ` Zhiqiang Hou
2015-10-14 14:06   ` Guenter Roeck
2015-10-14 14:06     ` Guenter Roeck
2015-10-14 11:34 ` [PATCH V3 3/6] Documentation: DT: Add entry for FSL LS1043ARDB board Zhiqiang Hou
2015-10-14 11:34   ` Zhiqiang Hou
2015-10-14 11:34   ` Zhiqiang Hou
2015-10-14 11:34 ` [PATCH V3 4/6] arm64/ls1043a: add DTS for Freescale LS1043A SoC Zhiqiang Hou
2015-10-14 11:34   ` Zhiqiang Hou
2015-10-14 11:34   ` Zhiqiang Hou
2015-10-14 12:43   ` Mark Rutland [this message]
2015-10-14 12:43     ` Mark Rutland
2015-10-14 12:43     ` Mark Rutland
2015-10-15  3:32     ` Hou Zhiqiang
2015-10-15  3:32       ` Hou Zhiqiang
2015-10-15  3:32       ` Hou Zhiqiang
2015-10-15  3:56   ` Scott Wood
2015-10-15  3:56     ` Scott Wood
2015-10-15  3:56     ` Scott Wood
2015-10-15  7:34     ` Hou Zhiqiang
2015-10-15  7:34       ` Hou Zhiqiang
2015-10-15  7:34       ` Hou Zhiqiang
2015-10-15  7:34       ` Hou Zhiqiang
2015-10-14 11:34 ` [PATCH V3 5/6] clk: qoriq: Add ls1043a support Zhiqiang Hou
2015-10-14 11:34   ` Zhiqiang Hou
2015-10-14 11:34   ` Zhiqiang Hou
2015-10-14 18:31   ` Stephen Boyd
2015-10-14 18:31     ` Stephen Boyd
2015-10-15  0:57     ` Scott Wood
2015-10-15  0:57       ` Scott Wood
2015-10-15  0:57       ` Scott Wood
2015-10-15 19:54       ` Stephen Boyd
2015-10-15 19:54         ` Stephen Boyd
2015-12-14 23:32         ` Scott Wood
2015-12-14 23:32           ` Scott Wood
2015-12-14 23:32           ` Scott Wood
2015-10-14 11:34 ` [PATCH V3 6/6] dts/ls1043a: add LS1043ARDB board support Zhiqiang Hou
2015-10-14 11:34   ` Zhiqiang Hou
2015-10-14 11:34   ` Zhiqiang Hou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151014124353.GC2150@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=B48286@freescale.com \
    --cc=Mingkai.Hu@freescale.com \
    --cc=Shaohui.Xie@freescale.com \
    --cc=Wenbin.Song@freescale.com \
    --cc=bhupesh.sharma@freescale.com \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=leoli@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --cc=scottwood@freescale.com \
    --cc=will.deacon@arm.com \
    --cc=wim@iguana.be \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.