Re: [RFC 1/5] clk: iproc: define Broadcom NSP iProc clock binding

[Jon Mason <jonmason@broadcom.com>]

On Tue, Oct 13, 2015 at 03:17:36PM -0700, Ray Jui wrote:
> Shouldn't the device tree binding document go with the other patch
> series since both the binding document and drivers are merged by Michael
> or Stephen?
> 
> On 10/13/2015 2:22 PM, Jon Mason wrote:
> > Document the device tree bindings for Broadcom Northstar Plus
> > architecture based clock controller
> > 
> > Signed-off-by: Jon Mason <jonmason@broadcom.com>
> > ---
> >  .../bindings/clock/brcm,iproc-clocks.txt           | 30 ++++++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.txt b/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.txt
> > index da8d9bb..b3c3e9d 100644
> > --- a/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.txt
> > +++ b/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.txt
> > @@ -130,3 +130,33 @@ These clock IDs are defined in:
> >      ch3_unused mipipll          4       BCM_CYGNUS_MIPIPLL_CH3_UNUSED
> >      ch4_unused mipipll          5       BCM_CYGNUS_MIPIPLL_CH4_UNUSED
> >      ch5_unused mipipll          6       BCM_CYGNUS_MIPIPLL_CH5_UNUSED
> > +
> > +Northstar and Northstar Plus
> > +------
> > +PLL and leaf clock compatible strings for Northstar and Northstar Plus are:
> > + "brcm,nsp-armpll"
> > + "brcm,nsp-genpll"
> > + "brcm,nsp-lcpll0"
> 
> So the current clock driver also supports NS? That will be nice and that
> indicates all the clock related registers/offsets are exactly the same
> between NS and NSP?

Yes.  The register offsets are different, but everything else is
identical.

> 
> > +
> > +The following table defines the set of PLL/clock index and ID for Northstar and
> > +Northstar Plus.  These clock IDs are defined in:
> > +    "include/dt-bindings/clock/bcm-nsp.h"
> > +
> > +    Clock	Source		Index	ID
> > +    ---		-----		-----	---------
> > +    crystal	N/A		N/A	N/A
> > +
> > +    armpll	crystal		N/A	N/A
> > +
> > +    genpll	crystal		0	BCM_NSP_GENPLL
> > +    phy		genpll		1	BCM_NSP_GENPLL_PHY_CLK
> > +    ethernetclk	genpll		2	BCM_NSP_GENPLL_ENET_SW_CLK
> > +    usbclk	genpll		3	BCM_NSP_GENPLL_USB_PHY_REF_CLK
> > +    iprocfast	genpll		4	BCM_NSP_GENPLL_IPROCFAST_CLK
> > +    sata1	genpll		5	BCM_NSP_GENPLL_SATA1_CLK
> > +    sata2	genpll		6	BCM_NSP_GENPLL_SATA2_CLK
> > +
> > +    lcpll0	crystal		0	BCM_NSP_LCPLL0
> > +    pcie_phy	lcpll0		1	BCM_NSP_LCPLL0_PCIE_PHY_REF_CLK
> > +    sdio	lcpll0		2	BCM_NSP_LCPLL0_SDIO_CLK
> > +    ddr_phy	lcpll0		3	BCM_NSP_LCPLL0_DDR_PHY_CLK
> >