From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Nikhil Rao <nikhil.rao@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] misc: mic/scif: fix wrap around tests
Date: Wed, 14 Oct 2015 18:05:41 +0000 [thread overview]
Message-ID: <20151014180541.GO7289@mwanda> (raw)
In-Reply-To: <1444792884.93285.276.camel@localhost>
On Tue, Oct 13, 2015 at 08:21:24PM -0700, Sudeep Dutt wrote:
> > @@ -1613,7 +1613,7 @@ off_t scif_register(scif_epd_t epd, void *addr, size_t len, off_t offset,
> > if ((map_flags & SCIF_MAP_FIXED) &&
> > ((ALIGN(offset, PAGE_SIZE) != offset) ||
> > (offset < 0) ||
> > - (offset + (off_t)len < offset)))
> > + (len < LONG_MAX - offset)))
>
> Hi Dan,
> Should this be > instead of < like the others?
Gar. You're right, obviously. Thanks. I will resend tomorrow.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Nikhil Rao <nikhil.rao@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] misc: mic/scif: fix wrap around tests
Date: Wed, 14 Oct 2015 21:05:41 +0300 [thread overview]
Message-ID: <20151014180541.GO7289@mwanda> (raw)
In-Reply-To: <1444792884.93285.276.camel@localhost>
On Tue, Oct 13, 2015 at 08:21:24PM -0700, Sudeep Dutt wrote:
> > @@ -1613,7 +1613,7 @@ off_t scif_register(scif_epd_t epd, void *addr, size_t len, off_t offset,
> > if ((map_flags & SCIF_MAP_FIXED) &&
> > ((ALIGN(offset, PAGE_SIZE) != offset) ||
> > (offset < 0) ||
> > - (offset + (off_t)len < offset)))
> > + (len < LONG_MAX - offset)))
>
> Hi Dan,
> Should this be > instead of < like the others?
Gar. You're right, obviously. Thanks. I will resend tomorrow.
regards,
dan carpenter
next prev parent reply other threads:[~2015-10-14 18:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 6:40 [patch 2/2] misc: mic/scif: fix wrap around tests Dan Carpenter
2015-10-09 6:40 ` Dan Carpenter
2015-10-11 9:14 ` Sudeep Dutt
2015-10-11 9:14 ` Sudeep Dutt
2015-10-13 12:51 ` Dan Carpenter
2015-10-13 12:51 ` Dan Carpenter
2015-10-14 3:21 ` Sudeep Dutt
2015-10-14 3:21 ` Sudeep Dutt
2015-10-14 18:05 ` Dan Carpenter [this message]
2015-10-14 18:05 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151014180541.GO7289@mwanda \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhil.rao@intel.com \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.