* [PATCH] Add USB hooks into NanoBone DTS file
@ 2015-10-14 13:30 ` Mark Jackson
0 siblings, 0 replies; 5+ messages in thread
From: Mark Jackson @ 2015-10-14 13:30 UTC (permalink / raw)
To: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: lkml, devicetree, Tony Lindgren, Russell King,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Add USB hooks into NanoBone DTS file
Signed-off-by: Mark Jackson <mpfj-2FZW7xY0fHgqdlJmJB21zg@public.gmane.org>
---
arch/arm/boot/dts/am335x-nano.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-nano.dts b/arch/arm/boot/dts/am335x-nano.dts
index 5ed4ca6..b86937a 100644
--- a/arch/arm/boot/dts/am335x-nano.dts
+++ b/arch/arm/boot/dts/am335x-nano.dts
@@ -375,6 +375,23 @@
wp-gpios = <&gpio3 18 0>;
};
+&usb {
+ status = "okay";
+};
+
+&usb_ctrl_mod {
+ status = "okay";
+};
+
+&usb0_phy {
+ status = "okay";
+};
+
+&usb0 {
+ status = "okay";
+ dr_mode = "host";
+};
+
#include "tps65217.dtsi"
&tps {
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] Add USB hooks into NanoBone DTS file
@ 2015-10-14 13:30 ` Mark Jackson
0 siblings, 0 replies; 5+ messages in thread
From: Mark Jackson @ 2015-10-14 13:30 UTC (permalink / raw)
To: linux-arm-kernel
Add USB hooks into NanoBone DTS file
Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
---
arch/arm/boot/dts/am335x-nano.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-nano.dts b/arch/arm/boot/dts/am335x-nano.dts
index 5ed4ca6..b86937a 100644
--- a/arch/arm/boot/dts/am335x-nano.dts
+++ b/arch/arm/boot/dts/am335x-nano.dts
@@ -375,6 +375,23 @@
wp-gpios = <&gpio3 18 0>;
};
+&usb {
+ status = "okay";
+};
+
+&usb_ctrl_mod {
+ status = "okay";
+};
+
+&usb0_phy {
+ status = "okay";
+};
+
+&usb0 {
+ status = "okay";
+ dr_mode = "host";
+};
+
#include "tps65217.dtsi"
&tps {
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] Add USB hooks into NanoBone DTS file
@ 2015-10-14 13:30 ` Mark Jackson
0 siblings, 0 replies; 5+ messages in thread
From: Mark Jackson @ 2015-10-14 13:30 UTC (permalink / raw)
To: linux-omap@vger.kernel.org
Cc: lkml, devicetree, Tony Lindgren, Russell King,
linux-arm-kernel@lists.infradead.org
Add USB hooks into NanoBone DTS file
Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
---
arch/arm/boot/dts/am335x-nano.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-nano.dts b/arch/arm/boot/dts/am335x-nano.dts
index 5ed4ca6..b86937a 100644
--- a/arch/arm/boot/dts/am335x-nano.dts
+++ b/arch/arm/boot/dts/am335x-nano.dts
@@ -375,6 +375,23 @@
wp-gpios = <&gpio3 18 0>;
};
+&usb {
+ status = "okay";
+};
+
+&usb_ctrl_mod {
+ status = "okay";
+};
+
+&usb0_phy {
+ status = "okay";
+};
+
+&usb0 {
+ status = "okay";
+ dr_mode = "host";
+};
+
#include "tps65217.dtsi"
&tps {
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Add USB hooks into NanoBone DTS file
2015-10-14 13:30 ` Mark Jackson
@ 2015-10-14 19:23 ` Tony Lindgren
-1 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2015-10-14 19:23 UTC (permalink / raw)
To: Mark Jackson
Cc: linux-omap@vger.kernel.org, lkml, devicetree, Russell King,
linux-arm-kernel@lists.infradead.org
* Mark Jackson <mpfj@newflow.co.uk> [151014 06:35]:
> Add USB hooks into NanoBone DTS file
Hmm looking at things, we really should not set status = "disabled"
for any of the internal devices. Setting "disabled" makes the kernel
completely ignore the device and we're better off from PM point of
view to probe and idle the device. The devices are there for sure, and
typically just the pins are not configured for them.
How about just remove the status = "disabled" from am33xx.dtsi
instead?
Regards,
Tony
> Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
> ---
> arch/arm/boot/dts/am335x-nano.dts | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am335x-nano.dts b/arch/arm/boot/dts/am335x-nano.dts
> index 5ed4ca6..b86937a 100644
> --- a/arch/arm/boot/dts/am335x-nano.dts
> +++ b/arch/arm/boot/dts/am335x-nano.dts
> @@ -375,6 +375,23 @@
> wp-gpios = <&gpio3 18 0>;
> };
>
> +&usb {
> + status = "okay";
> +};
> +
> +&usb_ctrl_mod {
> + status = "okay";
> +};
> +
> +&usb0_phy {
> + status = "okay";
> +};
> +
> +&usb0 {
> + status = "okay";
> + dr_mode = "host";
> +};
> +
> #include "tps65217.dtsi"
>
> &tps {
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Add USB hooks into NanoBone DTS file
@ 2015-10-14 19:23 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2015-10-14 19:23 UTC (permalink / raw)
To: linux-arm-kernel
* Mark Jackson <mpfj@newflow.co.uk> [151014 06:35]:
> Add USB hooks into NanoBone DTS file
Hmm looking at things, we really should not set status = "disabled"
for any of the internal devices. Setting "disabled" makes the kernel
completely ignore the device and we're better off from PM point of
view to probe and idle the device. The devices are there for sure, and
typically just the pins are not configured for them.
How about just remove the status = "disabled" from am33xx.dtsi
instead?
Regards,
Tony
> Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
> ---
> arch/arm/boot/dts/am335x-nano.dts | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am335x-nano.dts b/arch/arm/boot/dts/am335x-nano.dts
> index 5ed4ca6..b86937a 100644
> --- a/arch/arm/boot/dts/am335x-nano.dts
> +++ b/arch/arm/boot/dts/am335x-nano.dts
> @@ -375,6 +375,23 @@
> wp-gpios = <&gpio3 18 0>;
> };
>
> +&usb {
> + status = "okay";
> +};
> +
> +&usb_ctrl_mod {
> + status = "okay";
> +};
> +
> +&usb0_phy {
> + status = "okay";
> +};
> +
> +&usb0 {
> + status = "okay";
> + dr_mode = "host";
> +};
> +
> #include "tps65217.dtsi"
>
> &tps {
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-14 19:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-14 13:30 [PATCH] Add USB hooks into NanoBone DTS file Mark Jackson
2015-10-14 13:30 ` Mark Jackson
2015-10-14 13:30 ` Mark Jackson
2015-10-14 19:23 ` Tony Lindgren
2015-10-14 19:23 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.