From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Cristina Moraru <cristina.moraru09@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: dgnc: Fix lines over 80 characters
Date: Thu, 15 Oct 2015 12:15:46 +0530 [thread overview]
Message-ID: <20151015064546.GA3134@sudip-pc> (raw)
In-Reply-To: <1444854375-22873-1-git-send-email-cristina.moraru09@gmail.com>
On Wed, Oct 14, 2015 at 11:26:15PM +0300, Cristina Moraru wrote:
> Fix 'line over 80 characters' checkpatch.pl
> warnings
>
> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_driver.h | 58 ++++++++++++++++++++++++++------------
> 1 file changed, 40 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index c61884c..ce7cd9b 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -61,7 +61,9 @@
> #define PORT_NUM(dev) ((dev) & 0x7f)
> #define IS_PRINT(dev) (((dev) & 0xff) >= 0x80)
>
> -/* MAX number of stop characters we will send when our read queue is getting full */
> +/* MAX number of stop characters we will send
> + * when our read queue is getting full
> + */
> #define MAX_STOPS_SENT 5
>
> /* 4 extra for alignment play space */
> @@ -165,12 +167,15 @@ struct dgnc_board {
> uint maxports; /* MAX ports this board can handle */
> unsigned char dvid; /* Board specific device id */
> unsigned char vpd[128]; /* VPD of board, if found */
> - unsigned char serial_num[20]; /* Serial number of board, if found in VPD */
> + unsigned char serial_num[20]; /* Serial number of board,
> + * if found in VPD
> + */
>
> spinlock_t bd_lock; /* Used to protect board */
>
> - spinlock_t bd_intr_lock; /* Used to protect the poller tasklet and
> - * the interrupt routine from each other.
> + spinlock_t bd_intr_lock; /* Used to protect the poller tasklet
> + * and the interrupt routine from each
> + * other.
> */
This is not the multiline comment style. It should be:
/*
* Used to protect the poller tasklet
* and the interrupt routine from each
* other.
*/
regards
sudip
next prev parent reply other threads:[~2015-10-15 6:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 20:26 [PATCH] staging: dgnc: Fix lines over 80 characters Cristina Moraru
2015-10-15 6:45 ` Sudip Mukherjee [this message]
2015-10-15 16:10 ` [Outreachy kernel] " Julia Lawall
2015-10-26 15:53 ` Sudip Mukherjee
2015-10-26 16:02 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015064546.GA3134@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=cristina.moraru09@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.