All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Cristina Moraru <cristina.moraru09@gmail.com>,
	outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: dgnc: Fix lines over 80 characters
Date: Mon, 26 Oct 2015 21:23:42 +0530	[thread overview]
Message-ID: <20151026155342.GA31787@sudip-pc> (raw)
In-Reply-To: <alpine.DEB.2.10.1510151808510.2350@hadrien>

On Thu, Oct 15, 2015 at 06:10:11PM +0200, Julia Lawall wrote:
> > >
> > > -	spinlock_t	bd_intr_lock;	/* Used to protect the poller tasklet and
> > > -					 * the interrupt routine from each other.
> > > +	spinlock_t	bd_intr_lock;	/* Used to protect the poller tasklet
> > > +					 * and the interrupt routine from each
> > > +					 * other.
> > >  					 */
> > This is not the multiline comment style. It should be:
> >
> > /*
> >  * Used to protect the poller tasklet
> >  * and the interrupt routine from each
> >  * other.
> >  */
> 
> Not sure what you are suggesting.  If you think that the comment should be
> moved over to the leftmost column, then there is no need for so many
> newlines.  But maybe it would look odd with some comments on the far left
> and some to the right of the declarations?
> 
Hi Julia,
Sorry for the confusion. I was just suggesting about the multiline
comment style. It should have been:

 - spinlock_t      bd_intr_lock;   /* Used to protect the poller tasklet and
 - 				    * the interrupt routine from each other.
 + spinlock_t 	   bd_intr_lock;   /*
 + 				    * Used to protect the poller tasklet
 +				    * and the interrupt routine from each
 +				    * other.
                                    */

Regards
sudip



  reply	other threads:[~2015-10-26 15:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 20:26 [PATCH] staging: dgnc: Fix lines over 80 characters Cristina Moraru
2015-10-15  6:45 ` [Outreachy kernel] " Sudip Mukherjee
2015-10-15 16:10   ` Julia Lawall
2015-10-26 15:53     ` Sudip Mukherjee [this message]
2015-10-26 16:02       ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151026155342.GA31787@sudip-pc \
    --to=sudipm.mukherjee@gmail.com \
    --cc=cristina.moraru09@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.