[PATCH] Staging: most: cdev: Remove unnecessary check

[PATCH] Staging: most: cdev: Remove unnecessary check

[Shivani Bhardwaj]

The variable mbo is already NULL tested so, check on it should be
removed.
Semantic patch used:

@@ expression E;
statement S1, S2, S3; @@
if(E==NULL) {... return ...;}
else S1
- if(E==NULL)
  S2
- else S3

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/staging/most/aim-cdev/cdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/aim-cdev/cdev.c
index 930ada0..5dc5608 100644
--- a/drivers/staging/most/aim-cdev/cdev.c
+++ b/drivers/staging/most/aim-cdev/cdev.c
@@ -207,8 +207,7 @@ static ssize_t aim_write(struct file *filp, const char __user *buf,
 	}
 	return actual_len - retval;
 error:
-	if (mbo)
-		most_put_mbo(mbo);
+	most_put_mbo(mbo);
 	return err;
 }
 
-- 
2.1.0

Re: [Outreachy kernel] [PATCH] Staging: most: cdev: Remove unnecessary check

[Julia Lawall]

On Thu, 15 Oct 2015, Shivani Bhardwaj wrote:

> The variable mbo is already NULL tested so, check on it should be
> removed.
> Semantic patch used:
>
> @@ expression E;
> statement S1, S2, S3; @@
> if(E==NULL) {... return ...;}
> else S1
> - if(E==NULL)
>   S2
> - else S3

I don't think that this semantic patch actually matches the code below.

julia

>
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  drivers/staging/most/aim-cdev/cdev.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/aim-cdev/cdev.c
> index 930ada0..5dc5608 100644
> --- a/drivers/staging/most/aim-cdev/cdev.c
> +++ b/drivers/staging/most/aim-cdev/cdev.c
> @@ -207,8 +207,7 @@ static ssize_t aim_write(struct file *filp, const char __user *buf,
>  	}
>  	return actual_len - retval;
>  error:
> -	if (mbo)
> -		most_put_mbo(mbo);
> +	most_put_mbo(mbo);
>  	return err;
>  }
>
> --
> 2.1.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151015102240.GA17961%40ubuntu.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] Staging: most: cdev: Remove unnecessary check

[Shivani Bhardwaj]

On Thu, Oct 15, 2015 at 4:03 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> On Thu, 15 Oct 2015, Shivani Bhardwaj wrote:
>
>> The variable mbo is already NULL tested so, check on it should be
>> removed.
>> Semantic patch used:
>>
>> @@ expression E;
>> statement S1, S2, S3; @@
>> if(E==NULL) {... return ...;}
>> else S1
>> - if(E==NULL)
>>   S2
>> - else S3
>
> I don't think that this semantic patch actually matches the code below.
>
> julia
>

I'm sorry. I've sent another version. I've tested that on a dummy file.
Thank you.

>>
>> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
>> ---
>>  drivers/staging/most/aim-cdev/cdev.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/aim-cdev/cdev.c
>> index 930ada0..5dc5608 100644
>> --- a/drivers/staging/most/aim-cdev/cdev.c
>> +++ b/drivers/staging/most/aim-cdev/cdev.c
>> @@ -207,8 +207,7 @@ static ssize_t aim_write(struct file *filp, const char __user *buf,
>>       }
>>       return actual_len - retval;
>>  error:
>> -     if (mbo)
>> -             most_put_mbo(mbo);
>> +     most_put_mbo(mbo);
>>       return err;
>>  }
>>
>> --
>> 2.1.0
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151015102240.GA17961%40ubuntu.
>> For more options, visit https://groups.google.com/d/optout.
>>