From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-ext4@vger.kernel.org, Nikolay Borisov <kernel@kyup.com>
Subject: Re: [PATCH 1/8] jbd2: gate checksum calculations on crc driver presence, not sb flags
Date: Thu, 15 Oct 2015 10:32:25 -0400 [thread overview]
Message-ID: <20151015143225.GE17329@thunk.org> (raw)
In-Reply-To: <20151012215422.28872.71133.stgit@birch.djwong.org>
On Mon, Oct 12, 2015 at 02:54:22PM -0700, Darrick J. Wong wrote:
> Change the journal's checksum functions to gate on whether or not the
> crc32c driver is loaded, and gate the loading on the superblock bits.
> This prevents a journal crash if someone loads a journal in no-csum
> mode and then randomizes the superblock, thus flipping on the feature
> bits.
>
> v2: Create a feature-test helper, use it everywhere.
>
> Tested-By: Nikolay Borisov <kernel@kyup.com>
> Reported-by: Nikolay Borisov <kernel@kyup.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2015-10-15 14:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 21:54 [PATCH 0/8] ext4/jbd2: misc fixes and cleanups; save checksum seeds Darrick J. Wong
2015-10-12 21:54 ` [PATCH 1/8] jbd2: gate checksum calculations on crc driver presence, not sb flags Darrick J. Wong
2015-10-15 14:32 ` Theodore Ts'o [this message]
2015-10-12 21:54 ` [PATCH 2/8] ext4: promote ext4 over ext2 in the default probe order Darrick J. Wong
2015-10-15 14:34 ` Theodore Ts'o
2015-10-12 21:54 ` [PATCH 3/8] ext2: only permit ro mounts with compat features we know we don't support Darrick J. Wong
2015-10-15 14:37 ` Theodore Ts'o
2015-10-15 16:47 ` Darrick J. Wong
2015-10-12 21:54 ` [PATCH 4/8] ext4: store checksum seed in superblock Darrick J. Wong
2015-10-15 14:45 ` Theodore Ts'o
2015-10-18 1:19 ` Theodore Ts'o
2015-10-18 1:23 ` Darrick J. Wong
2015-10-18 2:14 ` Theodore Ts'o
2015-10-12 21:54 ` [PATCH 5/8] ext4: call out CRC and corruption errors with specific error codes Darrick J. Wong
2015-10-15 14:47 ` Theodore Ts'o
2015-10-12 21:54 ` [PATCH 6/8] ext4: make the bitmap read routines return real " Darrick J. Wong
2015-10-15 14:57 ` Theodore Ts'o
2015-10-15 15:02 ` Darrick J. Wong
2015-10-15 16:36 ` [PATCH v2 " Darrick J. Wong
2015-10-18 1:45 ` Theodore Ts'o
2015-10-12 21:55 ` [PATCH 7/8] ext4: clean up feature test macros with predicate functions Darrick J. Wong
2015-10-15 15:12 ` Theodore Ts'o
2015-10-12 21:55 ` [PATCH 8/8] jbd2: " Darrick J. Wong
2015-10-15 15:12 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015143225.GE17329@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=kernel@kyup.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.