From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/8] ext2: only permit ro mounts with compat features we know we don't support
Date: Thu, 15 Oct 2015 10:37:28 -0400 [thread overview]
Message-ID: <20151015143728.GG17329@thunk.org> (raw)
In-Reply-To: <20151012215437.28872.14707.stgit@birch.djwong.org>
On Mon, Oct 12, 2015 at 02:54:37PM -0700, Darrick J. Wong wrote:
> The ext2 mount code never checks the compat features against the ones
> it knows about. This is correct behavior since compat features are
> supposed to be rw-compatible with old drivers; however, for certain
> configurations (journalled rootfs) the admin is unlikely to want
> no-journal mode. Since we changed the default probe order to put ext4
> first, we can make ext2.ko only allow readonly mounts if has_journal is
> found.
>
> (Remember, this only affects mounting ext3 filesystems on ext2.ko.)
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
I'm not sure that we need this patch. If someone explicitly requests
a r/w mount of an ext3 file system using ext2, we should let it.
After changing the default probe order, the only time your change
would prohibit the mounting of an ext3 file system is when the system
administrator has explicitly mentioned the file system type in command
line.
- Ted
next prev parent reply other threads:[~2015-10-15 14:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 21:54 [PATCH 0/8] ext4/jbd2: misc fixes and cleanups; save checksum seeds Darrick J. Wong
2015-10-12 21:54 ` [PATCH 1/8] jbd2: gate checksum calculations on crc driver presence, not sb flags Darrick J. Wong
2015-10-15 14:32 ` Theodore Ts'o
2015-10-12 21:54 ` [PATCH 2/8] ext4: promote ext4 over ext2 in the default probe order Darrick J. Wong
2015-10-15 14:34 ` Theodore Ts'o
2015-10-12 21:54 ` [PATCH 3/8] ext2: only permit ro mounts with compat features we know we don't support Darrick J. Wong
2015-10-15 14:37 ` Theodore Ts'o [this message]
2015-10-15 16:47 ` Darrick J. Wong
2015-10-12 21:54 ` [PATCH 4/8] ext4: store checksum seed in superblock Darrick J. Wong
2015-10-15 14:45 ` Theodore Ts'o
2015-10-18 1:19 ` Theodore Ts'o
2015-10-18 1:23 ` Darrick J. Wong
2015-10-18 2:14 ` Theodore Ts'o
2015-10-12 21:54 ` [PATCH 5/8] ext4: call out CRC and corruption errors with specific error codes Darrick J. Wong
2015-10-15 14:47 ` Theodore Ts'o
2015-10-12 21:54 ` [PATCH 6/8] ext4: make the bitmap read routines return real " Darrick J. Wong
2015-10-15 14:57 ` Theodore Ts'o
2015-10-15 15:02 ` Darrick J. Wong
2015-10-15 16:36 ` [PATCH v2 " Darrick J. Wong
2015-10-18 1:45 ` Theodore Ts'o
2015-10-12 21:55 ` [PATCH 7/8] ext4: clean up feature test macros with predicate functions Darrick J. Wong
2015-10-15 15:12 ` Theodore Ts'o
2015-10-12 21:55 ` [PATCH 8/8] jbd2: " Darrick J. Wong
2015-10-15 15:12 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015143728.GG17329@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.