All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: "Ivan T. Ivanov" <iivanov.xz@gmail.com>
Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Gilad Avidov <gavidov@codeaurora.org>,
	Sagar Dharia <sdharia@codeaurora.org>
Subject: Re: [PATCH] spmi-pmic-arb: support configurable number of peripherals
Date: Thu, 15 Oct 2015 11:24:19 -0700	[thread overview]
Message-ID: <20151015182419.GH4558@codeaurora.org> (raw)
In-Reply-To: <8EEAE898-347B-4CEA-BA4D-0C69897E18EB@gmail.com>

On 10/15, Ivan T. Ivanov wrote:
> 
> > On Oct 15, 2015, at 1:43 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > 
> > I have to take this back. I missed the part where some pmics are on
> > slave id 2 or slave id 4, so this check isn't going to work. I've
> > adjusted it to use sid % 2 instead and I'll resend these two patches,
> > but I imagine to be more robust we're going to need to add a revid node
> > to the DT under the SID that actually has it. Then we can search the
> > child nodes for a revid compatible node and do the rev probing stuff.
> 
> Ah, yes. We don’t use revision information for now. 
> I suppose we can just remove these reads until we need
> this information?
> 

True, we could just remove all the code and make it look for a
revid node at some later time. But later would be soon because
I'm working on patches to add the read/write/volatile regmap
tables to this driver. I guess I'll just go all the way and do
the revid node part.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spmi-pmic-arb: support configurable number of peripherals
Date: Thu, 15 Oct 2015 11:24:19 -0700	[thread overview]
Message-ID: <20151015182419.GH4558@codeaurora.org> (raw)
In-Reply-To: <8EEAE898-347B-4CEA-BA4D-0C69897E18EB@gmail.com>

On 10/15, Ivan T. Ivanov wrote:
> 
> > On Oct 15, 2015, at 1:43 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > 
> > I have to take this back. I missed the part where some pmics are on
> > slave id 2 or slave id 4, so this check isn't going to work. I've
> > adjusted it to use sid % 2 instead and I'll resend these two patches,
> > but I imagine to be more robust we're going to need to add a revid node
> > to the DT under the SID that actually has it. Then we can search the
> > child nodes for a revid compatible node and do the rev probing stuff.
> 
> Ah, yes. We don?t use revision information for now. 
> I suppose we can just remove these reads until we need
> this information?
> 

True, we could just remove all the code and make it look for a
revid node at some later time. But later would be soon because
I'm working on patches to add the read/write/volatile regmap
tables to this driver. I guess I'll just go all the way and do
the revid node part.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2015-10-15 18:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14 21:54 [PATCH] spmi-pmic-arb: support configurable number of peripherals Stephen Boyd
2015-09-14 21:54 ` Stephen Boyd
2015-09-15  1:28 ` Stephen Boyd
2015-09-15  1:28   ` Stephen Boyd
2015-09-15 11:20   ` Ivan T. Ivanov
2015-09-15 11:20     ` Ivan T. Ivanov
2015-09-15 18:27     ` Stephen Boyd
2015-09-15 18:27       ` Stephen Boyd
2015-10-14 22:43       ` Stephen Boyd
2015-10-14 22:43         ` Stephen Boyd
2015-10-15  9:23         ` Ivan T. Ivanov
2015-10-15  9:23           ` Ivan T. Ivanov
2015-10-15 18:24           ` Stephen Boyd [this message]
2015-10-15 18:24             ` Stephen Boyd
  -- strict thread matches above, loose matches on Subject: below --
2015-09-03 23:20 Gilad Avidov
2015-09-04  0:16 ` Stephen Boyd
     [not found]   ` <20150904001630.GJ15099-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-09-04 18:04     ` Gilad Avidov
2015-09-04 18:04       ` Gilad Avidov
2015-09-05  0:50       ` Stephen Boyd
2015-09-09 23:32         ` Gilad Avidov
2015-09-10  0:30           ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151015182419.GH4558@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=gavidov@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=iivanov.xz@gmail.com \
    --cc=iivanov@mm-sol.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sdharia@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.