From: Stephen Boyd <sboyd@codeaurora.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Simon <horms@verge.net.au>,
Michael Turquette <mturquette@baylibre.com>,
Magnus <magnus.damm@gmail.com>,
Linux-SH <linux-sh@vger.kernel.org>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v4] clk: add CS2000 Fractional-N driver
Date: Thu, 15 Oct 2015 11:28:40 -0700 [thread overview]
Message-ID: <20151015182840.GJ4558@codeaurora.org> (raw)
In-Reply-To: <87r3kwor4d.wl%kuninori.morimoto.gx@renesas.com>
On 10/15, Kuninori Morimoto wrote:
>
> I understand. If my understanding is correct, user driver
> setups/enables this clock.
> If so, I still want this "clock-frequency" feature.
> because this clock requests other clock on my board.
> And requested clock requests this clock too.
> Thus, these clocks have dead lock on probe time
>
> cs2000: clk_multiplier@4f {
> ...
> clocks = <&rcar_sound 0>, ...
> ...
> };
>
> &rcar_sound {
> ...
> assigned-clocks = <&cs2000>;
> assigned-clock-rates = <24576000>;
> ...
> };
>
I think you're saying that the clock provider itself can't set
the rate with assigned-clock-rates? That isn't true, we should be
able to set the rate of the clock from within the provider node.
cs2000: clk_multiplier@4f {
assigned-clocks = <&cs2000>;
assigned-clock-rates = <24576000>;
};
The above should work.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Simon <horms@verge.net.au>,
Michael Turquette <mturquette@baylibre.com>,
Magnus <magnus.damm@gmail.com>,
Linux-SH <linux-sh@vger.kernel.org>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v4] clk: add CS2000 Fractional-N driver
Date: Thu, 15 Oct 2015 18:28:40 +0000 [thread overview]
Message-ID: <20151015182840.GJ4558@codeaurora.org> (raw)
In-Reply-To: <87r3kwor4d.wl%kuninori.morimoto.gx@renesas.com>
On 10/15, Kuninori Morimoto wrote:
>
> I understand. If my understanding is correct, user driver
> setups/enables this clock.
> If so, I still want this "clock-frequency" feature.
> because this clock requests other clock on my board.
> And requested clock requests this clock too.
> Thus, these clocks have dead lock on probe time
>
> cs2000: clk_multiplier@4f {
> ...
> clocks = <&rcar_sound 0>, ...
> ...
> };
>
> &rcar_sound {
> ...
> assigned-clocks = <&cs2000>;
> assigned-clock-rates = <24576000>;
> ...
> };
>
I think you're saying that the clock provider itself can't set
the rate with assigned-clock-rates? That isn't true, we should be
able to set the rate of the clock from within the provider node.
cs2000: clk_multiplier@4f {
assigned-clocks = <&cs2000>;
assigned-clock-rates = <24576000>;
};
The above should work.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-10-15 18:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 8:29 [PATCH v4] clk: add CS2000 Fractional-N driver Kuninori Morimoto
2015-09-15 8:29 ` Kuninori Morimoto
2015-10-02 0:38 ` Stephen Boyd
2015-10-02 0:38 ` Stephen Boyd
2015-10-02 1:11 ` Kuninori Morimoto
2015-10-02 1:11 ` Kuninori Morimoto
2015-10-02 18:11 ` Stephen Boyd
2015-10-02 18:11 ` Stephen Boyd
2015-10-15 1:35 ` Kuninori Morimoto
2015-10-15 1:35 ` Kuninori Morimoto
2015-10-15 18:28 ` Stephen Boyd [this message]
2015-10-15 18:28 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015182840.GJ4558@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.