[PATCH] Staging: lustre: lproc_ptlrpc: Replace simple_strtol with simple_stroul

[PATCH] Staging: lustre: lproc_ptlrpc: Replace simple_strtol with simple_stroul

[Shivani Bhardwaj]

The variable inst is a __u32 type and hence the function used should be
simple_strtoul.
Semantic patch used:

@@ type T;
T e;@@
e=
- simple_strtol
+ simple_strtoul
  (...)

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
index ec44b3c..415817c 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
@@ -1251,7 +1251,7 @@ int lprocfs_wr_import(struct file *file, const char __user *buffer,
 		*ptr = 0;
 		do_reconn = 0;
 		ptr += strlen("::");
-		inst = simple_strtol(ptr, &endptr, 10);
+		inst = simple_strtoul(ptr, &endptr, 10);
 		if (*endptr) {
 			CERROR("config: wrong instance # %s\n", ptr);
 		} else if (inst != imp->imp_connect_data.ocd_instance) {
-- 
2.1.0

Re: [Outreachy kernel] [PATCH] Staging: lustre: lproc_ptlrpc: Replace simple_strtol with simple_stroul

[Julia Lawall]

On Fri, 16 Oct 2015, Shivani Bhardwaj wrote:

> The variable inst is a __u32 type and hence the function used should be
> simple_strtoul.
> Semantic patch used:
> 
> @@ type T;
> T e;@@
> e=
> - simple_strtol
> + simple_strtoul
>   (...)

The semantic patch is not really helpful here.  Certainly you don't want 
to replace all calls to simple_strtol by simple_strtoul.  I guess that 
something around the call should have type __u32.

julia

> 
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
> index ec44b3c..415817c 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
> @@ -1251,7 +1251,7 @@ int lprocfs_wr_import(struct file *file, const char __user *buffer,
>  		*ptr = 0;
>  		do_reconn = 0;
>  		ptr += strlen("::");
> -		inst = simple_strtol(ptr, &endptr, 10);
> +		inst = simple_strtoul(ptr, &endptr, 10);
>  		if (*endptr) {
>  			CERROR("config: wrong instance # %s\n", ptr);
>  		} else if (inst != imp->imp_connect_data.ocd_instance) {
> -- 
> 2.1.0
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151015201311.GA45040%40ubuntu.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH] Staging: lustre: lproc_ptlrpc: Replace simple_strtol with simple_stroul

[Shivani Bhardwaj]

On Fri, Oct 16, 2015 at 1:46 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> On Fri, 16 Oct 2015, Shivani Bhardwaj wrote:
>
>> The variable inst is a __u32 type and hence the function used should be
>> simple_strtoul.
>> Semantic patch used:
>>
>> @@ type T;
>> T e;@@
>> e=
>> - simple_strtol
>> + simple_strtoul
>>   (...)
>
> The semantic patch is not really helpful here.  Certainly you don't want
> to replace all calls to simple_strtol by simple_strtoul.  I guess that
> something around the call should have type __u32.
>
> julia
>
@@ __u32 T;
T e;@@
e=
- simple_strtol
+ simple_strtoul
  (...)

Like this?

>>
>> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
>> ---
>>  drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
>> index ec44b3c..415817c 100644
>> --- a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
>> +++ b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
>> @@ -1251,7 +1251,7 @@ int lprocfs_wr_import(struct file *file, const char __user *buffer,
>>               *ptr = 0;
>>               do_reconn = 0;
>>               ptr += strlen("::");
>> -             inst = simple_strtol(ptr, &endptr, 10);
>> +             inst = simple_strtoul(ptr, &endptr, 10);
>>               if (*endptr) {
>>                       CERROR("config: wrong instance # %s\n", ptr);
>>               } else if (inst != imp->imp_connect_data.ocd_instance) {
>> --
>> 2.1.0
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151015201311.GA45040%40ubuntu.
>> For more options, visit https://groups.google.com/d/optout.
>>

Re: [Outreachy kernel] [PATCH] Staging: lustre: lproc_ptlrpc: Replace simple_strtol with simple_stroul

[Julia Lawall]

On Fri, 16 Oct 2015, Shivani Bhardwaj wrote:

> On Fri, Oct 16, 2015 at 1:46 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> > On Fri, 16 Oct 2015, Shivani Bhardwaj wrote:
> >
> >> The variable inst is a __u32 type and hence the function used should be
> >> simple_strtoul.
> >> Semantic patch used:
> >>
> >> @@ type T;
> >> T e;@@
> >> e=
> >> - simple_strtol
> >> + simple_strtoul
> >>   (...)
> >
> > The semantic patch is not really helpful here.  Certainly you don't want
> > to replace all calls to simple_strtol by simple_strtoul.  I guess that
> > something around the call should have type __u32.
> >
> > julia
> >
> @@ __u32 T;
> T e;@@
> e=
> - simple_strtol
> + simple_strtoul
>   (...)
> 
> Like this?

No.  You want e to have type __u32.  So it would be

__u32 e;

You don't need T at all.  In some other semantic patches there has been T, 
but that was a metavariable to hold any possible type.  Here you want to 
specify a specific type.

julia

> 
> >>
> >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> >> ---
> >>  drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
> >> index ec44b3c..415817c 100644
> >> --- a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
> >> +++ b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
> >> @@ -1251,7 +1251,7 @@ int lprocfs_wr_import(struct file *file, const char __user *buffer,
> >>               *ptr = 0;
> >>               do_reconn = 0;
> >>               ptr += strlen("::");
> >> -             inst = simple_strtol(ptr, &endptr, 10);
> >> +             inst = simple_strtoul(ptr, &endptr, 10);
> >>               if (*endptr) {
> >>                       CERROR("config: wrong instance # %s\n", ptr);
> >>               } else if (inst != imp->imp_connect_data.ocd_instance) {
> >> --
> >> 2.1.0
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151015201311.GA45040%40ubuntu.
> >> For more options, visit https://groups.google.com/d/optout.
> >>
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAKHNQQGPX%3DKu867t8UWX59hqta6e8EidrLX7H%3DM%2BGfc_%2BGL%2B1A%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH] Staging: lustre: lproc_ptlrpc: Replace simple_strtol with simple_stroul

[Shivani Bhardwaj]

On Fri, Oct 16, 2015 at 1:53 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Fri, 16 Oct 2015, Shivani Bhardwaj wrote:
>
>> On Fri, Oct 16, 2015 at 1:46 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>> > On Fri, 16 Oct 2015, Shivani Bhardwaj wrote:
>> >
>> >> The variable inst is a __u32 type and hence the function used should be
>> >> simple_strtoul.
>> >> Semantic patch used:
>> >>
>> >> @@ type T;
>> >> T e;@@
>> >> e=
>> >> - simple_strtol
>> >> + simple_strtoul
>> >>   (...)
>> >
>> > The semantic patch is not really helpful here.  Certainly you don't want
>> > to replace all calls to simple_strtol by simple_strtoul.  I guess that
>> > something around the call should have type __u32.
>> >
>> > julia
>> >
>> @@ __u32 T;
>> T e;@@
>> e=
>> - simple_strtol
>> + simple_strtoul
>>   (...)
>>
>> Like this?
>
> No.  You want e to have type __u32.  So it would be
>
> __u32 e;
>
> You don't need T at all.  In some other semantic patches there has been T,
> but that was a metavariable to hold any possible type.  Here you want to
> specify a specific type.
>
> julia
>
All right. Thank you. I'm sending new version.

>>
>> >>
>> >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
>> >> ---
>> >>  drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
>> >> index ec44b3c..415817c 100644
>> >> --- a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
>> >> +++ b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
>> >> @@ -1251,7 +1251,7 @@ int lprocfs_wr_import(struct file *file, const char __user *buffer,
>> >>               *ptr = 0;
>> >>               do_reconn = 0;
>> >>               ptr += strlen("::");
>> >> -             inst = simple_strtol(ptr, &endptr, 10);
>> >> +             inst = simple_strtoul(ptr, &endptr, 10);
>> >>               if (*endptr) {
>> >>                       CERROR("config: wrong instance # %s\n", ptr);
>> >>               } else if (inst != imp->imp_connect_data.ocd_instance) {
>> >> --
>> >> 2.1.0
>> >>
>> >> --
>> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151015201311.GA45040%40ubuntu.
>> >> For more options, visit https://groups.google.com/d/optout.
>> >>
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAKHNQQGPX%3DKu867t8UWX59hqta6e8EidrLX7H%3DM%2BGfc_%2BGL%2B1A%40mail.gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>

Re: [Outreachy kernel] [PATCH] Staging: lustre: lproc_ptlrpc: Replace simple_strtol with simple_stroul

[Shivani Bhardwaj]

On Fri, Oct 16, 2015 at 1:56 AM, Shivani Bhardwaj <shivanib134@gmail.com> wrote:
> On Fri, Oct 16, 2015 at 1:53 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>>
>>
>> On Fri, 16 Oct 2015, Shivani Bhardwaj wrote:
>>
>>> On Fri, Oct 16, 2015 at 1:46 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>>> > On Fri, 16 Oct 2015, Shivani Bhardwaj wrote:
>>> >
>>> >> The variable inst is a __u32 type and hence the function used should be
>>> >> simple_strtoul.
>>> >> Semantic patch used:
>>> >>
>>> >> @@ type T;
>>> >> T e;@@
>>> >> e=
>>> >> - simple_strtol
>>> >> + simple_strtoul
>>> >>   (...)
>>> >
>>> > The semantic patch is not really helpful here.  Certainly you don't want
>>> > to replace all calls to simple_strtol by simple_strtoul.  I guess that
>>> > something around the call should have type __u32.
>>> >
>>> > julia
>>> >
>>> @@ __u32 T;
>>> T e;@@
>>> e=
>>> - simple_strtol
>>> + simple_strtoul
>>>   (...)
>>>
>>> Like this?
>>
>> No.  You want e to have type __u32.  So it would be
>>
>> __u32 e;
>>
>> You don't need T at all.  In some other semantic patches there has been T,
>> but that was a metavariable to hold any possible type.  Here you want to
>> specify a specific type.
>>
>> julia
>>

It shows parse error for __u32, works fine for int. What should I do?

> All right. Thank you. I'm sending new version.
>
>>>
>>> >>
>>> >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
>>> >> ---
>>> >>  drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 2 +-
>>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>>> >>
>>> >> diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
>>> >> index ec44b3c..415817c 100644
>>> >> --- a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
>>> >> +++ b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
>>> >> @@ -1251,7 +1251,7 @@ int lprocfs_wr_import(struct file *file, const char __user *buffer,
>>> >>               *ptr = 0;
>>> >>               do_reconn = 0;
>>> >>               ptr += strlen("::");
>>> >> -             inst = simple_strtol(ptr, &endptr, 10);
>>> >> +             inst = simple_strtoul(ptr, &endptr, 10);
>>> >>               if (*endptr) {
>>> >>                       CERROR("config: wrong instance # %s\n", ptr);
>>> >>               } else if (inst != imp->imp_connect_data.ocd_instance) {
>>> >> --
>>> >> 2.1.0
>>> >>
>>> >> --
>>> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>>> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>>> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
>>> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151015201311.GA45040%40ubuntu.
>>> >> For more options, visit https://groups.google.com/d/optout.
>>> >>
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAKHNQQGPX%3DKu867t8UWX59hqta6e8EidrLX7H%3DM%2BGfc_%2BGL%2B1A%40mail.gmail.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>

Re: [Outreachy kernel] [PATCH] Staging: lustre: lproc_ptlrpc: Replace simple_strtol with simple_stroul

[Julia Lawall]

On Fri, 16 Oct 2015, Shivani Bhardwaj wrote:

> On Fri, Oct 16, 2015 at 1:56 AM, Shivani Bhardwaj <shivanib134@gmail.com> wrote:
> > On Fri, Oct 16, 2015 at 1:53 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >>
> >>
> >> On Fri, 16 Oct 2015, Shivani Bhardwaj wrote:
> >>
> >>> On Fri, Oct 16, 2015 at 1:46 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >>> > On Fri, 16 Oct 2015, Shivani Bhardwaj wrote:
> >>> >
> >>> >> The variable inst is a __u32 type and hence the function used should be
> >>> >> simple_strtoul.
> >>> >> Semantic patch used:
> >>> >>
> >>> >> @@ type T;
> >>> >> T e;@@
> >>> >> e=
> >>> >> - simple_strtol
> >>> >> + simple_strtoul
> >>> >>   (...)
> >>> >
> >>> > The semantic patch is not really helpful here.  Certainly you don't want
> >>> > to replace all calls to simple_strtol by simple_strtoul.  I guess that
> >>> > something around the call should have type __u32.
> >>> >
> >>> > julia
> >>> >
> >>> @@ __u32 T;
> >>> T e;@@
> >>> e=
> >>> - simple_strtol
> >>> + simple_strtoul
> >>>   (...)
> >>>
> >>> Like this?
> >>
> >> No.  You want e to have type __u32.  So it would be
> >>
> >> __u32 e;
> >>
> >> You don't need T at all.  In some other semantic patches there has been T,
> >> but that was a metavariable to hold any possible type.  Here you want to
> >> specify a specific type.
> >>
> >> julia
> >>
> 
> It shows parse error for __u32, works fine for int. What should I do?

__u32 is not known as a type to Coccinelle.

Put typedef __u32; just on the line before.

julia

> > All right. Thank you. I'm sending new version.
> >
> >>>
> >>> >>
> >>> >> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> >>> >> ---
> >>> >>  drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 2 +-
> >>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>> >>
> >>> >> diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
> >>> >> index ec44b3c..415817c 100644
> >>> >> --- a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
> >>> >> +++ b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
> >>> >> @@ -1251,7 +1251,7 @@ int lprocfs_wr_import(struct file *file, const char __user *buffer,
> >>> >>               *ptr = 0;
> >>> >>               do_reconn = 0;
> >>> >>               ptr += strlen("::");
> >>> >> -             inst = simple_strtol(ptr, &endptr, 10);
> >>> >> +             inst = simple_strtoul(ptr, &endptr, 10);
> >>> >>               if (*endptr) {
> >>> >>                       CERROR("config: wrong instance # %s\n", ptr);
> >>> >>               } else if (inst != imp->imp_connect_data.ocd_instance) {
> >>> >> --
> >>> >> 2.1.0
> >>> >>
> >>> >> --
> >>> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >>> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >>> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
> >>> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151015201311.GA45040%40ubuntu.
> >>> >> For more options, visit https://groups.google.com/d/optout.
> >>> >>
> >>>
> >>> --
> >>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >>> To post to this group, send email to outreachy-kernel@googlegroups.com.
> >>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAKHNQQGPX%3DKu867t8UWX59hqta6e8EidrLX7H%3DM%2BGfc_%2BGL%2B1A%40mail.gmail.com.
> >>> For more options, visit https://groups.google.com/d/optout.
> >>>
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAKHNQQH9iKJL02m5p%2BKjH0-H947u5ncpV5GbPm_-g_o6KLEqcg%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>