[PATCH] staging: r8723au: move * to be adjacent to pointer name

[PATCH] staging: r8723au: move * to be adjacent to pointer name

[Alison Schofield]

Move * in pointer types to be adjacent to pointer names per Linux
coding style.

Addresses checkpatch.pl: ERROR: "foo*    bar" should be "foo *bar"

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
---

Question to reviewers:
Are checkpatch.pl CHECK errors permitted in a patch?
        ie. This driver has a lot of pre-existing CamelCase CHECKs that 
	appear when my pre-commit hook executes.  I'd like to submit other
	changes without addressing the CamelCase simultaneously.

What is the recommendation in such cases?


 drivers/staging/rtl8723au/core/rtw_ieee80211.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
index cdd7bc4..07a6490 100644
--- a/drivers/staging/rtl8723au/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
@@ -348,9 +348,9 @@ int rtw_generate_ie23a(struct registry_priv *pregistrypriv)
 {
 	u8	wireless_mode;
 	int	sz = 0, rateLen;
-	struct wlan_bssid_ex*	pdev_network = &pregistrypriv->dev_network;
-	u8*	ie = pdev_network->IEs;
-	u16 cap;
+	struct wlan_bssid_ex *pdev_network = &pregistrypriv->dev_network;
+	u8	*ie = pdev_network->IEs;
+	u16	cap;
 
 	pdev_network->tsf = 0;
 
@@ -444,7 +444,8 @@ static int rtw_get_wpa2_cipher_suite(const u8 *s)
 	return 0;
 }
 
-int rtw_parse_wpa_ie23a(const u8* wpa_ie, int wpa_ie_len, int *group_cipher, int *pairwise_cipher, int *is_8021x)
+int rtw_parse_wpa_ie23a(const u8 *wpa_ie, int wpa_ie_len, int *group_cipher,
+			int *pairwise_cipher, int *is_8021x)
 {
 	int i, ret = _SUCCESS;
 	int left, count;
-- 
2.1.4

[RESEND PATCH] staging: r8723au: move * to be adjacent to pointer name

[Alison Schofield]

Move * in pointer types to be adjacent to pointer names per Linux
coding style.

Addresses checkpatch.pl: ERROR: "foo*    bar" should be "foo *bar"

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
---

(Rebased and resending)

Question to reviewers:
Are checkpatch.pl CHECK errors permitted in a patch?
        ie. This driver has a lot of pre-existing CamelCase CHECKs that
        appear when my pre-commit hook executes.  I'd like to submit other
        changes without addressing the CamelCase simultaneously.

What is the recommendation in such cases?


 drivers/staging/rtl8723au/core/rtw_ieee80211.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
index cdd7bc4..07a6490 100644
--- a/drivers/staging/rtl8723au/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
@@ -348,9 +348,9 @@ int rtw_generate_ie23a(struct registry_priv *pregistrypriv)
 {
 	u8	wireless_mode;
 	int	sz = 0, rateLen;
-	struct wlan_bssid_ex*	pdev_network = &pregistrypriv->dev_network;
-	u8*	ie = pdev_network->IEs;
-	u16 cap;
+	struct wlan_bssid_ex *pdev_network = &pregistrypriv->dev_network;
+	u8	*ie = pdev_network->IEs;
+	u16	cap;
 
 	pdev_network->tsf = 0;
 
@@ -444,7 +444,8 @@ static int rtw_get_wpa2_cipher_suite(const u8 *s)
 	return 0;
 }
 
-int rtw_parse_wpa_ie23a(const u8* wpa_ie, int wpa_ie_len, int *group_cipher, int *pairwise_cipher, int *is_8021x)
+int rtw_parse_wpa_ie23a(const u8 *wpa_ie, int wpa_ie_len, int *group_cipher,
+			int *pairwise_cipher, int *is_8021x)
 {
 	int i, ret = _SUCCESS;
 	int left, count;
-- 
2.1.4

Re: [Outreachy kernel] [RESEND PATCH] staging: r8723au: move * to be adjacent to pointer name

[Julia Lawall]

On Sat, 17 Oct 2015, Alison Schofield wrote:

> Move * in pointer types to be adjacent to pointer names per Linux
> coding style.
> 
> Addresses checkpatch.pl: ERROR: "foo*    bar" should be "foo *bar"
> 
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> ---
> 
> (Rebased and resending)
> 
> Question to reviewers:
> Are checkpatch.pl CHECK errors permitted in a patch?
>         ie. This driver has a lot of pre-existing CamelCase CHECKs that
>         appear when my pre-commit hook executes.  I'd like to submit other
>         changes without addressing the CamelCase simultaneously.
> 
> What is the recommendation in such cases?

Submitting the patch is OK.  Fixing Camel Case problems is a very 
non-local transformation, and your change would get completely lost if you 
did that as well.

julia

> 
> 
>  drivers/staging/rtl8723au/core/rtw_ieee80211.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
> index cdd7bc4..07a6490 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ieee80211.c
> @@ -348,9 +348,9 @@ int rtw_generate_ie23a(struct registry_priv *pregistrypriv)
>  {
>  	u8	wireless_mode;
>  	int	sz = 0, rateLen;
> -	struct wlan_bssid_ex*	pdev_network = &pregistrypriv->dev_network;
> -	u8*	ie = pdev_network->IEs;
> -	u16 cap;
> +	struct wlan_bssid_ex *pdev_network = &pregistrypriv->dev_network;
> +	u8	*ie = pdev_network->IEs;
> +	u16	cap;
>  
>  	pdev_network->tsf = 0;
>  
> @@ -444,7 +444,8 @@ static int rtw_get_wpa2_cipher_suite(const u8 *s)
>  	return 0;
>  }
>  
> -int rtw_parse_wpa_ie23a(const u8* wpa_ie, int wpa_ie_len, int *group_cipher, int *pairwise_cipher, int *is_8021x)
> +int rtw_parse_wpa_ie23a(const u8 *wpa_ie, int wpa_ie_len, int *group_cipher,
> +			int *pairwise_cipher, int *is_8021x)
>  {
>  	int i, ret = _SUCCESS;
>  	int left, count;
> -- 
> 2.1.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1445125163-2116-1-git-send-email-amsfield22%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>