All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Keerthy <j-keerthy@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] ARM: OMAP2: DRA7: Modify optimize string comparisons in soc_is calls
Date: Fri, 16 Oct 2015 12:09:48 -0700	[thread overview]
Message-ID: <20151016190948.GB24370@atomide.com> (raw)
In-Reply-To: <1444885808-6306-2-git-send-email-j-keerthy@ti.com>

* Keerthy <j-keerthy@ti.com> [151014 22:14]:
> Currently everytime soc_is calls are made, firstly device tree nodes
> are parsed and then string comparisons are made to determine the
> soc version. Optimizing it to be done one time and store the result.
> Use the stored value in all the subsequent checks for soc_is calls.

Let's just get rid of the of_machine_is_compatible() checks here.

When dra7xxx_check_revision we already know it's dra7, no point for
any of the string parsing with of_machine_is_compatible(). We just
risk things going wrong.

And we already have omap_revision that gets populated based on the
hawkeye register, so let's use that instead. Can you please update
this patch just to use is_dra7xx() macros like the other use?

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ARM: OMAP2: DRA7: Modify optimize string comparisons in soc_is calls
Date: Fri, 16 Oct 2015 12:09:48 -0700	[thread overview]
Message-ID: <20151016190948.GB24370@atomide.com> (raw)
In-Reply-To: <1444885808-6306-2-git-send-email-j-keerthy@ti.com>

* Keerthy <j-keerthy@ti.com> [151014 22:14]:
> Currently everytime soc_is calls are made, firstly device tree nodes
> are parsed and then string comparisons are made to determine the
> soc version. Optimizing it to be done one time and store the result.
> Use the stored value in all the subsequent checks for soc_is calls.

Let's just get rid of the of_machine_is_compatible() checks here.

When dra7xxx_check_revision we already know it's dra7, no point for
any of the string parsing with of_machine_is_compatible(). We just
risk things going wrong.

And we already have omap_revision that gets populated based on the
hawkeye register, so let's use that instead. Can you please update
this patch just to use is_dra7xx() macros like the other use?

Regards,

Tony

  reply	other threads:[~2015-10-16 19:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15  5:10 [PATCH v2 0/3] ARM: OMAP2+: Optimize soc_is calls Keerthy
2015-10-15  5:10 ` Keerthy
2015-10-15  5:10 ` [PATCH v2 1/3] ARM: OMAP2: DRA7: Modify optimize string comparisons in " Keerthy
2015-10-15  5:10   ` Keerthy
2015-10-16 19:09   ` Tony Lindgren [this message]
2015-10-16 19:09     ` Tony Lindgren
2015-10-15  5:10 ` [PATCH v2 2/3] ARM: dts: AM43x-epos-evm: Add AM438x compatible string for epos Keerthy
2015-10-15  5:10   ` Keerthy
2015-10-19 16:06   ` Tony Lindgren
2015-10-19 16:06     ` Tony Lindgren
2015-10-15  5:10 ` [PATCH v2 3/3] ARM: OMAP2: AM43XX: Modify optimize string comparisons in soc_is calls Keerthy
2015-10-15  5:10   ` Keerthy
2015-10-16 19:11   ` Tony Lindgren
2015-10-16 19:11     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151016190948.GB24370@atomide.com \
    --to=tony@atomide.com \
    --cc=j-keerthy@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.