All of lore.kernel.org
 help / color / mirror / Atom feed
* re: drm/gem: Check locking in drm_gem_object_unreference
@ 2015-10-17  6:33 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-10-17  6:33 UTC (permalink / raw)
  To: daniel.vetter; +Cc: dri-devel

Hello Daniel Vetter,

This is a semi-automatic email about new static checker warnings.

The patch 5771551c4877: "drm/gem: Check locking in 
drm_gem_object_unreference" from Oct 15, 2015, leads to the following 
Smatch complaint:

include/drm/drm_gem.h:147 drm_gem_object_unreference()
	 warn: variable dereferenced before check 'obj' (see line 145)

include/drm/drm_gem.h
   144	{
   145		WARN_ON(!mutex_is_locked(&obj->dev->struct_mutex));
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
deref.

   146	
   147		if (obj != NULL)

check.

   148			kref_put(&obj->refcount, drm_gem_object_free);
   149	}

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-10-17  6:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-17  6:33 drm/gem: Check locking in drm_gem_object_unreference Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.