From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] netfilter: fix Kconfig dependencies for nft_dup_ipv{4,6}
Date: Sat, 17 Oct 2015 13:35:16 +0200 [thread overview]
Message-ID: <20151017113516.GA3002@salvia> (raw)
In-Reply-To: <5041322.FiDa5XtNuO@wuerfel>
On Fri, Oct 16, 2015 at 10:10:04PM +0200, Arnd Bergmann wrote:
> nft_dup_ipv4 and nft_dup_ipv6 select the respective nf_dup_ipv{4,6}
> drivers, which must not be built-in if nf_conntrack is a loadable
> module, otherwise we get a link error:
>
> net/built-in.o: In function `nf_dup_ipv6':
> (.text+0xdef20): undefined reference to `nf_conntrack_untracked'
>
> The dependency was fixed for the nf_dup_* modules recently, but this
> patch adds the same dependency to the nft_dup_* modules for
> the (hopefully) complete fix.
Already have this patch for this enqueued here:
http://git.kernel.org/cgit/linux/kernel/git/pablo/nf.git/commit/?id=6ece90f9a13e2592cbd6634f74bcb306169b5ab6
Will be submitting this to David asap. Thanks anyway.
WARNING: multiple messages have this Message-ID (diff)
From: pablo@netfilter.org (Pablo Neira Ayuso)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] netfilter: fix Kconfig dependencies for nft_dup_ipv{4,6}
Date: Sat, 17 Oct 2015 13:35:16 +0200 [thread overview]
Message-ID: <20151017113516.GA3002@salvia> (raw)
In-Reply-To: <5041322.FiDa5XtNuO@wuerfel>
On Fri, Oct 16, 2015 at 10:10:04PM +0200, Arnd Bergmann wrote:
> nft_dup_ipv4 and nft_dup_ipv6 select the respective nf_dup_ipv{4,6}
> drivers, which must not be built-in if nf_conntrack is a loadable
> module, otherwise we get a link error:
>
> net/built-in.o: In function `nf_dup_ipv6':
> (.text+0xdef20): undefined reference to `nf_conntrack_untracked'
>
> The dependency was fixed for the nf_dup_* modules recently, but this
> patch adds the same dependency to the nft_dup_* modules for
> the (hopefully) complete fix.
Already have this patch for this enqueued here:
http://git.kernel.org/cgit/linux/kernel/git/pablo/nf.git/commit/?id=6ece90f9a13e2592cbd6634f74bcb306169b5ab6
Will be submitting this to David asap. Thanks anyway.
next prev parent reply other threads:[~2015-10-17 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 20:10 [PATCH] netfilter: fix Kconfig dependencies for nft_dup_ipv{4,6} Arnd Bergmann
2015-10-16 20:10 ` Arnd Bergmann
2015-10-17 11:35 ` Pablo Neira Ayuso [this message]
2015-10-17 11:35 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151017113516.GA3002@salvia \
--to=pablo@netfilter.org \
--cc=arnd@arndb.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.