From: Dan Carpenter <dan.carpenter@oracle.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Clemens Ladisch <clemens@ladisch.de>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ALSA: firewire-tascam: off by one in identify_model()
Date: Sat, 17 Oct 2015 15:02:32 +0300 [thread overview]
Message-ID: <20151017120232.GU7289@mwanda> (raw)
In-Reply-To: <s5hlhb1dcsx.wl-tiwai@suse.de>
On Sat, Oct 17, 2015 at 12:11:58PM +0200, Takashi Iwai wrote:
> On Thu, 15 Oct 2015 20:18:29 +0200,
> Dan Carpenter wrote:
> >
> > In the original code, we potentially put a NUL character in model[8] and
> > it caused a static checker warning. We can put the NUL in model[7]
> > instead.
>
> I guess it's better to expand model[] to 9 bytes instead. The logic
> is to retrieve the string from the config rom, and it's up to 8
> letters.
Ok. I will resend.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Clemens Ladisch <clemens@ladisch.de>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ALSA: firewire-tascam: off by one in identify_model()
Date: Sat, 17 Oct 2015 12:02:32 +0000 [thread overview]
Message-ID: <20151017120232.GU7289@mwanda> (raw)
In-Reply-To: <s5hlhb1dcsx.wl-tiwai@suse.de>
On Sat, Oct 17, 2015 at 12:11:58PM +0200, Takashi Iwai wrote:
> On Thu, 15 Oct 2015 20:18:29 +0200,
> Dan Carpenter wrote:
> >
> > In the original code, we potentially put a NUL character in model[8] and
> > it caused a static checker warning. We can put the NUL in model[7]
> > instead.
>
> I guess it's better to expand model[] to 9 bytes instead. The logic
> is to retrieve the string from the config rom, and it's up to 8
> letters.
Ok. I will resend.
regards,
dan carpenter
next prev parent reply other threads:[~2015-10-17 12:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 18:18 [patch] ALSA: firewire-tascam: off by one in identify_model() Dan Carpenter
2015-10-15 18:18 ` Dan Carpenter
2015-10-17 10:11 ` Takashi Iwai
2015-10-17 10:11 ` Takashi Iwai
2015-10-17 12:02 ` Dan Carpenter [this message]
2015-10-17 12:02 ` Dan Carpenter
2015-10-18 1:00 ` Takashi Sakamoto
2015-10-18 1:00 ` Takashi Sakamoto
2015-10-19 11:29 ` [patch v2] " Dan Carpenter
2015-10-19 11:29 ` Dan Carpenter
2015-10-19 11:54 ` Takashi Sakamoto
2015-10-19 11:54 ` Takashi Sakamoto
2015-10-19 12:01 ` Takashi Iwai
2015-10-19 12:01 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151017120232.GU7289@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.