All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [PATCH 4.1,4.2] drm/i915: Silence DDR DVFS errors on CHV
Date: Sat, 17 Oct 2015 13:30:37 -0700	[thread overview]
Message-ID: <20151017203037.GA6884@kroah.com> (raw)
In-Reply-To: <1443467351-16199-1-git-send-email-ville.syrjala@linux.intel.com>

On Mon, Sep 28, 2015 at 10:09:11PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> commit 58590c14d80defc94e900308a9d8fa55284de6f2 upstream.

This is not the commit id of the patch below at all, I can't take this,
please be more careful in the future.

thanks,

greg k-h

> 
> 58590c1 drm/i915: Don't try to use DDR DVFS on CHV when disabled in the BIOS
> can't be backported as is because proper DDR DVFS support didn't even
> exist before
> 6f9c784 drm/i915: Don't do PM5/DDR DVFS with multiple pipes
> 
> However we still want to get rid of the error messages. The simplest thing
> is to just suppress them, so let's do that instead.
> 
> Cc: <stable@vger.kernel.org> # 4.1, 4.2
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index eadc15c..4a904f2 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -303,7 +303,7 @@ static void chv_set_memory_dvfs(struct drm_i915_private *dev_priv, bool enable)
>  
>  	if (wait_for((vlv_punit_read(dev_priv, PUNIT_REG_DDR_SETUP2) &
>  		      FORCE_DDR_FREQ_REQ_ACK) == 0, 3))
> -		DRM_ERROR("timed out waiting for Punit DDR DVFS request\n");
> +		DRM_DEBUG_DRIVER("timed out waiting for Punit DDR DVFS request\n");
>  
>  	mutex_unlock(&dev_priv->rps.hw_lock);
>  }
> -- 
> 2.4.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [PATCH 4.1,4.2] drm/i915: Silence DDR DVFS errors on CHV
Date: Sat, 17 Oct 2015 13:30:37 -0700	[thread overview]
Message-ID: <20151017203037.GA6884@kroah.com> (raw)
In-Reply-To: <1443467351-16199-1-git-send-email-ville.syrjala@linux.intel.com>

On Mon, Sep 28, 2015 at 10:09:11PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrj�l� <ville.syrjala@linux.intel.com>
> 
> commit 58590c14d80defc94e900308a9d8fa55284de6f2 upstream.

This is not the commit id of the patch below at all, I can't take this,
please be more careful in the future.

thanks,

greg k-h

> 
> 58590c1 drm/i915: Don't try to use DDR DVFS on CHV when disabled in the BIOS
> can't be backported as is because proper DDR DVFS support didn't even
> exist before
> 6f9c784 drm/i915: Don't do PM5/DDR DVFS with multiple pipes
> 
> However we still want to get rid of the error messages. The simplest thing
> is to just suppress them, so let's do that instead.
> 
> Cc: <stable@vger.kernel.org> # 4.1, 4.2
> Signed-off-by: Ville Syrj�l� <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index eadc15c..4a904f2 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -303,7 +303,7 @@ static void chv_set_memory_dvfs(struct drm_i915_private *dev_priv, bool enable)
>  
>  	if (wait_for((vlv_punit_read(dev_priv, PUNIT_REG_DDR_SETUP2) &
>  		      FORCE_DDR_FREQ_REQ_ACK) == 0, 3))
> -		DRM_ERROR("timed out waiting for Punit DDR DVFS request\n");
> +		DRM_DEBUG_DRIVER("timed out waiting for Punit DDR DVFS request\n");
>  
>  	mutex_unlock(&dev_priv->rps.hw_lock);
>  }
> -- 
> 2.4.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-10-17 20:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28 19:09 [PATCH 4.1, 4.2] drm/i915: Silence DDR DVFS errors on CHV ville.syrjala
2015-09-28 19:09 ` [PATCH 4.1,4.2] " ville.syrjala
2015-10-17 20:30 ` Greg KH [this message]
2015-10-17 20:30   ` Greg KH
2015-10-19  8:02   ` [Intel-gfx] [PATCH 4.1, 4.2] " Jani Nikula
2015-10-19 15:13     ` Greg KH
2015-10-19 15:13       ` [Intel-gfx] " Greg KH
2015-10-19 16:10       ` Daniel Vetter
2015-10-19 16:10         ` [Intel-gfx] " Daniel Vetter
2015-10-19 16:31         ` Greg KH
2015-10-19 16:31           ` [Intel-gfx] " Greg KH
2015-10-19 16:40       ` Ville Syrjälä
2015-10-19 16:40         ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151017203037.GA6884@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.