[PATCH] Staging: lustre: lcommon_misc: Correct block comments

[PATCH] Staging: lustre: lcommon_misc: Correct block comments

[Shivani Bhardwaj]

Alignment of block comments should be correct.
Fix checkpatch WARNING: Block comments use a trailing */ on a separate
line

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/staging/lustre/lustre/lclient/lcommon_misc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
index 8389a0e..d80bcedd 100644
--- a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
+++ b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
@@ -48,7 +48,8 @@
 /* Initialize the default and maximum LOV EA and cookie sizes.  This allows
  * us to make MDS RPCs with large enough reply buffers to hold the
  * maximum-sized (= maximum striped) EA and cookie without having to
- * calculate this (via a call into the LOV + OSCs) each time we make an RPC. */
+ * calculate this (via a call into the LOV + OSCs) each time we make an RPC.
+ */
 int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
 {
 	struct lov_stripe_md lsm = { .lsm_magic = LOV_MAGIC_V3 };
@@ -74,7 +75,8 @@ int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
 	cookiesize = stripes * sizeof(struct llog_cookie);
 
 	/* default cookiesize is 0 because from 2.4 server doesn't send
-	 * llog cookies to client. */
+	 * llog cookies to client.
+	 */
 	CDEBUG(D_HA,
 	       "updating def/max_easize: %d/%d def/max_cookiesize: 0/%d\n",
 	       def_easize, easize, cookiesize);
-- 
2.1.0

Re: [Outreachy kernel] [PATCH] Staging: lustre: lcommon_misc: Correct block comments

[Daniel Baluta]

On Sun, Oct 18, 2015 at 7:41 PM, Shivani Bhardwaj <shivanib134@gmail.com> wrote:
> Alignment of block comments should be correct.
> Fix checkpatch WARNING: Block comments use a trailing */ on a separate
> line
>
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  drivers/staging/lustre/lustre/lclient/lcommon_misc.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
> index 8389a0e..d80bcedd 100644
> --- a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
> +++ b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
> @@ -48,7 +48,8 @@
>  /* Initialize the default and maximum LOV EA and cookie sizes.  This allows
>   * us to make MDS RPCs with large enough reply buffers to hold the
>   * maximum-sized (= maximum striped) EA and cookie without having to
> - * calculate this (via a call into the LOV + OSCs) each time we make an RPC. */
> + * calculate this (via a call into the LOV + OSCs) each time we make an RPC.
> + */
>  int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
>  {
>         struct lov_stripe_md lsm = { .lsm_magic = LOV_MAGIC_V3 };
> @@ -74,7 +75,8 @@ int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
>         cookiesize = stripes * sizeof(struct llog_cookie);
>
>         /* default cookiesize is 0 because from 2.4 server doesn't send
> -        * llog cookies to client. */
> +        * llog cookies to client.
> +        */
>         CDEBUG(D_HA,
>                "updating def/max_easize: %d/%d def/max_cookiesize: 0/%d\n",
>                def_easize, easize, cookiesize);

While at it please also add an empty comment line at the begining:

/*
 * first text line
 * ..
 */

Like here: http://lxr.free-electrons.com/source/Documentation/CodingStyle#L467

Re: [Outreachy kernel] [PATCH] Staging: lustre: lcommon_misc: Correct block comments

[Shivani Bhardwaj]

On Sun, Oct 18, 2015 at 10:28 PM, Daniel Baluta <daniel.baluta@gmail.com> wrote:
> On Sun, Oct 18, 2015 at 7:41 PM, Shivani Bhardwaj <shivanib134@gmail.com> wrote:
>> Alignment of block comments should be correct.
>> Fix checkpatch WARNING: Block comments use a trailing */ on a separate
>> line
>>
>> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
>> ---
>>  drivers/staging/lustre/lustre/lclient/lcommon_misc.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
>> index 8389a0e..d80bcedd 100644
>> --- a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
>> +++ b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
>> @@ -48,7 +48,8 @@
>>  /* Initialize the default and maximum LOV EA and cookie sizes.  This allows
>>   * us to make MDS RPCs with large enough reply buffers to hold the
>>   * maximum-sized (= maximum striped) EA and cookie without having to
>> - * calculate this (via a call into the LOV + OSCs) each time we make an RPC. */
>> + * calculate this (via a call into the LOV + OSCs) each time we make an RPC.
>> + */
>>  int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
>>  {
>>         struct lov_stripe_md lsm = { .lsm_magic = LOV_MAGIC_V3 };
>> @@ -74,7 +75,8 @@ int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
>>         cookiesize = stripes * sizeof(struct llog_cookie);
>>
>>         /* default cookiesize is 0 because from 2.4 server doesn't send
>> -        * llog cookies to client. */
>> +        * llog cookies to client.
>> +        */
>>         CDEBUG(D_HA,
>>                "updating def/max_easize: %d/%d def/max_cookiesize: 0/%d\n",
>>                def_easize, easize, cookiesize);
>
> While at it please also add an empty comment line at the begining:
>
> /*
>  * first text line
>  * ..
>  */
>
> Like here: http://lxr.free-electrons.com/source/Documentation/CodingStyle#L467

All right. Thank you.