All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] Staging: emxx_udc: Add space around operator.
@ 2015-10-19  6:54 Navya Sri Nizamkari
  2015-10-19  7:29 ` [Outreachy kernel] " Julia Lawall
  0 siblings, 1 reply; 3+ messages in thread
From: Navya Sri Nizamkari @ 2015-10-19  6:54 UTC (permalink / raw)
  To: outreachy-kernel

Add a space around '>>' operator.
Problem found using checkpatch.

Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
Changes in v2:
    -Make commit message better.

 drivers/staging/emxx_udc/emxx_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index 0492747..60604c8 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -211,7 +211,7 @@ static u32 _nbu2ss_get_begin_ram_address(struct nbu2ss_udc *udc)
 		}
 
 		if ((data >> 16) > last_ram_adr)
-			last_ram_adr = data>>16;
+			last_ram_adr = data >> 16;
 	}
 
 	return last_ram_adr + use_ram_size;
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Outreachy kernel] [PATCH v2] Staging: emxx_udc: Add space around operator.
  2015-10-19  6:54 [PATCH v2] Staging: emxx_udc: Add space around operator Navya Sri Nizamkari
@ 2015-10-19  7:29 ` Julia Lawall
  2015-10-19 13:58   ` Navya Sri Nizamkari
  0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2015-10-19  7:29 UTC (permalink / raw)
  To: Navya Sri Nizamkari; +Cc: outreachy-kernel

On Mon, 19 Oct 2015, Navya Sri Nizamkari wrote:

> Add a space around '>>' operator.
> Problem found using checkpatch.

Looks better, thanks.

Reviewed-by: Julia Lawall <julia.lawall@lip6.fr>

>
> Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
> ---
> Changes in v2:
>     -Make commit message better.
>
>  drivers/staging/emxx_udc/emxx_udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index 0492747..60604c8 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -211,7 +211,7 @@ static u32 _nbu2ss_get_begin_ram_address(struct nbu2ss_udc *udc)
>  		}
>
>  		if ((data >> 16) > last_ram_adr)
> -			last_ram_adr = data>>16;
> +			last_ram_adr = data >> 16;
>  	}
>
>  	return last_ram_adr + use_ram_size;
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151019065438.GA5680%40navya.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Outreachy kernel] [PATCH v2] Staging: emxx_udc: Add space around operator.
  2015-10-19  7:29 ` [Outreachy kernel] " Julia Lawall
@ 2015-10-19 13:58   ` Navya Sri Nizamkari
  0 siblings, 0 replies; 3+ messages in thread
From: Navya Sri Nizamkari @ 2015-10-19 13:58 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: navyasri.tech


[-- Attachment #1.1: Type: text/plain, Size: 1744 bytes --]



On Monday, October 19, 2015 at 12:59:14 PM UTC+5:30, Julia Lawall wrote:
>
> On Mon, 19 Oct 2015, Navya Sri Nizamkari wrote: 
>
> > Add a space around '>>' operator. 
> > Problem found using checkpatch. 
>
> Looks better, thanks. 
>
> Reviewed-by: Julia Lawall <julia....@lip6.fr <javascript:>> 
>
> Thanks for reviewing. 

> > 
> > Signed-off-by: Navya Sri Nizamkari <navyas...@gmail.com <javascript:>> 
> > --- 
> > Changes in v2: 
> >     -Make commit message better. 
> > 
> >  drivers/staging/emxx_udc/emxx_udc.c | 2 +- 
> >  1 file changed, 1 insertion(+), 1 deletion(-) 
> > 
> > diff --git a/drivers/staging/emxx_udc/emxx_udc.c 
> b/drivers/staging/emxx_udc/emxx_udc.c 
> > index 0492747..60604c8 100644 
> > --- a/drivers/staging/emxx_udc/emxx_udc.c 
> > +++ b/drivers/staging/emxx_udc/emxx_udc.c 
> > @@ -211,7 +211,7 @@ static u32 _nbu2ss_get_begin_ram_address(struct 
> nbu2ss_udc *udc) 
> >                  } 
> > 
> >                  if ((data >> 16) > last_ram_adr) 
> > -                        last_ram_adr = data>>16; 
> > +                        last_ram_adr = data >> 16; 
> >          } 
> > 
> >          return last_ram_adr + use_ram_size; 
> > -- 
> > 1.9.1 
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups "outreachy-kernel" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to outreachy-kern...@googlegroups.com <javascript:>. 
> > To post to this group, send email to outreach...@googlegroups.com 
> <javascript:>. 
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20151019065438.GA5680%40navya. 
>
> > For more options, visit https://groups.google.com/d/optout. 
> > 
>

[-- Attachment #1.2: Type: text/html, Size: 2959 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-10-19 13:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-19  6:54 [PATCH v2] Staging: emxx_udc: Add space around operator Navya Sri Nizamkari
2015-10-19  7:29 ` [Outreachy kernel] " Julia Lawall
2015-10-19 13:58   ` Navya Sri Nizamkari

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.