Re: [regression] [git pull] drm for 4.3

From: Daniel Vetter <daniel@ffwll.ch>
To: "davej@codemonkey.org.uk" <davej@codemonkey.org.uk>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	"Lankhorst, Maarten" <maarten.lankhorst@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"Roper, Matthew D" <matthew.d.roper@intel.com>,
	"Vetter, Daniel" <daniel.vetter@intel.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"Miramontes Caton,
	Jairo Daniel" <jairo.daniel.miramontes.caton@intel.com>
Subject: Re: [regression] [git pull] drm for 4.3
Date: Mon, 19 Oct 2015 23:54:03 +0200	[thread overview]
Message-ID: <20151019215403.GL13786@phenom.ffwll.local> (raw)
In-Reply-To: <20151019201908.GA31075@codemonkey.org.uk>

On Mon, Oct 19, 2015 at 04:19:08PM -0400, davej@codemonkey.org.uk wrote:
> On Wed, Sep 30, 2015 at 08:56:26AM +0200, Daniel Vetter wrote:
> 
>  > > The warning on boot seems to be gone as of rc3, but I can now trigger this pretty easily..
>  > 
>  > http://patchwork.freedesktop.org/patch/60618/
> 
> Back from several weeks of travel..  I tried again with rc6, and
> I'm still seeing the same traces.

Oh crap, applied patch to wrong tree. We need to cherry-pick

commit 621bd0f6982badd6483acb191eb7b6226a578328
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue Sep 29 09:56:53 2015 +0200

    drm: Fix locking for sysfs dpms file

to drm-fixes. Sorry about that screw-up. Dave, can you pls do that one? It
even comes with the needed cc: stable included (since the locking breakage
was done in 4.0, it only surface due to a new warning in 4.3).
-Daniel

> 
> 	Dave
> 
> 
>  > > WARNING: CPU: 2 PID: 28911 at drivers/gpu/drm/drm_atomic.c:889 drm_atomic_get_property+0x244/0x2d0()
>  > > CPU: 2 PID: 28911 Comm: trinity-c313 Not tainted 4.3.0-rc3-think+ #14
>  > >  0000000000000379 ffff8801a1377c88 ffffffff8e35d5ec 0000000000000000
>  > >  ffff8801a1377cc0 ffffffff8e07a862 ffff880500b392b8 ffff880500a13008
>  > >  ffff880500b39290 ffff8804fe3806d8 ffff88003fa45668 ffff8801a1377cd0
>  > > Call Trace:
>  > >  [<ffffffff8e35d5ec>] dump_stack+0x4e/0x82
>  > >  [<ffffffff8e07a862>] warn_slowpath_common+0x82/0xc0
>  > >  [<ffffffff8e07a95a>] warn_slowpath_null+0x1a/0x20
>  > >  [<ffffffff8e48efc4>] drm_atomic_get_property+0x244/0x2d0
>  > >  [<ffffffff8e47c7fc>] drm_object_property_get_value+0x6c/0x70
>  > >  [<ffffffff8e47a41f>] dpms_show+0x2f/0x70
>  > >  [<ffffffff8e54ce30>] dev_attr_show+0x20/0x50
>  > >  [<ffffffff8e27ae91>] ? sysfs_file_ops+0x41/0x60
>  > >  [<ffffffff8e27b1a7>] sysfs_kf_seq_show+0xb7/0x110
>  > >  [<ffffffff8e2799a6>] kernfs_seq_show+0x26/0x30
>  > >  [<ffffffff8e21bba6>] seq_read+0xe6/0x430
>  > >  [<ffffffff8e27a3f7>] kernfs_fop_read+0x127/0x170
>  > >  [<ffffffff8e7e987b>] ? mutex_lock_nested+0x26b/0x3f0
>  > >  [<ffffffff8e1f3af8>] __vfs_read+0x28/0xe0
>  > >  [<ffffffff8e7e9897>] ? mutex_lock_nested+0x287/0x3f0
>  > >  [<ffffffff8e214c09>] ? __fdget_pos+0x49/0x50
>  > >  [<ffffffff8e214c09>] ? __fdget_pos+0x49/0x50
>  > >  [<ffffffff8e1f43c6>] vfs_read+0x86/0x130
>  > >  [<ffffffff8e1f50a9>] SyS_read+0x49/0xb0
>  > >  [<ffffffff8e7eded7>] entry_SYSCALL_64_fastpath+0x12/0x6f
>  > > ---[ end trace e053063c697a1355 ]---
>  > > 
>  > >  887         case DRM_MODE_OBJECT_CONNECTOR: {
>  > >  888                 struct drm_connector *connector = obj_to_connector(obj);
>  > >  889                 WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
>  > >  890                 ret = drm_atomic_connector_get_property(connector,
>  > >  891                                 connector->state, property, val);
>  > >  892                 break;
>  > >  893         }
>  > > 
>  > > _______________________________________________
>  > > dri-devel mailing list
>  > > dri-devel@lists.freedesktop.org
>  > > http://lists.freedesktop.org/mailman/listinfo/dri-devel
>  > 
>  > -- 
>  > Daniel Vetter
>  > Software Engineer, Intel Corporation
>  > http://blog.ffwll.ch
> ---end quoted text---
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx