From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-soc@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@codeaurora.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
linux-mediatek@lists.infradead.org,
Anton Blanchard <anton@samba.org>,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
David Brown <davidb@codeaurora.org>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular
Date: Tue, 20 Oct 2015 17:10:52 +0200 [thread overview]
Message-ID: <20151020151052.GI3421@piout.net> (raw)
In-Reply-To: <1445206878-12455-1-git-send-email-paul.gortmaker@windriver.com>
On 18/10/2015 at 18:21:13 -0400, Paul Gortmaker wrote :
> The one common thread here for all the patches is that we also
> scrap the .remove functions which would only be used for module
> unload (impossible) and driver unbind. For the drivers here, there
> doesn't seem to be a sensible unbind use case (vs. e.g. a multiport
> PCI ethernet driver where one port is unbound and passed through to
> a kvm guest or similar). Hence we just explicitly disallow any
> driver unbind operations to help prevent root from doing something
> illogical to the machine that they could have done previously.
>
> We've already done this for drivers/tty/serial/mpsc.c previously.
>
> Build tested for allmodconfig on ARM64 and powerpc for tty/tty-testing.
>
So, how does this actually build test atmel_serial?
A proper solution would be to actually make it a tristate and allow
building as a module. I think it currently fails because of
console_initcall() but that is certainly fixable.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular
Date: Tue, 20 Oct 2015 17:10:52 +0200 [thread overview]
Message-ID: <20151020151052.GI3421@piout.net> (raw)
In-Reply-To: <1445206878-12455-1-git-send-email-paul.gortmaker@windriver.com>
On 18/10/2015 at 18:21:13 -0400, Paul Gortmaker wrote :
> The one common thread here for all the patches is that we also
> scrap the .remove functions which would only be used for module
> unload (impossible) and driver unbind. For the drivers here, there
> doesn't seem to be a sensible unbind use case (vs. e.g. a multiport
> PCI ethernet driver where one port is unbound and passed through to
> a kvm guest or similar). Hence we just explicitly disallow any
> driver unbind operations to help prevent root from doing something
> illogical to the machine that they could have done previously.
>
> We've already done this for drivers/tty/serial/mpsc.c previously.
>
> Build tested for allmodconfig on ARM64 and powerpc for tty/tty-testing.
>
So, how does this actually build test atmel_serial?
A proper solution would be to actually make it a tristate and allow
building as a module. I think it currently fails because of
console_initcall() but that is certainly fixable.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-20 15:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 22:21 [PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular Paul Gortmaker
2015-10-18 22:21 ` Paul Gortmaker
2015-10-18 22:21 ` Paul Gortmaker
2015-10-18 22:21 ` [PATCH 1/5] drivers/tty: make hvc/hvc_vio.c " Paul Gortmaker
2015-10-18 22:21 ` [PATCH 2/5] drivers/tty: make ehv_bytechan.c " Paul Gortmaker
2015-10-18 22:21 ` [PATCH 3/5] drivers/tty/serial: make serial/atmel_serial.c " Paul Gortmaker
2015-10-18 22:21 ` Paul Gortmaker
2015-10-18 22:21 ` [PATCH 4/5] drivers/tty/serial: make msm_serial.c " Paul Gortmaker
2015-10-18 22:21 ` Paul Gortmaker
2015-10-19 19:44 ` Stephen Boyd
2015-10-19 20:19 ` Paul Gortmaker
2015-10-19 20:19 ` Paul Gortmaker
[not found] ` <1445206878-12455-1-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2015-10-18 22:21 ` [PATCH 5/5] drivers/tty/serial: make 8250/8250_mtk.c " Paul Gortmaker
2015-10-18 22:21 ` Paul Gortmaker
2015-10-18 22:21 ` Paul Gortmaker
2015-12-15 22:29 ` [PATCH 0/5] drivers/tty: make more bool drivers " Paul Gortmaker
2015-12-15 22:29 ` Paul Gortmaker
2015-12-15 22:29 ` Paul Gortmaker
2015-10-20 15:10 ` Alexandre Belloni [this message]
2015-10-20 15:10 ` Alexandre Belloni
[not found] ` <20151020151052.GI3421-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2015-10-21 0:20 ` Paul Gortmaker
2015-10-21 0:20 ` Paul Gortmaker
2015-10-21 0:20 ` Paul Gortmaker
2015-10-21 8:38 ` Alexandre Belloni
2015-10-21 8:38 ` Alexandre Belloni
-- strict thread matches above, loose matches on Subject: below --
2015-08-09 0:51 Paul Gortmaker
2015-08-09 0:51 ` Paul Gortmaker
2015-08-09 0:51 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151020151052.GI3421@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=agross@codeaurora.org \
--cc=anton@samba.org \
--cc=davidb@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matthias.bgg@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=nicolas.ferre@atmel.com \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.