* [PATCH] mtd: maps: rbtx4939-flash: fix compile error
@ 2015-10-19 19:31 Brian Norris
2015-10-20 7:21 ` Frans Klaver
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2015-10-19 19:31 UTC (permalink / raw)
To: linux-mtd; +Cc: Brian Norris, Frans Klaver
We got the syntax wrong here. Compile tested this time!
Error:
drivers/mtd/maps/rbtx4939-flash.c: In function 'rbtx4939_flash_probe':
>> drivers/mtd/maps/rbtx4939-flash.c:99:11: error: request for member 'dev' in something not a structure or union
info->mtd.dev.parent = &dev->dev;
^
Fixes: 9aa7e50276c1 ("mtd: maps: rbtx4939-flash: show parent device in sysfs")
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Frans Klaver <fransklaver@gmail.com>
---
drivers/mtd/maps/rbtx4939-flash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/maps/rbtx4939-flash.c b/drivers/mtd/maps/rbtx4939-flash.c
index 18ee361455a2..3a06ecfc55ff 100644
--- a/drivers/mtd/maps/rbtx4939-flash.c
+++ b/drivers/mtd/maps/rbtx4939-flash.c
@@ -96,7 +96,7 @@ static int rbtx4939_flash_probe(struct platform_device *dev)
err = -ENXIO;
goto err_out;
}
- info->mtd.dev.parent = &dev->dev;
+ info->mtd->dev.parent = &dev->dev;
err = mtd_device_parse_register(info->mtd, NULL, NULL, pdata->parts,
pdata->nr_parts);
--
2.6.0.rc2.230.g3dd15c0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: maps: rbtx4939-flash: fix compile error
2015-10-19 19:31 [PATCH] mtd: maps: rbtx4939-flash: fix compile error Brian Norris
@ 2015-10-20 7:21 ` Frans Klaver
2015-10-20 16:35 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Frans Klaver @ 2015-10-20 7:21 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-mtd
On Mon, Oct 19, 2015 at 9:31 PM, Brian Norris
<computersforpeace@gmail.com> wrote:
> We got the syntax wrong here. Compile tested this time!
>
> Error:
>
> drivers/mtd/maps/rbtx4939-flash.c: In function 'rbtx4939_flash_probe':
>>> drivers/mtd/maps/rbtx4939-flash.c:99:11: error: request for member 'dev' in something not a structure or union
> info->mtd.dev.parent = &dev->dev;
> ^
*Sigh*
Thanks Brian.
Frans
> Fixes: 9aa7e50276c1 ("mtd: maps: rbtx4939-flash: show parent device in sysfs")
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Frans Klaver <fransklaver@gmail.com>
> ---
> drivers/mtd/maps/rbtx4939-flash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/maps/rbtx4939-flash.c b/drivers/mtd/maps/rbtx4939-flash.c
> index 18ee361455a2..3a06ecfc55ff 100644
> --- a/drivers/mtd/maps/rbtx4939-flash.c
> +++ b/drivers/mtd/maps/rbtx4939-flash.c
> @@ -96,7 +96,7 @@ static int rbtx4939_flash_probe(struct platform_device *dev)
> err = -ENXIO;
> goto err_out;
> }
> - info->mtd.dev.parent = &dev->dev;
> + info->mtd->dev.parent = &dev->dev;
> err = mtd_device_parse_register(info->mtd, NULL, NULL, pdata->parts,
> pdata->nr_parts);
>
> --
> 2.6.0.rc2.230.g3dd15c0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: maps: rbtx4939-flash: fix compile error
2015-10-20 7:21 ` Frans Klaver
@ 2015-10-20 16:35 ` Brian Norris
0 siblings, 0 replies; 3+ messages in thread
From: Brian Norris @ 2015-10-20 16:35 UTC (permalink / raw)
To: Frans Klaver; +Cc: linux-mtd
On Tue, Oct 20, 2015 at 09:21:04AM +0200, Frans Klaver wrote:
> On Mon, Oct 19, 2015 at 9:31 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
> > We got the syntax wrong here. Compile tested this time!
> >
> > Error:
> >
> > drivers/mtd/maps/rbtx4939-flash.c: In function 'rbtx4939_flash_probe':
> >>> drivers/mtd/maps/rbtx4939-flash.c:99:11: error: request for member 'dev' in something not a structure or union
> > info->mtd.dev.parent = &dev->dev;
> > ^
>
> *Sigh*
>
> Thanks Brian.
No problem. Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-20 16:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-19 19:31 [PATCH] mtd: maps: rbtx4939-flash: fix compile error Brian Norris
2015-10-20 7:21 ` Frans Klaver
2015-10-20 16:35 ` Brian Norris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.