Re: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.

["John W. Linville" <linville@tuxdriver.com>]

On Sat, Oct 17, 2015 at 12:21:44AM -0400, Michael Chan wrote:
> Broadcom ethernet driver for the new family of NetXtreme-C/E
> ethernet devices.
> 
> v3:
>   - Fixed 2 more sparse warnings.
>   - Removed some unused structures in .h files.
> 
> v2:
>   - Fixed all kbuild test robot reported warnings.
>   - Fixed many of the checkpatch.pl errors and warnings.
>   - Fixed the Kconfig description.
> 
> Acked-by: Eddie Wai <eddie.wai@broadcom.com>
> Acked-by: Jeffrey Huang <huangjw@broadcom.com>
> Signed-off-by: Prashant Sreedharan <prashant@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>

...

> +		if (netif_msg_drv(bp))
> +			netdev_info(bp->dev, "[%d]: tx{fw_ring: %d prod: %x cons: %x} rx{fw_ring: %d prod: %x} rx_agg{fw_ring: %d agg_prod: %x sw_agg_prod: %x} cp{fw_ring: %d raw_cons: %x}\n",
> +				    i, txr->tx_ring_struct.fw_ring_id,
> +				    txr->tx_prod, txr->tx_cons,
> +				    rxr->rx_ring_struct.fw_ring_id,
> +				    rxr->rx_prod,
> +				    rxr->rx_agg_ring_struct.fw_ring_id,
> +				    rxr->rx_agg_prod, rxr->rx_sw_agg_prod,
> +				    cpr->cp_ring_struct.fw_ring_id,
> +				    cpr->cp_raw_cons);

Another big string -- perhaps a few \n's are in order?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.