From: "John W. Linville" <linville@tuxdriver.com>
To: Michael Chan <mchan@broadcom.com>
Cc: davem@davemloft.net, prashant@broadcom.com,
eddie.wai@broadcom.com, huangjw@broadcom.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.
Date: Tue, 20 Oct 2015 16:13:26 -0400 [thread overview]
Message-ID: <20151020201326.GF23569@tuxdriver.com> (raw)
In-Reply-To: <1445055704-6103-1-git-send-email-mchan@broadcom.com>
On Sat, Oct 17, 2015 at 12:21:44AM -0400, Michael Chan wrote:
> Broadcom ethernet driver for the new family of NetXtreme-C/E
> ethernet devices.
>
> v3:
> - Fixed 2 more sparse warnings.
> - Removed some unused structures in .h files.
>
> v2:
> - Fixed all kbuild test robot reported warnings.
> - Fixed many of the checkpatch.pl errors and warnings.
> - Fixed the Kconfig description.
>
> Acked-by: Eddie Wai <eddie.wai@broadcom.com>
> Acked-by: Jeffrey Huang <huangjw@broadcom.com>
> Signed-off-by: Prashant Sreedharan <prashant@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
> ---
> drivers/net/ethernet/broadcom/Kconfig | 19 +
> drivers/net/ethernet/broadcom/Makefile | 1 +
> drivers/net/ethernet/broadcom/bnxt/Makefile | 4 +
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5821 ++++++++++++++++++++
> drivers/net/ethernet/broadcom/bnxt/bnxt.h | 994 ++++
> drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 1150 ++++
> drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h | 18 +
> drivers/net/ethernet/broadcom/bnxt/bnxt_fw_hdr.h | 104 +
> drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 4046 ++++++++++++++
> drivers/net/ethernet/broadcom/bnxt/bnxt_nvm_defs.h | 59 +
> drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 787 +++
> drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h | 22 +
> 12 files changed, 13025 insertions(+)
> create mode 100644 drivers/net/ethernet/broadcom/bnxt/Makefile
> create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt.c
> create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt.h
> create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h
> create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_fw_hdr.h
> create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h
> create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_nvm_defs.h
> create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c
> create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.h
Well, it's a big one! But overall I'd say it looks pretty good...
I agree with Stephen's style comments, and there are a couple of
strings that are crazy long -- not just a source readability problem,
but things that would be hard to digest in a log as well. If you
address those then I'll be happy to ACK it.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2015-10-20 20:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 4:21 [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver Michael Chan
2015-10-19 5:17 ` Stephen Hemminger
2015-10-19 5:19 ` Stephen Hemminger
2015-10-19 23:04 ` Michael Chan
2015-10-20 15:47 ` David Laight
2015-10-19 5:21 ` Stephen Hemminger
2015-10-19 22:07 ` Michael Chan
2015-10-20 20:00 ` John W. Linville
2015-10-20 20:09 ` John W. Linville
2015-10-20 20:13 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151020201326.GF23569@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=davem@davemloft.net \
--cc=eddie.wai@broadcom.com \
--cc=huangjw@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.