[PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

[PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

[David Herrmann]

The thinkpad_acpi driver currently emits error messages on unsupported
brightness interfaces, giving the impression that someone will implement
those. However, this error is spit out on nearly every thinkpad in
production since 2 years now. Furthermore, the backlight interfaces on
those devices are supported by the i915 driver just fine.

Downgrade the error message to a normal pr_info() and stop telling people
to report it to IBM.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
---
 drivers/platform/x86/thinkpad_acpi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 131dd74..0bed473 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6459,8 +6459,7 @@ static void __init tpacpi_detect_brightness_capabilities(void)
 		pr_info("detected a 8-level brightness capable ThinkPad\n");
 		break;
 	default:
-		pr_err("Unsupported brightness interface, "
-		       "please contact %s\n", TPACPI_MAIL);
+		pr_info("Unsupported brightness interface\n");
 		tp_features.bright_unkfw = 1;
 		bright_maxlvl = b - 1;
 	}
-- 
2.6.1

Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

[Henrique de Moraes Holschuh]

On Wed, Oct 21, 2015, at 08:46, David Herrmann wrote:
> The thinkpad_acpi driver currently emits error messages on unsupported
> brightness interfaces, giving the impression that someone will implement
> those. However, this error is spit out on nearly every thinkpad in
> production since 2 years now. Furthermore, the backlight interfaces on
> those devices are supported by the i915 driver just fine.
> 
> Downgrade the error message to a normal pr_info() and stop telling people
> to report it to IBM.

IBM?  Those reports go directly to me.

> Signed-off-by: David Herrmann <dh.herrmann@gmail.com>

Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

> ---
>  drivers/platform/x86/thinkpad_acpi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index 131dd74..0bed473 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -6459,8 +6459,7 @@ static void __init
> tpacpi_detect_brightness_capabilities(void)
>  		pr_info("detected a 8-level brightness capable ThinkPad\n");
>  		break;
>  	default:
> -               pr_err("Unsupported brightness interface, "
> -                      "please contact %s\n", TPACPI_MAIL);
> +               pr_info("Unsupported brightness interface\n");
>  		tp_features.bright_unkfw = 1;
>  		bright_maxlvl = b - 1;
>  	}
> -- 
> 2.6.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe
> platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

[Darren Hart]

On Wed, Oct 21, 2015 at 12:33:52PM -0200, Henrique de Moraes Holschuh wrote:
> On Wed, Oct 21, 2015, at 08:46, David Herrmann wrote:
> > The thinkpad_acpi driver currently emits error messages on unsupported
> > brightness interfaces, giving the impression that someone will implement
> > those. However, this error is spit out on nearly every thinkpad in
> > production since 2 years now. Furthermore, the backlight interfaces on
> > those devices are supported by the i915 driver just fine.
> > 
> > Downgrade the error message to a normal pr_info() and stop telling people
> > to report it to IBM.
> 
> IBM?  Those reports go directly to me.
> 
> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
> 
> Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

Thanks, Queued.

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

[David Herrmann]

Hi Darren!

On Wed, Oct 21, 2015 at 4:44 PM, Darren Hart <dvhart@infradead.org> wrote:
> On Wed, Oct 21, 2015 at 12:33:52PM -0200, Henrique de Moraes Holschuh wrote:
>> On Wed, Oct 21, 2015, at 08:46, David Herrmann wrote:
>> > The thinkpad_acpi driver currently emits error messages on unsupported
>> > brightness interfaces, giving the impression that someone will implement
>> > those. However, this error is spit out on nearly every thinkpad in
>> > production since 2 years now. Furthermore, the backlight interfaces on
>> > those devices are supported by the i915 driver just fine.
>> >
>> > Downgrade the error message to a normal pr_info() and stop telling people
>> > to report it to IBM.
>>
>> IBM?  Those reports go directly to me.
>>
>> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
>>
>> Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
>
> Thanks, Queued.

Any particular reason this didn't show up in:
    [GIT PULL] platform-drivers-x86 for 4.4-1

Just a kind reminder, in case it slipped through the cracks.

Thanks
David

Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

[Darren Hart]

On Fri, Nov 06, 2015 at 03:19:43PM +0100, David Herrmann wrote:
> Hi Darren!
> 
> On Wed, Oct 21, 2015 at 4:44 PM, Darren Hart <dvhart@infradead.org> wrote:
> > On Wed, Oct 21, 2015 at 12:33:52PM -0200, Henrique de Moraes Holschuh wrote:
> >> On Wed, Oct 21, 2015, at 08:46, David Herrmann wrote:
> >> > The thinkpad_acpi driver currently emits error messages on unsupported
> >> > brightness interfaces, giving the impression that someone will implement
> >> > those. However, this error is spit out on nearly every thinkpad in
> >> > production since 2 years now. Furthermore, the backlight interfaces on
> >> > those devices are supported by the i915 driver just fine.
> >> >
> >> > Downgrade the error message to a normal pr_info() and stop telling people
> >> > to report it to IBM.
> >>
> >> IBM?  Those reports go directly to me.
> >>
> >> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
> >>
> >> Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> >
> > Thanks, Queued.
> 
> Any particular reason this didn't show up in:
>     [GIT PULL] platform-drivers-x86 for 4.4-1
> 
> Just a kind reminder, in case it slipped through the cracks.

Thank you, appears to be an error on my part, possibly due to some tooling
changes on my end. Apologies, I'll get 4.4-2 out within the merge window and be
sure to include this.

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

[Eric Curtin]

On 6 November 2015 at 17:57, Darren Hart <dvhart@infradead.org> wrote:
>
> On Fri, Nov 06, 2015 at 03:19:43PM +0100, David Herrmann wrote:
> > Hi Darren!
> >
> > On Wed, Oct 21, 2015 at 4:44 PM, Darren Hart <dvhart@infradead.org> wrote:
> > > On Wed, Oct 21, 2015 at 12:33:52PM -0200, Henrique de Moraes Holschuh wrote:
> > >> On Wed, Oct 21, 2015, at 08:46, David Herrmann wrote:
> > >> > The thinkpad_acpi driver currently emits error messages on unsupported
> > >> > brightness interfaces, giving the impression that someone will implement
> > >> > those. However, this error is spit out on nearly every thinkpad in
> > >> > production since 2 years now. Furthermore, the backlight interfaces on
> > >> > those devices are supported by the i915 driver just fine.
> > >> >
> > >> > Downgrade the error message to a normal pr_info() and stop telling people
> > >> > to report it to IBM.
> > >>
> > >> IBM?  Those reports go directly to me.
> > >>
> > >> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
> > >>
> > >> Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> > >
> > > Thanks, Queued.
> >
> > Any particular reason this didn't show up in:
> >     [GIT PULL] platform-drivers-x86 for 4.4-1
> >
> > Just a kind reminder, in case it slipped through the cracks.
>
> Thank you, appears to be an error on my part, possibly due to some tooling
> changes on my end. Apologies, I'll get 4.4-2 out within the merge window and be
> sure to include this.
>
> --
> Darren Hart
> Intel Open Source Technology Center
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Hi Guys,

Actually could we just remove this log message altogether I don't think
it is very useful. The likelihood of this log indicating an error or
"Unsupported brightness interface" is very very low I imagine. This
appears on my Lenovo E540 (b variable in switch statement is 101 in my
case), I have been using Linux on this machine for well over a year and
the brightness interface is definitely very well supported. From
talking to this guy on a completely different thread it seems to happen
on his machine also:

https://github.com/mate-desktop/mate-power-manager/issues/179#issuecomment-169085313

Or else I can add a 101 switch case to the statement?

Also another query, could be a mini-side project for me as I'm a
beginner kernel dev when I have some spare time. Could we change the
minimum brightness value not to be off? 0 does not have to mean
backlight off from reading various things around the web:

http://www.x.org/wiki/Events/XDC2014/XDC2014GoedeBacklight/backlight.pdf

And to be honest having the ability to completely turn off the
backlight is a useless function and is probably unintended as discussed
in the github thread above also. You would need night vision googles to
read the screen in this state! I'm pretty sure the Windows driver does
not completely turn off the screen on minimum brightness either, no
need to have different functionality on different platforms especially
when this functionality isn't very useful.

As suggested on the GitHub thread also, on other Lenovo machines (T60),
minimum brightness (0) does not mean off, so it would be nice to have
some consistency here.

Let me know what you think, I'd be happy to implement both these things
if you guys agree. I don't see much point in writing code if it won't
be accepted!

Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

[David Herrmann]

Hi

On Thu, Jan 7, 2016 at 2:03 AM, Eric Curtin <ericcurtin17@gmail.com> wrote:
> Also another query, could be a mini-side project for me as I'm a
> beginner kernel dev when I have some spare time. Could we change the
> minimum brightness value not to be off? 0 does not have to mean
> backlight off from reading various things around the web:
>
> http://www.x.org/wiki/Events/XDC2014/XDC2014GoedeBacklight/backlight.pdf
>
> And to be honest having the ability to completely turn off the
> backlight is a useless function and is probably unintended as discussed
> in the github thread above also. You would need night vision googles to
> read the screen in this state! I'm pretty sure the Windows driver does
> not completely turn off the screen on minimum brightness either, no
> need to have different functionality on different platforms especially
> when this functionality isn't very useful.

Whether '0' means 'off' or 'lowest brightness level' has been
discussed several times. Sadly, we cannot change semantics without
breaking user-space, so you better work around it. There have been
several proposals to fix it, but I guess no-one cared so far.

Anyway, both features (turning backlight off *and* lowest backlight
level) _are_ used actively by user-space. Hence, both should be
supported.

Thanks
David

Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

[Eric Curtin]

On 8 January 2016 at 11:55, David Herrmann <dh.herrmann@gmail.com> wrote:
> Hi
>
> On Thu, Jan 7, 2016 at 2:03 AM, Eric Curtin <ericcurtin17@gmail.com> wrote:
>> Also another query, could be a mini-side project for me as I'm a
>> beginner kernel dev when I have some spare time. Could we change the
>> minimum brightness value not to be off? 0 does not have to mean
>> backlight off from reading various things around the web:
>>
>> http://www.x.org/wiki/Events/XDC2014/XDC2014GoedeBacklight/backlight.pdf
>>
>> And to be honest having the ability to completely turn off the
>> backlight is a useless function and is probably unintended as discussed
>> in the github thread above also. You would need night vision googles to
>> read the screen in this state! I'm pretty sure the Windows driver does
>> not completely turn off the screen on minimum brightness either, no
>> need to have different functionality on different platforms especially
>> when this functionality isn't very useful.
>
> Whether '0' means 'off' or 'lowest brightness level' has been
> discussed several times. Sadly, we cannot change semantics without
> breaking user-space, so you better work around it. There have been
> several proposals to fix it, but I guess no-one cared so far.
>
> Anyway, both features (turning backlight off *and* lowest backlight
> level) _are_ used actively by user-space. Hence, both should be
> supported.
>
> Thanks
> David

As regards the "Unsupported brightness interface" log message will I
add 101 to the switch statement so it doesn't get reported on my device
or just remove it? This seems to be reporting many false positives (or
negatives whatever way you want to look at it) on different machines so
can I remove this logging?

Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

[Henrique de Moraes Holschuh]

On Fri, Jan 8, 2016, at 15:26, Eric Curtin wrote:
> As regards the "Unsupported brightness interface" log message will I
> add 101 to the switch statement so it doesn't get reported on my device
> or just remove it? This seems to be reporting many false positives (or
> negatives whatever way you want to look at it) on different machines so
> can I remove this logging?

Either remove the message, or leave it at debug level.  Do not add 101
to the switch case, please.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh