From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Dave Hansen <dave@sr71.net>
Cc: akpm@linux-foundation.org, n-horiguchi@ah.jp.nec.com,
mike.kravetz@oracle.com, hillf.zj@alibaba-inc.com,
rientjes@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com
Subject: Re: [PATCH] mm, hugetlb: use memory policy when available
Date: Wed, 21 Oct 2015 18:12:02 +0300 [thread overview]
Message-ID: <20151021151202.GD10597@node.shutemov.name> (raw)
In-Reply-To: <20151020195317.ADA052D8@viggo.jf.intel.com>
On Tue, Oct 20, 2015 at 12:53:17PM -0700, Dave Hansen wrote:
> @@ -1445,6 +1514,10 @@ static struct page *alloc_buddy_huge_pag
> if (hstate_is_gigantic(h))
> return NULL;
>
> + if (vma || addr) {
> + WARN_ON_ONCE(!addr || addr == -1);
Trinity triggered the WARN for me:
[ 118.647212] WARNING: CPU: 10 PID: 9621 at /home/kas/linux/mm/mm/hugetlb.c:1514 __alloc_buddy_huge_page+0x2c8/0x300()
[ 118.648698] Modules linked in:
[ 118.649105] CPU: 10 PID: 9621 Comm: trinity-c147 Not tainted 4.2.0-dirty #651
[ 118.649909] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS Debian-1.8.2-1 04/01/2014
[ 118.650929] ffffffff81ca6ad8 ffff88081f7f3c68 ffffffff818a9977 0000000080000001
[ 118.651889] 0000000000000000 ffff88081f7f3ca8 ffffffff810574d6 ffff88081f7f3c98
[ 118.652965] 0000000000000000 ffffffff830a87e0 00000000ffffffff ffffffffffffffff
[ 118.653988] Call Trace:
[ 118.654315] [<ffffffff818a9977>] dump_stack+0x4f/0x7b
[ 118.654936] [<ffffffff810574d6>] warn_slowpath_common+0x86/0xc0
[ 118.655630] [<ffffffff810575ca>] warn_slowpath_null+0x1a/0x20
[ 118.656427] [<ffffffff811ac5e8>] __alloc_buddy_huge_page+0x2c8/0x300
[ 118.657185] [<ffffffff811ad081>] hugetlb_acct_memory+0xa1/0x3d0
[ 118.657897] [<ffffffff811ab241>] ? region_chg+0x1f1/0x200
[ 118.658559] [<ffffffff811ae932>] hugetlb_reserve_pages+0x92/0x250
[ 118.659289] [<ffffffff812d517c>] hugetlb_file_setup+0x14c/0x320
[ 118.659994] [<ffffffff813d2fd5>] newseg+0x135/0x370
[ 118.660713] [<ffffffff813cc134>] ? ipcget+0x44/0x2d0
[ 118.661306] [<ffffffff813cc360>] ipcget+0x270/0x2d0
[ 118.661911] [<ffffffff813d3525>] SyS_shmget+0x45/0x50
[ 118.663409] [<ffffffff818b2c7c>] tracesys_phase2+0x84/0x89
[ 118.664199] ---[ end trace d2829191292b44ef ]---
> + WARN_ON_ONCE(nid != NUMA_NO_NODE);
> + }
> /*
> * Assume we will successfully allocate the surplus page to
> * prevent racing processes from causing the surplus to exceed
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Dave Hansen <dave@sr71.net>
Cc: akpm@linux-foundation.org, n-horiguchi@ah.jp.nec.com,
mike.kravetz@oracle.com, hillf.zj@alibaba-inc.com,
rientjes@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com
Subject: Re: [PATCH] mm, hugetlb: use memory policy when available
Date: Wed, 21 Oct 2015 18:12:02 +0300 [thread overview]
Message-ID: <20151021151202.GD10597@node.shutemov.name> (raw)
In-Reply-To: <20151020195317.ADA052D8@viggo.jf.intel.com>
On Tue, Oct 20, 2015 at 12:53:17PM -0700, Dave Hansen wrote:
> @@ -1445,6 +1514,10 @@ static struct page *alloc_buddy_huge_pag
> if (hstate_is_gigantic(h))
> return NULL;
>
> + if (vma || addr) {
> + WARN_ON_ONCE(!addr || addr == -1);
Trinity triggered the WARN for me:
[ 118.647212] WARNING: CPU: 10 PID: 9621 at /home/kas/linux/mm/mm/hugetlb.c:1514 __alloc_buddy_huge_page+0x2c8/0x300()
[ 118.648698] Modules linked in:
[ 118.649105] CPU: 10 PID: 9621 Comm: trinity-c147 Not tainted 4.2.0-dirty #651
[ 118.649909] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS Debian-1.8.2-1 04/01/2014
[ 118.650929] ffffffff81ca6ad8 ffff88081f7f3c68 ffffffff818a9977 0000000080000001
[ 118.651889] 0000000000000000 ffff88081f7f3ca8 ffffffff810574d6 ffff88081f7f3c98
[ 118.652965] 0000000000000000 ffffffff830a87e0 00000000ffffffff ffffffffffffffff
[ 118.653988] Call Trace:
[ 118.654315] [<ffffffff818a9977>] dump_stack+0x4f/0x7b
[ 118.654936] [<ffffffff810574d6>] warn_slowpath_common+0x86/0xc0
[ 118.655630] [<ffffffff810575ca>] warn_slowpath_null+0x1a/0x20
[ 118.656427] [<ffffffff811ac5e8>] __alloc_buddy_huge_page+0x2c8/0x300
[ 118.657185] [<ffffffff811ad081>] hugetlb_acct_memory+0xa1/0x3d0
[ 118.657897] [<ffffffff811ab241>] ? region_chg+0x1f1/0x200
[ 118.658559] [<ffffffff811ae932>] hugetlb_reserve_pages+0x92/0x250
[ 118.659289] [<ffffffff812d517c>] hugetlb_file_setup+0x14c/0x320
[ 118.659994] [<ffffffff813d2fd5>] newseg+0x135/0x370
[ 118.660713] [<ffffffff813cc134>] ? ipcget+0x44/0x2d0
[ 118.661306] [<ffffffff813cc360>] ipcget+0x270/0x2d0
[ 118.661911] [<ffffffff813d3525>] SyS_shmget+0x45/0x50
[ 118.663409] [<ffffffff818b2c7c>] tracesys_phase2+0x84/0x89
[ 118.664199] ---[ end trace d2829191292b44ef ]---
> + WARN_ON_ONCE(nid != NUMA_NO_NODE);
> + }
> /*
> * Assume we will successfully allocate the surplus page to
> * prevent racing processes from causing the surplus to exceed
--
Kirill A. Shutemov
next prev parent reply other threads:[~2015-10-21 15:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 19:53 [PATCH] mm, hugetlb: use memory policy when available Dave Hansen
2015-10-20 19:53 ` Dave Hansen
2015-10-20 22:19 ` Andrew Morton
2015-10-20 22:19 ` Andrew Morton
2015-10-21 15:12 ` Kirill A. Shutemov [this message]
2015-10-21 15:12 ` Kirill A. Shutemov
2015-10-22 21:39 ` Sasha Levin
2015-10-22 21:39 ` Sasha Levin
2015-10-22 21:42 ` Dave Hansen
2015-10-22 21:42 ` Dave Hansen
2015-11-03 19:12 ` Sasha Levin
2015-11-03 19:12 ` Sasha Levin
2015-11-05 13:47 ` Vlastimil Babka
2015-11-05 13:47 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021151202.GD10597@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave@sr71.net \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.