Re: ASoC: Intel: Skylake: Add SKL DSP initialization

Re: ASoC: Intel: Skylake: Add SKL DSP initialization

[Dan Carpenter]

Hello Subhransu S. Prusty,

The patch a750ba5f5a56: "ASoC: Intel: Skylake: Add SKL DSP
initialization" from Jul 10, 2015, leads to the following static
checker warning:

	sound/soc/intel/skylake/skl-sst.c:270 skl_sst_dsp_init()
	info: ignoring unreachable code.

sound/soc/intel/skylake/skl-sst.c
   252          sst->dsp_ops = dsp_ops;
   253          sst->fw_ops = skl_fw_ops;
   254  
   255          ret = skl_ipc_init(dev, skl);
   256          if (ret)
   257                  return ret;
   258  
   259          ret = sst->fw_ops.load_fw(sst);
   260          if (ret < 0) {
   261                  dev_err(dev, "Load base fw failed : %d", ret);
   262                  return ret;

Presumably this should be a "goto free_ipc;" here?

   263          }
   264  
   265          if (dsp)
   266                  *dsp = skl;
   267  
   268          return 0;
   269  
   270          skl_ipc_free(&skl->ipc);
                ^^^^^^^^^^^^^^^^^^^^^^^
Unreachable.

   271          return ret;
   272  }
   273  EXPORT_SYMBOL_GPL(skl_sst_dsp_init);


regards,
dan carpenter