From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Daniel Baluta <daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
jlbec-aKy9MeLSZ9dg9hUCZPvPmw@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org,
knaack.h-Mmb7MZpHnFY@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org,
patrick.porlan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
adriana.reus-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
constantin.musca-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
marten-4zOpVvZifTgX8gGd4fc/mEEOCMrvLtNR@public.gmane.org,
cristina.opriceana-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
hch-jcswGhMUV9g@public.gmane.org,
viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Subject: Re: [PATCH v8 1/5] configfs: Allow dynamic group creation
Date: Thu, 22 Oct 2015 10:40:34 +0200 [thread overview]
Message-ID: <20151022084034.GA21923@lst.de> (raw)
In-Reply-To: <1445338426-4126-2-git-send-email-daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Tue, Oct 20, 2015 at 01:53:42PM +0300, Daniel Baluta wrote:
> We don't want to hardcode default groups at subsystem
> creation time. We export:
> * configfs_register_group
> * configfs_unregister_group
> to allow drivers to programatically create/destroy groups
> later, after module init time.
>
> This is needed for IIO configfs support.
This looks like a good start, and maybe we should merge it as is given
that merge window is about to end. But I have two requests, one trivial
and one not so:
a) please provide kerneldoc comments for the new functions
b) just pass the name and item type and dynamically allocate the
actua group. With that we can avoid a lot of boilerplate code and
could also replace the horrible static sized defaults_groups array
in current users with your new function.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: jic23@kernel.org, jlbec@evilplan.org, linux-iio@vger.kernel.org,
linux-fsdevel@vger.kernel.org, lars@metafoo.de, knaack.h@gmx.de,
linux-kernel@vger.kernel.org, octavian.purdila@intel.com,
pebolle@tiscali.nl, patrick.porlan@intel.com,
adriana.reus@intel.com, constantin.musca@intel.com,
marten@intuitiveaerial.com, cristina.opriceana@gmail.com,
pmeerw@pmeerw.net, hch@lst.de, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org
Subject: Re: [PATCH v8 1/5] configfs: Allow dynamic group creation
Date: Thu, 22 Oct 2015 10:40:34 +0200 [thread overview]
Message-ID: <20151022084034.GA21923@lst.de> (raw)
In-Reply-To: <1445338426-4126-2-git-send-email-daniel.baluta@intel.com>
On Tue, Oct 20, 2015 at 01:53:42PM +0300, Daniel Baluta wrote:
> We don't want to hardcode default groups at subsystem
> creation time. We export:
> * configfs_register_group
> * configfs_unregister_group
> to allow drivers to programatically create/destroy groups
> later, after module init time.
>
> This is needed for IIO configfs support.
This looks like a good start, and maybe we should merge it as is given
that merge window is about to end. But I have two requests, one trivial
and one not so:
a) please provide kerneldoc comments for the new functions
b) just pass the name and item type and dynamically allocate the
actua group. With that we can avoid a lot of boilerplate code and
could also replace the horrible static sized defaults_groups array
in current users with your new function.
next prev parent reply other threads:[~2015-10-22 8:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 10:53 [PATCH v8 0/5] Add initial configfs support for IIO Daniel Baluta
2015-10-20 10:53 ` [PATCH v8 1/5] configfs: Allow dynamic group creation Daniel Baluta
[not found] ` <1445338426-4126-2-git-send-email-daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-10-22 8:40 ` Christoph Hellwig [this message]
2015-10-22 8:40 ` Christoph Hellwig
2015-10-22 8:59 ` Daniel Baluta
2015-10-20 10:53 ` [PATCH v8 2/5] iio: core: Introduce IIO configfs support Daniel Baluta
2015-10-20 14:39 ` kbuild test robot
2015-10-20 10:53 ` [PATCH v8 3/5] iio: core: Introduce IIO software triggers Daniel Baluta
2015-10-20 12:09 ` kbuild test robot
[not found] ` <1445338426-4126-4-git-send-email-daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-10-20 12:09 ` [RFC PATCH] iio: core: iio_triggers_group_type can be static kbuild test robot
2015-10-20 12:09 ` kbuild test robot
2015-10-20 10:53 ` [PATCH v8 4/5] iio: trigger: Introduce IIO hrtimer based trigger Daniel Baluta
2015-10-20 10:53 ` [PATCH v8 5/5] iio: Documentation: Add IIO configfs documentation Daniel Baluta
[not found] ` <1445338426-4126-6-git-send-email-daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-10-20 11:50 ` Crt Mori
2015-10-20 11:50 ` Crt Mori
2015-10-20 13:28 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022084034.GA21923@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=adriana.reus-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=constantin.musca-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=cristina.opriceana-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=jlbec-aKy9MeLSZ9dg9hUCZPvPmw@public.gmane.org \
--cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marten-4zOpVvZifTgX8gGd4fc/mEEOCMrvLtNR@public.gmane.org \
--cc=octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=patrick.porlan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org \
--cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.