All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] serial: msm_serial: Make config tristate
Date: Thu, 22 Oct 2015 09:50:44 -0400	[thread overview]
Message-ID: <20151022135044.GD4588@windriver.com> (raw)
In-Reply-To: <1445468723-948-1-git-send-email-sboyd@codeaurora.org>

[[PATCH] serial: msm_serial: Make config tristate] On 21/10/2015 (Wed 16:05) Stephen Boyd wrote:

> This driver works as a module, so mark it as a tristate config
> instead of a bool.
> 
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> 
> I tested this with a busybox ramdisk that modprobes msm_serial and
> then runs a getty on ttyMSM0. This patch should supersede Paul's earlier
> patch that removes the module code from this driver.

Thanks, I'll drop my patch for this driver.

Paul.
--

> 
>  drivers/tty/serial/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 1aec4404062d..e4f35da3de27 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1044,7 +1044,7 @@ config SERIAL_SGI_IOC3
>  	  say Y or M.  Otherwise, say N.
>  
>  config SERIAL_MSM
> -	bool "MSM on-chip serial port support"
> +	tristate "MSM on-chip serial port support"
>  	depends on ARCH_QCOM
>  	select SERIAL_CORE
>  
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

WARNING: multiple messages have this Message-ID (diff)
From: paul.gortmaker@windriver.com (Paul Gortmaker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: msm_serial: Make config tristate
Date: Thu, 22 Oct 2015 09:50:44 -0400	[thread overview]
Message-ID: <20151022135044.GD4588@windriver.com> (raw)
In-Reply-To: <1445468723-948-1-git-send-email-sboyd@codeaurora.org>

[[PATCH] serial: msm_serial: Make config tristate] On 21/10/2015 (Wed 16:05) Stephen Boyd wrote:

> This driver works as a module, so mark it as a tristate config
> instead of a bool.
> 
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> 
> I tested this with a busybox ramdisk that modprobes msm_serial and
> then runs a getty on ttyMSM0. This patch should supersede Paul's earlier
> patch that removes the module code from this driver.

Thanks, I'll drop my patch for this driver.

Paul.
--

> 
>  drivers/tty/serial/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 1aec4404062d..e4f35da3de27 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1044,7 +1044,7 @@ config SERIAL_SGI_IOC3
>  	  say Y or M.  Otherwise, say N.
>  
>  config SERIAL_MSM
> -	bool "MSM on-chip serial port support"
> +	tristate "MSM on-chip serial port support"
>  	depends on ARCH_QCOM
>  	select SERIAL_CORE
>  
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>, <linux-kernel@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] serial: msm_serial: Make config tristate
Date: Thu, 22 Oct 2015 09:50:44 -0400	[thread overview]
Message-ID: <20151022135044.GD4588@windriver.com> (raw)
In-Reply-To: <1445468723-948-1-git-send-email-sboyd@codeaurora.org>

[[PATCH] serial: msm_serial: Make config tristate] On 21/10/2015 (Wed 16:05) Stephen Boyd wrote:

> This driver works as a module, so mark it as a tristate config
> instead of a bool.
> 
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> 
> I tested this with a busybox ramdisk that modprobes msm_serial and
> then runs a getty on ttyMSM0. This patch should supersede Paul's earlier
> patch that removes the module code from this driver.

Thanks, I'll drop my patch for this driver.

Paul.
--

> 
>  drivers/tty/serial/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 1aec4404062d..e4f35da3de27 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1044,7 +1044,7 @@ config SERIAL_SGI_IOC3
>  	  say Y or M.  Otherwise, say N.
>  
>  config SERIAL_MSM
> -	bool "MSM on-chip serial port support"
> +	tristate "MSM on-chip serial port support"
>  	depends on ARCH_QCOM
>  	select SERIAL_CORE
>  
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

  parent reply	other threads:[~2015-10-22 13:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 23:05 [PATCH] serial: msm_serial: Make config tristate Stephen Boyd
2015-10-21 23:05 ` Stephen Boyd
2015-10-22  2:50 ` Andy Gross
2015-10-22  2:50   ` Andy Gross
2015-10-22 13:50 ` Paul Gortmaker [this message]
2015-10-22 13:50   ` Paul Gortmaker
2015-10-22 13:50   ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151022135044.GD4588@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.