From: Pratyush Anand <panand@redhat.com>
To: Geoff Levand <geoff@infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
AKASHI@infradead.org, marc.zyngier@arm.com,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Takahiro <takahiro.akashi@linaro.org>,
linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org,
christoffer.dall@linaro.org
Subject: Re: [PATCH 08/16] arm64/kexec: Add core kexec support
Date: Fri, 23 Oct 2015 12:59:50 +0530 [thread overview]
Message-ID: <20151023072950.GC25029@dhcppc13.redhat.com> (raw)
In-Reply-To: <1445361565.30908.68.camel@infradead.org>
On 20/10/2015:10:19:25 AM, Geoff Levand wrote:
> Hi,
>
> On Tue, 2015-10-20 at 14:26 +0530, Pratyush Anand wrote:
> > On 19/10/2015:11:38:53 PM, Geoff Levand wrote:
> > > +static void soft_restart(unsigned long addr)
> > > +{
> > > +> > > > setup_mm_for_reboot();
> > > +> > > > cpu_soft_restart(virt_to_phys(cpu_reset), addr,
> > > +> > > > > > is_hyp_mode_available());
> >
> > So now we do not flush cache for any memory region. Shouldn't we still flush
> > at least kernel and purgatory segments.
>
> Relevant pages of the kexec list are flushed in the code following the comment
> 'Invalidate dest page to PoC' of the arm64_relocate_new_kernel routine:
>
> The dcache is turned off
> The page is invalidated to PoC
> The new page is written
Thanks for clarifying it.
I tested your kexec-v10.2 with mustang.
Tested-by: Pratyush Anand <panand@redhat.com>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: panand@redhat.com (Pratyush Anand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/16] arm64/kexec: Add core kexec support
Date: Fri, 23 Oct 2015 12:59:50 +0530 [thread overview]
Message-ID: <20151023072950.GC25029@dhcppc13.redhat.com> (raw)
In-Reply-To: <1445361565.30908.68.camel@infradead.org>
On 20/10/2015:10:19:25 AM, Geoff Levand wrote:
> Hi,
>
> On Tue, 2015-10-20 at 14:26 +0530, Pratyush Anand wrote:
> > On 19/10/2015:11:38:53 PM, Geoff Levand wrote:
> > > +static void soft_restart(unsigned long addr)
> > > +{
> > > +> > > > setup_mm_for_reboot();
> > > +> > > > cpu_soft_restart(virt_to_phys(cpu_reset), addr,
> > > +> > > > > > is_hyp_mode_available());
> >
> > So now we do not flush cache for any memory region. Shouldn't we still flush
> > at least kernel and purgatory segments.
>
> Relevant pages of the kexec list are flushed in the code following the comment
> 'Invalidate dest page to PoC' of the arm64_relocate_new_kernel routine:
>
> The dcache is turned off
> The page is invalidated to PoC
> The new page is written
Thanks for clarifying it.
I tested your kexec-v10.2 with mustang.
Tested-by: Pratyush Anand <panand@redhat.com>
next prev parent reply other threads:[~2015-10-23 7:29 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 23:38 [PATCH 00/16] arm64 kexec kernel patches v10 Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 04/16] arm64: kvm: allows kvm cpu hotplug Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-20 18:57 ` [PATCH v10.1 " Geoff Levand
2015-10-20 18:57 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 01/16] arm64: Fold proc-macros.S into assembler.h Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 08/16] arm64/kexec: Add core kexec support Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-20 8:56 ` Pratyush Anand
2015-10-20 8:56 ` Pratyush Anand
2015-10-20 17:19 ` Geoff Levand
2015-10-20 17:19 ` Geoff Levand
2015-10-23 7:29 ` Pratyush Anand [this message]
2015-10-23 7:29 ` Pratyush Anand
2015-10-21 18:30 ` [PATCH v10.2 " Geoff Levand
2015-10-21 18:30 ` Geoff Levand
2015-10-30 16:29 ` [PATCH " James Morse
2015-10-30 16:29 ` James Morse
2015-10-30 16:54 ` Mark Rutland
2015-10-30 16:54 ` Mark Rutland
2015-11-02 9:26 ` Pratyush Anand
2015-11-02 9:26 ` Pratyush Anand
2015-11-03 0:30 ` Geoff Levand
2015-11-03 0:30 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 03/16] arm64: Add new hcall HVC_CALL_FUNC Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 07/16] Revert "arm64: remove dead code" Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 06/16] arm64: Add EL2 switch to cpu_reset Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 02/16] arm64: Convert hcalls to use HVC immediate value Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 05/16] arm64: Add back cpu_reset routines Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 09/16] arm64/kexec: Add pr_devel output Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 14/16] arm64: kdump: update a kernel doc Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 10/16] arm64/kexec: Enable kexec in the arm64 defconfig Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 15/16] arm64: kdump: enable kdump " Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 16/16] arm64: kdump: relax BUG_ON() if more than one cpus are still active Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 13/16] arm64: kdump: add kdump support Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-22 3:25 ` Dave Young
2015-10-22 3:25 ` Dave Young
2015-10-22 4:29 ` AKASHI Takahiro
2015-10-22 4:29 ` AKASHI Takahiro
2015-10-22 5:15 ` Dave Young
2015-10-22 5:15 ` Dave Young
2015-10-22 9:57 ` AKASHI Takahiro
2015-10-22 9:57 ` AKASHI Takahiro
2015-10-23 9:50 ` Dave Young
2015-10-23 9:50 ` Dave Young
2015-10-29 5:55 ` AKASHI Takahiro
2015-10-29 5:55 ` AKASHI Takahiro
2015-10-29 6:40 ` Dave Young
2015-10-29 6:40 ` Dave Young
2015-10-29 6:53 ` AKASHI Takahiro
2015-10-29 6:53 ` AKASHI Takahiro
2015-10-29 7:01 ` Dave Young
2015-10-29 7:01 ` Dave Young
2015-10-19 23:38 ` [PATCH 12/16] arm64: kdump: implement machine_crash_shutdown() Geoff Levand
2015-10-19 23:38 ` Geoff Levand
2015-10-20 18:54 ` [PATCH v10.1 " Geoff Levand
2015-10-20 18:54 ` Geoff Levand
2015-10-19 23:38 ` [PATCH 11/16] arm64: kdump: reserve memory for crash dump kernel Geoff Levand
2015-10-19 23:38 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151023072950.GC25029@dhcppc13.redhat.com \
--to=panand@redhat.com \
--cc=AKASHI@infradead.org \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=geoff@infradead.org \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=takahiro.akashi@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.