From: Stephen Hemminger <stephen@networkplumber.org>
To: "Alejandro.Lucero" <alejandro.lucero@netronome.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v4] nfp: new poll mode driver for netronome nfp-6xxx card
Date: Fri, 23 Oct 2015 09:05:48 -0700 [thread overview]
Message-ID: <20151023090548.5fa59e0e@xeon-e3> (raw)
In-Reply-To: <1445596563-16818-2-git-send-email-alejandro.lucero@netronome.com>
On Fri, 23 Oct 2015 11:36:02 +0100
"Alejandro.Lucero" <alejandro.lucero@netronome.com> wrote:
> +static inline __u32
> +nfp_qcp_read(__u8 *q, enum nfp_qcp_ptr ptr)
> +{
> + __u32 off;
> + __u32 val;
> +
Please don't use Linux kernel typedefs (__u32) in DPDK code.
Instead use stdint types (uint32_t)
next prev parent reply other threads:[~2015-10-23 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 10:36 [PATCH v4] support for netronome nfp-6xxx card Alejandro.Lucero
2015-10-23 10:36 ` [PATCH v4] nfp: new poll mode driver " Alejandro.Lucero
2015-10-23 16:05 ` Stephen Hemminger [this message]
2015-10-26 14:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151023090548.5fa59e0e@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.