From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Alejandro.Lucero" <alejandro.lucero@netronome.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v4] nfp: new poll mode driver for netronome nfp-6xxx card
Date: Mon, 26 Oct 2015 15:46:30 +0100 [thread overview]
Message-ID: <2192125.8cJDpqYsAL@xps13> (raw)
In-Reply-To: <1445596563-16818-2-git-send-email-alejandro.lucero@netronome.com>
2015-10-23 11:36, Alejandro.Lucero:
> From: "Alejandro.Lucero" <alejandro.lucero@netronome.com>
>
> This patch adds a new PMD for using PCI Virtual Functions with Netronome
> nfp6000 card.
>
> Signed-off-by: Alejandro.Lucero <alejandro.lucero@netronome.com>
> Signed-off-by: Rolf.Neugebauer <rolf.neugebauer@netronome.com>
> ---
> drivers/net/nfp/Makefile | 88 ++
> drivers/net/nfp/nfp_net.c | 2495 ++++++++++++++++++++++++++++++++++++++++
> drivers/net/nfp/nfp_net_ctrl.h | 290 +++++
> drivers/net/nfp/nfp_net_logs.h | 75 ++
> drivers/net/nfp/nfp_net_pmd.h | 434 +++++++
It seems this driver is not integrated in the build system.
Please avoid such huge patch and submit piece by piece.
Example:
- patch 1 for the basic init
- patch 2 for Rx/Tx
- patch 3 for RSS
- patch 4 for statistics
It will be easier to review.
It would be also appreciated to have a doc in doc/guides/nics
and an entry in the release notes.
Thanks
prev parent reply other threads:[~2015-10-26 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 10:36 [PATCH v4] support for netronome nfp-6xxx card Alejandro.Lucero
2015-10-23 10:36 ` [PATCH v4] nfp: new poll mode driver " Alejandro.Lucero
2015-10-23 16:05 ` Stephen Hemminger
2015-10-26 14:46 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2192125.8cJDpqYsAL@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.