From: Mark Brown <broonie@kernel.org>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Johan Hovold <johan@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Arnd Bergmann <arnd@arndb.de>,
Michael Welling <mwelling@ieee.org>,
Markus Pargmann <mpa@pengutronix.de>,
Amit Kucheria <amit.kucheria@linaro.org>
Subject: Re: [PATCH 1/6] gpio: make the gpiochip a real device
Date: Mon, 26 Oct 2015 11:12:46 +0900 [thread overview]
Message-ID: <20151026021246.GA28319@sirena.org.uk> (raw)
In-Reply-To: <CAAVeFuLMqCE81c8_e009uu1bYypmbagHS1DnPkZ1vxcuU=ukQg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
On Sun, Oct 25, 2015 at 04:06:26PM +0900, Alexandre Courbot wrote:
> On Thu, Oct 22, 2015 at 5:32 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> > If sysfs is active, it will use this device as parent, and the
> > former parent device "dev" will be set as parent of the new
> > "device" struct member.
> Why not rename "dev" to "parent" so "dev" becomes what we expect it to
> be? The two members being of the same type, keeping it that way seems
> error-prone to me.
Indeed, that's going to be hard to follow with nothing in the names that
says which is which. Another option that some subsystems use is to add
the subsystem specific device with a name like gpio_dev that indicates
it's the subsystem version of the device.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-26 2:12 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 8:32 [PATCH 0/6] GPIO character device skeleton Linus Walleij
2015-10-22 8:32 ` [PATCH 1/6] gpio: make the gpiochip a real device Linus Walleij
2015-10-24 18:09 ` Markus Pargmann
2015-10-25 7:06 ` Alexandre Courbot
2015-10-26 2:12 ` Mark Brown [this message]
2015-11-03 21:20 ` Linus Walleij
2015-11-02 10:31 ` Johan Hovold
2015-11-02 12:25 ` Mark Brown
2015-11-02 12:43 ` Johan Hovold
2015-11-02 12:47 ` Mark Brown
2015-11-02 12:53 ` Johan Hovold
2015-11-02 13:06 ` Mark Brown
2015-11-02 13:14 ` Johan Hovold
2015-11-02 13:17 ` Mark Brown
2015-11-02 13:25 ` Johan Hovold
2015-11-03 21:24 ` Linus Walleij
2015-11-04 10:48 ` Linus Walleij
2015-11-05 9:44 ` Johan Hovold
2015-11-05 10:29 ` Mark Brown
2015-11-16 14:27 ` Linus Walleij
2015-12-03 14:04 ` Linus Walleij
2015-12-03 14:06 ` Linus Walleij
2015-12-03 21:26 ` Michael Welling
2015-12-04 22:31 ` Michael Welling
2015-12-11 17:58 ` Linus Walleij
2015-12-08 9:29 ` Johan Hovold
2015-12-11 18:06 ` Linus Walleij
2015-10-22 8:32 ` [PATCH 2/6] gpio: refer to gpio device in prints and debugfs Linus Walleij
2015-10-22 8:32 ` [PATCH 3/6] gpio: add a userspace chardev ABI for GPIOs Linus Walleij
2015-10-22 20:35 ` Michael Welling
2015-10-24 0:30 ` Greg Kroah-Hartman
2016-01-28 11:13 ` Linus Walleij
2015-10-26 1:34 ` Mark Brown
2016-01-27 10:05 ` Bamvor Zhang Jian
2016-01-28 11:14 ` Linus Walleij
2016-01-29 10:24 ` Bamvor Zhang Jian
2016-02-10 10:04 ` Linus Walleij
2015-10-22 8:32 ` [PATCH 4/6] tools/gpio: create GPIO tools Linus Walleij
2015-10-25 8:23 ` Alexandre Courbot
2015-10-22 8:32 ` [PATCH 5/6] gpio: add a userspace character device ABI Linus Walleij
2015-10-24 18:46 ` Markus Pargmann
2015-10-22 8:32 ` [PATCH 6/6] gpio: ABI: mark the sysfs ABI as obsolete Linus Walleij
2015-10-22 18:57 ` [PATCH 0/6] GPIO character device skeleton Michael Welling
2015-10-24 17:53 ` Markus Pargmann
2015-10-30 14:40 ` Linus Walleij
2015-11-02 10:00 ` Johan Hovold
2015-10-24 18:42 ` Markus Pargmann
2015-10-30 1:55 ` Alexandre Courbot
2015-10-30 19:48 ` Linus Walleij
2015-11-02 10:13 ` Johan Hovold
2015-11-03 7:23 ` Markus Pargmann
2015-11-03 12:06 ` Johan Hovold
2015-11-03 17:18 ` Linus Walleij
2015-11-04 19:44 ` Michael Welling
2015-11-05 9:40 ` Johan Hovold
2015-11-05 14:11 ` Linus Walleij
2015-11-06 10:21 ` Johan Hovold
2015-11-16 13:33 ` Linus Walleij
2015-11-03 17:05 ` Linus Walleij
2015-10-30 14:43 ` Linus Walleij
2015-10-30 22:54 ` Arnd Bergmann
2015-11-01 9:37 ` Linus Walleij
2015-11-02 10:16 ` Johan Hovold
2015-10-26 2:18 ` Mark Brown
2015-10-30 1:55 ` Alexandre Courbot
2015-10-30 19:47 ` Linus Walleij
2015-11-01 2:41 ` Mark Brown
2015-11-03 7:39 ` Markus Pargmann
2015-11-03 8:50 ` Mark Brown
2015-11-03 10:21 ` Amit Kucheria
2015-11-03 17:06 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026021246.GA28319@sirena.org.uk \
--to=broonie@kernel.org \
--cc=acourbot@nvidia.com \
--cc=amit.kucheria@linaro.org \
--cc=arnd@arndb.de \
--cc=gnurou@gmail.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.