All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] cris: Drop reference to get_cmos_time()
@ 2015-10-25 22:50 Guenter Roeck
  2015-10-26 15:28 ` Jesper Nilsson
  0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2015-10-25 22:50 UTC (permalink / raw)
  To: Mikael Starvik
  Cc: Jesper Nilsson, linux-cris-kernel, linux-kernel, Guenter Roeck,
	Xunlei Pang, Rabin Vincent

Function get_cmos_time() was removed with commit 657926a83df9 ("cris:
time: Cleanup of persistent clock stuff"). The remaining reference to
it may cause the following build error.

arch/cris/kernel/built-in.o:(___ksymtab+get_cmos_time+0x0):
	undefined reference to `get_cmos_time'
Makefile:946: recipe for target 'vmlinux' failed

Fixes: 657926a83df9 ("cris: time: Cleanup of persistent clock stuff")
Cc: Xunlei Pang <pang.xunlei@linaro.org>
Cc: Rabin Vincent <rabin@rab.in>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/cris/kernel/crisksyms.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/cris/kernel/crisksyms.c b/arch/cris/kernel/crisksyms.c
index e704f81f85cc..31b4bd288cad 100644
--- a/arch/cris/kernel/crisksyms.c
+++ b/arch/cris/kernel/crisksyms.c
@@ -18,7 +18,6 @@
 #include <asm/pgtable.h>
 #include <asm/fasttimer.h>
 
-extern unsigned long get_cmos_time(void);
 extern void __Udiv(void);
 extern void __Umod(void);
 extern void __Div(void);
@@ -30,7 +29,6 @@ extern void __negdi2(void);
 extern void iounmap(volatile void * __iomem);
 
 /* Platform dependent support */
-EXPORT_SYMBOL(get_cmos_time);
 EXPORT_SYMBOL(loops_per_usec);
 
 /* Math functions */
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] cris: Drop reference to get_cmos_time()
  2015-10-25 22:50 [PATCH -next] cris: Drop reference to get_cmos_time() Guenter Roeck
@ 2015-10-26 15:28 ` Jesper Nilsson
  0 siblings, 0 replies; 2+ messages in thread
From: Jesper Nilsson @ 2015-10-26 15:28 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Mikael Starvik, Jesper Nilsson, linux-cris-kernel, linux-kernel,
	Xunlei Pang, Rabin Vincent

On Sun, Oct 25, 2015 at 03:50:59PM -0700, Guenter Roeck wrote:
> Function get_cmos_time() was removed with commit 657926a83df9 ("cris:
> time: Cleanup of persistent clock stuff"). The remaining reference to
> it may cause the following build error.
> 
> arch/cris/kernel/built-in.o:(___ksymtab+get_cmos_time+0x0):
> 	undefined reference to `get_cmos_time'
> Makefile:946: recipe for target 'vmlinux' failed

Agreed, added to the cris-tree.

Thanks,

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@axis.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-26 15:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-25 22:50 [PATCH -next] cris: Drop reference to get_cmos_time() Guenter Roeck
2015-10-26 15:28 ` Jesper Nilsson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.